All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>, Yi Liu <yi.l.liu@intel.com>,
	Eric Auger <eric.auger@redhat.com>
Subject: Re: [PATCH v8 08/10] iommu/vt-d: Add custom allocator for IOASID
Date: Fri, 10 Jan 2020 09:19:44 +0800	[thread overview]
Message-ID: <239924d4-c0c8-54c4-c6a8-bc458bcaea00@linux.intel.com> (raw)
In-Reply-To: <20200109140629.0e15c3f3@jacob-builder>

Hi,

On 1/10/20 6:06 AM, Jacob Pan wrote:
>>> +static void register_pasid_allocator(struct intel_iommu *iommu)
>>> +{
>>> +	if (!intel_iommu_sm) {
>> Use sm_supported(iommu) instead.
>>
> sounds good, seems we could separate the sm code more cleanly in the
> future to avoid all these checks.
> 

Agreed.

Best regards,
baolu

WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	iommu@lists.linux-foundation.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v8 08/10] iommu/vt-d: Add custom allocator for IOASID
Date: Fri, 10 Jan 2020 09:19:44 +0800	[thread overview]
Message-ID: <239924d4-c0c8-54c4-c6a8-bc458bcaea00@linux.intel.com> (raw)
In-Reply-To: <20200109140629.0e15c3f3@jacob-builder>

Hi,

On 1/10/20 6:06 AM, Jacob Pan wrote:
>>> +static void register_pasid_allocator(struct intel_iommu *iommu)
>>> +{
>>> +	if (!intel_iommu_sm) {
>> Use sm_supported(iommu) instead.
>>
> sounds good, seems we could separate the sm code more cleanly in the
> future to avoid all these checks.
> 

Agreed.

Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-01-10  1:21 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 19:24 [PATCH v8 00/10] Nested Shared Virtual Address (SVA) VT-d support Jacob Pan
2019-12-16 19:24 ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 01/10] iommu/vt-d: Move domain helper to header Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 02/10] iommu/vt-d: Add nested translation helper function Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-18  2:01   ` Lu Baolu
2019-12-18  2:01     ` Lu Baolu
2020-01-09 17:51     ` Jacob Pan
2020-01-09 17:51       ` Jacob Pan
2019-12-18  2:41   ` Lu Baolu
2019-12-18  2:41     ` Lu Baolu
2020-01-09 18:39     ` Jacob Pan
2020-01-09 18:39       ` Jacob Pan
2020-01-10  1:15       ` Lu Baolu
2020-01-10  1:15         ` Lu Baolu
2020-01-10 18:25         ` Jacob Pan
2020-01-10 18:25           ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 03/10] iommu/vt-d: Add bind guest PASID support Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-18  3:14   ` Lu Baolu
2019-12-18  3:14     ` Lu Baolu
2020-01-09 21:45     ` Jacob Pan
2020-01-09 21:45       ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 04/10] iommu/vt-d: Support flushing more translation cache types Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-19  2:46   ` Lu Baolu
2019-12-19  2:46     ` Lu Baolu
2020-01-09 21:50     ` Jacob Pan
2020-01-09 21:50       ` Jacob Pan
2020-01-10  1:17       ` Lu Baolu
2020-01-10  1:17         ` Lu Baolu
2019-12-16 19:24 ` [PATCH v8 05/10] iommu/vt-d: Add svm/sva invalidate function Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 06/10] iommu/vt-d: Cache virtual command capability register Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-18  3:25   ` Lu Baolu
2019-12-18  3:25     ` Lu Baolu
2020-01-09 21:59     ` Jacob Pan
2020-01-09 21:59       ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 07/10] iommu/vt-d: Enlightened PASID allocation Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 08/10] iommu/vt-d: Add custom allocator for IOASID Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-18  4:10   ` Lu Baolu
2019-12-18  4:10     ` Lu Baolu
2020-01-09 22:06     ` Jacob Pan
2020-01-09 22:06       ` Jacob Pan
2020-01-10  1:19       ` Lu Baolu [this message]
2020-01-10  1:19         ` Lu Baolu
2019-12-16 19:24 ` [PATCH v8 09/10] iommu/ioasid: Add notifier for status change Jacob Pan
2019-12-16 19:24   ` Jacob Pan
2019-12-16 19:24 ` [PATCH v8 10/10] iommu/vt-d: Handle IOASID notifications Jacob Pan
2019-12-16 19:24   ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=239924d4-c0c8-54c4-c6a8-bc458bcaea00@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=eric.auger@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.