* [PATCH] opensm - use C99 transportable data type for pointer storage
@ 2009-11-10 1:48 Stan C. Smith
[not found] ` <086F8B40ADA84EE7B6398F4761937836-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-12 19:05 ` Sasha Khapyorsky
0 siblings, 2 replies; 7+ messages in thread
From: Stan C. Smith @ 2009-11-10 1:48 UTC (permalink / raw)
To: 'Sasha Khapyorsky'; +Cc: linux-rdma, ofw
In order to skip the #ifndef __WIN__ around #include <stdint.h>, inttypes.h was used.
'inttypes.h' includes stdint.h and exists in the WinOF svn tree.
OFED opensm builds without problems on EL 5.3.
Signed-off-by: stan smith <stan.smith@intel.com>
diff --git a/opensm/include/opensm/st.h b/opensm/include/opensm/st.h
index 30cc308..ad6c289 100644
--- a/opensm/include/opensm/st.h
+++ b/opensm/include/opensm/st.h
@@ -39,6 +39,7 @@
#define ST_INCLUDED
#include <stdlib.h>
+#include <inttypes.h>
#ifdef __cplusplus
# define BEGIN_C_DECLS extern "C" {
@@ -49,7 +50,7 @@
#endif /* __cplusplus */
BEGIN_C_DECLS
-#define st_ptr_t unsigned long
+#define st_ptr_t uintptr_t
typedef st_ptr_t st_data_t;
#define ST_DATA_T_DEFINED
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] opensm - use C99 transportable data type for pointer storage
[not found] ` <086F8B40ADA84EE7B6398F4761937836-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
@ 2009-11-12 17:32 ` Smith, Stan
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1912CC482F85-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Smith, Stan @ 2009-11-12 17:32 UTC (permalink / raw)
To: 'Sasha Khapyorsky'
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5
Hello,
Can you help me understand why this patch always seems to fall into a black hole with no feedback?
Thank you,
Stan.
Stan C. Smith wrote:
> In order to skip the #ifndef __WIN__ around #include <stdint.h>,
> inttypes.h was used. 'inttypes.h' includes stdint.h and exists in the
> WinOF svn tree.
> OFED opensm builds without problems on EL 5.3.
>
> Signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> diff --git a/opensm/include/opensm/st.h b/opensm/include/opensm/st.h
> index 30cc308..ad6c289 100644
> --- a/opensm/include/opensm/st.h
> +++ b/opensm/include/opensm/st.h
> @@ -39,6 +39,7 @@
> #define ST_INCLUDED
>
> #include <stdlib.h>
> +#include <inttypes.h>
>
> #ifdef __cplusplus
> # define BEGIN_C_DECLS extern "C" {
> @@ -49,7 +50,7 @@
> #endif /* __cplusplus */
>
> BEGIN_C_DECLS
> -#define st_ptr_t unsigned long
> +#define st_ptr_t uintptr_t
> typedef st_ptr_t st_data_t;
>
> #define ST_DATA_T_DEFINED
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [ofw] RE: [PATCH] opensm - use C99 transportable data type forpointer storage
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1912CC482F85-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2009-11-12 18:09 ` Leonid Keller
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD01876DAA-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
2009-11-12 19:02 ` [PATCH] opensm - use C99 transportable data type for pointer storage Sasha Khapyorsky
1 sibling, 1 reply; 7+ messages in thread
From: Leonid Keller @ 2009-11-12 18:09 UTC (permalink / raw)
To: Smith, Stan, Sasha Khapyorsky
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5
Did you send it before morning coffee or after ? :)
Maybe, because it seems obvious.
All are agree with the elimination of unnecessary #ifndef's.
As to me, go ahead, commit it.
> -----Original Message-----
> From: ofw-bounces-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
> [mailto:ofw-bounces-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org] On Behalf Of Smith, Stan
> Sent: Thursday, November 12, 2009 7:32 PM
> To: 'Sasha Khapyorsky'
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
> Subject: [ofw] RE: [PATCH] opensm - use C99 transportable
> data type forpointer storage
>
> Hello,
> Can you help me understand why this patch always seems to
> fall into a black hole with no feedback?
>
> Thank you,
>
> Stan.
>
>
> Stan C. Smith wrote:
> > In order to skip the #ifndef __WIN__ around #include <stdint.h>,
> > inttypes.h was used. 'inttypes.h' includes stdint.h and
> exists in the
> > WinOF svn tree.
> > OFED opensm builds without problems on EL 5.3.
> >
> > Signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > diff --git a/opensm/include/opensm/st.h
> b/opensm/include/opensm/st.h
> > index 30cc308..ad6c289 100644
> > --- a/opensm/include/opensm/st.h
> > +++ b/opensm/include/opensm/st.h
> > @@ -39,6 +39,7 @@
> > #define ST_INCLUDED
> >
> > #include <stdlib.h>
> > +#include <inttypes.h>
> >
> > #ifdef __cplusplus
> > # define BEGIN_C_DECLS extern "C" {
> > @@ -49,7 +50,7 @@
> > #endif /* __cplusplus */
> >
> > BEGIN_C_DECLS
> > -#define st_ptr_t unsigned long
> > +#define st_ptr_t uintptr_t
> > typedef st_ptr_t st_data_t;
> >
> > #define ST_DATA_T_DEFINED
>
> _______________________________________________
> ofw mailing list
> ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [ofw] RE: [PATCH] opensm - use C99 transportable data type forpointer storage
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD01876DAA-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
@ 2009-11-12 18:13 ` Sean Hefty
2009-11-12 18:21 ` Smith, Stan
0 siblings, 1 reply; 7+ messages in thread
From: Sean Hefty @ 2009-11-12 18:13 UTC (permalink / raw)
To: 'Leonid Keller', Smith, Stan, Sasha Khapyorsky
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5
>Did you send it before morning coffee or after ? :)
>
>Maybe, because it seems obvious.
>All are agree with the elimination of unnecessary #ifndef's.
>As to me, go ahead, commit it.
It needs to be merged into the mgmt.git tree.
>> > #include <stdlib.h>
>> > +#include <inttypes.h>
>> >
>> > #ifdef __cplusplus
>> > # define BEGIN_C_DECLS extern "C" {
>> > @@ -49,7 +50,7 @@
>> > #endif /* __cplusplus */
>> >
>> > BEGIN_C_DECLS
>> > -#define st_ptr_t unsigned long
>> > +#define st_ptr_t uintptr_t
Does anyone know the reason for st_ptr_t at all? Why not use uintptr_t
everywhere and avoid the define?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: RE: [PATCH] opensm - use C99 transportable data type forpointer storage
2009-11-12 18:13 ` Sean Hefty
@ 2009-11-12 18:21 ` Smith, Stan
0 siblings, 0 replies; 7+ messages in thread
From: Smith, Stan @ 2009-11-12 18:21 UTC (permalink / raw)
To: Hefty, Sean, 'Leonid Keller', Sasha Khapyorsky; +Cc: linux-rdma, ofw
Hefty, Sean wrote:
>> Did you send it before morning coffee or after ? :)
>>
>> Maybe, because it seems obvious.
>> All are agree with the elimination of unnecessary #ifndef's.
>> As to me, go ahead, commit it.
>
> It needs to be merged into the mgmt.git tree.
>
>>>> #include <stdlib.h>
>>>> +#include <inttypes.h>
>>>>
>>>> #ifdef __cplusplus
>>>> # define BEGIN_C_DECLS extern "C" {
>>>> @@ -49,7 +50,7 @@
>>>> #endif /* __cplusplus */
>>>>
>>>> BEGIN_C_DECLS
>>>> -#define st_ptr_t unsigned long
>>>> +#define st_ptr_t uintptr_t
>
> Does anyone know the reason for st_ptr_t at all? Why not use
> uintptr_t everywhere and avoid the define?
This is a good question. I avoided the issue due to the fact this patch has been submitted before with no feedback so KIS is the game plan for now.
Once the uintptr_t concept has been accepted, then a 2nd step would be to replace st_ptr_t with uintptr_t and remove the #define.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] opensm - use C99 transportable data type for pointer storage
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1912CC482F85-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-11-12 18:09 ` [ofw] RE: [PATCH] opensm - use C99 transportable data type forpointer storage Leonid Keller
@ 2009-11-12 19:02 ` Sasha Khapyorsky
1 sibling, 0 replies; 7+ messages in thread
From: Sasha Khapyorsky @ 2009-11-12 19:02 UTC (permalink / raw)
To: Smith, Stan
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5
On 09:32 Thu 12 Nov , Smith, Stan wrote:
> Hello,
> Can you help me understand why this patch always seems to fall into a black hole with no feedback?
Bad luck and my wishes to understand what is going on there. However the
second is less critical in this particular case - I can do it after
applying the patch.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] opensm - use C99 transportable data type for pointer storage
2009-11-10 1:48 [PATCH] opensm - use C99 transportable data type for pointer storage Stan C. Smith
[not found] ` <086F8B40ADA84EE7B6398F4761937836-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
@ 2009-11-12 19:05 ` Sasha Khapyorsky
1 sibling, 0 replies; 7+ messages in thread
From: Sasha Khapyorsky @ 2009-11-12 19:05 UTC (permalink / raw)
To: Stan C. Smith; +Cc: linux-rdma, ofw
On 17:48 Mon 09 Nov , Stan C. Smith wrote:
>
> In order to skip the #ifndef __WIN__ around #include <stdint.h>, inttypes.h was used.
> 'inttypes.h' includes stdint.h and exists in the WinOF svn tree.
> OFED opensm builds without problems on EL 5.3.
>
> Signed-off-by: stan smith <stan.smith@intel.com>
Applied. Thanks.
Sasha
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-11-12 19:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-10 1:48 [PATCH] opensm - use C99 transportable data type for pointer storage Stan C. Smith
[not found] ` <086F8B40ADA84EE7B6398F4761937836-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-11-12 17:32 ` Smith, Stan
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1912CC482F85-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-11-12 18:09 ` [ofw] RE: [PATCH] opensm - use C99 transportable data type forpointer storage Leonid Keller
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD01876DAA-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
2009-11-12 18:13 ` Sean Hefty
2009-11-12 18:21 ` Smith, Stan
2009-11-12 19:02 ` [PATCH] opensm - use C99 transportable data type for pointer storage Sasha Khapyorsky
2009-11-12 19:05 ` Sasha Khapyorsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.