All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Wunderlich <frank-w@public-files.de>
To: angelogioacchino.delregno@collabora.com
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
	matthias.bgg@gmail.com
Subject: [BUG] mtk serial broken on mt7622 with 5.18.0
Date: Wed, 1 Jun 2022 17:07:46 +0200	[thread overview]
Message-ID: <23accb82-8f75-4773-4fad-b6218930da62@public-files.de> (raw)
In-Reply-To: <CAGXv+5Hx7cRwNzLWrExcFGy=MMOc3-0EbqCanv2E0G_DKXLCgg@mail.gmail.com>

Hi,

i get a serial console hang on booting my mt7622 bananapi r64 with 5.18.0

[    0.591802] Serial: 8250/16550 driver, 3 ports, IRQ sharing disabled
[    0.599915] printk: console [ttyS0] disabled
[    0.624563] 11002000.serial: ttyS0 at MMIO 0x11002000 (irq = 126,
base_baud = 1562500) is a 16550A

git bisect points to this commit (cannot revert it alone)

6f81fdded0d024c7d4084d434764f30bca1cd6b1 is the first bad commit
commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date:   Wed Apr 27 15:23:27 2022 +0200

     serial: 8250_mtk: Make sure to select the right FEATURE_SEL

     Set the FEATURE_SEL at probe time to make sure that BIT(0) is enabled:
     this guarantees that when the port is configured as AP UART, the
     right register layout is interpreted by the UART IP.

     Signed-off-by: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
     Cc: stable <stable@vger.kernel.org>
     Link:
https://lore.kernel.org/r/20220427132328.228297-3-angelogioacchino.delregno@collabora.com
     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  drivers/tty/serial/8250/8250_mtk.c | 7 +++++++
  1 file changed, 7 insertions(+)

merged by 6811a466d27b "Merge tag 'tty-5.18-rc7'"

reverted these 2 commits works for me
e1bfdbc7daca 2022-04-27 serial: 8250_mtk: Fix register address for
XON/XOFF character
6f81fdded0d0 2022-04-27 serial: 8250_mtk: Make sure to select the right
FEATURE_SEL

have see this discussion [1], but can't manage to import mbox file to
thunderbird yet

regards Frank

[1]
https://lore.kernel.org/linux-arm-kernel/CAGXv+5Hx7cRwNzLWrExcFGy=MMOc3-0EbqCanv2E0G_DKXLCgg@mail.gmail.com/#t

WARNING: multiple messages have this Message-ID (diff)
From: Frank Wunderlich <frank-w@public-files.de>
To: angelogioacchino.delregno@collabora.com
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
	matthias.bgg@gmail.com
Subject: [BUG] mtk serial broken on mt7622 with 5.18.0
Date: Wed, 1 Jun 2022 17:07:46 +0200	[thread overview]
Message-ID: <23accb82-8f75-4773-4fad-b6218930da62@public-files.de> (raw)
In-Reply-To: <CAGXv+5Hx7cRwNzLWrExcFGy=MMOc3-0EbqCanv2E0G_DKXLCgg@mail.gmail.com>

Hi,

i get a serial console hang on booting my mt7622 bananapi r64 with 5.18.0

[    0.591802] Serial: 8250/16550 driver, 3 ports, IRQ sharing disabled
[    0.599915] printk: console [ttyS0] disabled
[    0.624563] 11002000.serial: ttyS0 at MMIO 0x11002000 (irq = 126,
base_baud = 1562500) is a 16550A

git bisect points to this commit (cannot revert it alone)

6f81fdded0d024c7d4084d434764f30bca1cd6b1 is the first bad commit
commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date:   Wed Apr 27 15:23:27 2022 +0200

     serial: 8250_mtk: Make sure to select the right FEATURE_SEL

     Set the FEATURE_SEL at probe time to make sure that BIT(0) is enabled:
     this guarantees that when the port is configured as AP UART, the
     right register layout is interpreted by the UART IP.

     Signed-off-by: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
     Cc: stable <stable@vger.kernel.org>
     Link:
https://lore.kernel.org/r/20220427132328.228297-3-angelogioacchino.delregno@collabora.com
     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  drivers/tty/serial/8250/8250_mtk.c | 7 +++++++
  1 file changed, 7 insertions(+)

merged by 6811a466d27b "Merge tag 'tty-5.18-rc7'"

reverted these 2 commits works for me
e1bfdbc7daca 2022-04-27 serial: 8250_mtk: Fix register address for
XON/XOFF character
6f81fdded0d0 2022-04-27 serial: 8250_mtk: Make sure to select the right
FEATURE_SEL

have see this discussion [1], but can't manage to import mbox file to
thunderbird yet

regards Frank

[1]
https://lore.kernel.org/linux-arm-kernel/CAGXv+5Hx7cRwNzLWrExcFGy=MMOc3-0EbqCanv2E0G_DKXLCgg@mail.gmail.com/#t

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2022-06-01 15:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <62793d83.1c69fb81.71b96.033e@mx.google.com>
2022-05-09 16:27 ` next/pending-fixes bisection: baseline.login on mt8173-elm-hana Mark Brown
2022-05-09 16:27   ` Mark Brown
2022-05-09 16:27   ` Mark Brown
2022-05-09 18:16   ` Mark Brown
2022-05-09 18:16     ` Mark Brown
2022-05-09 18:16     ` Mark Brown
2022-05-10  8:01     ` AngeloGioacchino Del Regno
2022-05-10  8:01       ` AngeloGioacchino Del Regno
2022-05-10  8:01       ` AngeloGioacchino Del Regno
2022-05-10  8:06       ` Chen-Yu Tsai
2022-05-10  8:06         ` Chen-Yu Tsai
2022-05-10  8:06         ` Chen-Yu Tsai
2022-06-01 15:07         ` Frank Wunderlich [this message]
2022-06-01 15:07           ` [BUG] mtk serial broken on mt7622 with 5.18.0 Frank Wunderlich
2022-06-01 15:37           ` Ilpo Järvinen
2022-06-01 15:37             ` Ilpo Järvinen
2022-06-01 15:37             ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23accb82-8f75-4773-4fad-b6218930da62@public-files.de \
    --to=frank-w@public-files.de \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.