* [PATCH] udev: enhance udev detection for intel 7xxx modems
@ 2018-10-31 10:43 Nandini Rebello
2018-10-31 19:51 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Nandini Rebello @ 2018-10-31 10:43 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
Handle newer 7xxx modem enumeration based on ProductId.
Preserving the previous gen support too.
---
plugins/udevng.c | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index 11338f7..e9f16e8 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1193,13 +1193,24 @@ static gboolean setup_xmm7xxx(struct modem_info *modem)
info->interface, info->number, info->label,
info->sysattr, info->subsystem);
- if (g_strcmp0(info->subsystem, "tty") == 0) {
- if (g_strcmp0(info->number, "02") == 0)
- mdm = info->devnode;
- } else if (g_strcmp0(info->subsystem, "net") == 0) {
- if (g_strcmp0(info->number, "00") == 0)
- net = info->devnode;
+ if (g_strcmp0(modem->model,"095a") == 0) {
+ if (g_strcmp0(info->subsystem, "tty") == 0) {
+ if (g_strcmp0(info->number, "00") == 0)
+ mdm = info->devnode;
+ } else if (g_strcmp0(info->subsystem, "net") == 0) {
+ if (g_strcmp0(info->number, "06") == 0)
+ net = info->devnode;
+ }
}
+ else {
+ if (g_strcmp0(info->subsystem, "tty") == 0) {
+ if (g_strcmp0(info->number, "02") == 0)
+ mdm = info->devnode;
+ } else if (g_strcmp0(info->subsystem, "net") == 0) {
+ if (g_strcmp0(info->number, "00") == 0)
+ net = info->devnode;
+ }
+ }
}
if (mdm == NULL || net == NULL)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] udev: enhance udev detection for intel 7xxx modems
2018-10-31 10:43 [PATCH] udev: enhance udev detection for intel 7xxx modems Nandini Rebello
@ 2018-10-31 19:51 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2018-10-31 19:51 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
Hi Nandini,
On 10/31/2018 05:43 AM, Nandini Rebello wrote:
> Handle newer 7xxx modem enumeration based on ProductId.
> Preserving the previous gen support too.
> ---
> plugins/udevng.c | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
I fixed up some style issues and use of spaces for indentation. Patch
has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-31 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-31 10:43 [PATCH] udev: enhance udev detection for intel 7xxx modems Nandini Rebello
2018-10-31 19:51 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.