[PATCH] oe-selftest: Build wic runtime requirements and images before testing

[PATCH] oe-selftest: Build wic runtime requirements and images before testing

[Ed Bartosh]

Some native tools (syslinux, parted, mtools, etc) are required
by wic to produce images. Unit tests fail if the tools are
not available.

Baked tools and image-core-minimal used by wic before running tests.

[YOCTO #7730]

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/lib/oeqa/selftest/wic.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
index c628b59..817685d 100644
--- a/meta/lib/oeqa/selftest/wic.py
+++ b/meta/lib/oeqa/selftest/wic.py
@@ -36,6 +36,12 @@ class Wic(oeSelfTest):
 
     resultdir = "/var/tmp/wic/build/"
 
+    @classmethod
+    def setUpClass(cls):
+        """Build wic runtime dependencies and images used in the tests."""
+        runCmd('bitbake syslinux syslinux-native parted-native '
+               'dosfstools-native mtools-native core-image-minimal')
+
     def setUp(self):
         """This code is executed before each test method."""
         rmtree(self.resultdir, ignore_errors=True)
-- 
2.1.4

[PATCH v2] oe-selftest: Build wic runtime requirements and images before testing

[Ed Bartosh]

Some native tools (syslinux, parted, mtools, etc) are required
by wic to produce images. Unit tests fail if the tools are
not available.

Baked tools and image-core-minimal used by wic before running tests.

[YOCTO #7730]

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/lib/oeqa/selftest/wic.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
index c628b59..a2ce2cb 100644
--- a/meta/lib/oeqa/selftest/wic.py
+++ b/meta/lib/oeqa/selftest/wic.py
@@ -29,13 +29,19 @@ from glob import glob
 from shutil import rmtree
 
 from oeqa.selftest.base import oeSelfTest
-from oeqa.utils.commands import runCmd
+from oeqa.utils.commands import runCmd, bitbake
 
 class Wic(oeSelfTest):
     """Wic test class."""
 
     resultdir = "/var/tmp/wic/build/"
 
+    @classmethod
+    def setUpClass(cls):
+        """Build wic runtime dependencies and images used in the tests."""
+        bitbake('syslinux syslinux-native parted-native '
+                'dosfstools-native mtools-native core-image-minimal')
+
     def setUp(self):
         """This code is executed before each test method."""
         rmtree(self.resultdir, ignore_errors=True)
-- 
2.1.4

Re: [PATCH] oe-selftest: Build wic runtime requirements and images before testing

[Paul Eggleton]

Hi Ed,

On Thursday 21 May 2015 11:07:58 Ed Bartosh wrote:
> Some native tools (syslinux, parted, mtools, etc) are required
> by wic to produce images. Unit tests fail if the tools are
> not available.
> 
> Baked tools and image-core-minimal used by wic before running tests.
> 
> [YOCTO #7730]
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  meta/lib/oeqa/selftest/wic.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
> index c628b59..817685d 100644
> --- a/meta/lib/oeqa/selftest/wic.py
> +++ b/meta/lib/oeqa/selftest/wic.py
> @@ -36,6 +36,12 @@ class Wic(oeSelfTest):
> 
>      resultdir = "/var/tmp/wic/build/"
> 
> +    @classmethod
> +    def setUpClass(cls):
> +        """Build wic runtime dependencies and images used in the tests."""
> +        runCmd('bitbake syslinux syslinux-native parted-native '
> +               'dosfstools-native mtools-native core-image-minimal')
> +
>      def setUp(self):
>          """This code is executed before each test method."""
>          rmtree(self.resultdir, ignore_errors=True)

FYI there is a bitbake() function in meta/lib/oeqa/utils/commands.py that I'd 
recomment using rather than runCmd() directly. Ultimately it ends up doing the 
same thing, but at least it keeps the details of how bitbake is invoked 
isolated from what your test needs to build.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre