* [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++
@ 2022-03-16 12:31 Helge Konetzka
2022-03-16 12:56 ` Marc-André Lureau
2022-03-16 12:58 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Helge Konetzka @ 2022-03-16 12:31 UTC (permalink / raw)
To: qemu-devel; +Cc: Konstantin Kostiuk, Michael Roth
Compiling with clang++ of msys2 toolchain clang64 leads to an error
on initializing 'char*' variable nul with a 'const char*' value
Signed-off-by: Helge Konetzka <hk@zapateado.de>
---
Compiling with clang++ of msys2 toolchain clang64 leads to
[1445/1747] Compiling C++ object qga/vss-win32/qga-vss.dll.p/install.cpp.obj
FAILED: qga/vss-win32/qga-vss.dll.p/install.cpp.obj
...
qga/vss-win32/install.cpp:49:24: error: cannot initialize a variable of
type 'char *' with an rvalue of type 'const char *'
char *msg = NULL, *nul = strchr(text, '(');
^ ~~~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
make: *** [Makefile:163: run-ninja] Error 1
==> ERROR: A failure occurred in build().
Aborting...
---
qga/vss-win32/install.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index 8076efe3cb..b57508fbe0 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -46,7 +46,8 @@ void errmsg(DWORD err, const char *text)
* If text doesn't contains '(', negative precision is given, which is
* treated as though it were missing.
*/
- char *msg = NULL, *nul = strchr(text, '(');
+ char *msg = NULL;
+ const char *nul = strchr(text, '(');
int len = nul ? nul - text : -1;
FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER |
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++
2022-03-16 12:31 [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++ Helge Konetzka
@ 2022-03-16 12:56 ` Marc-André Lureau
2022-03-16 12:58 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2022-03-16 12:56 UTC (permalink / raw)
To: Helge Konetzka; +Cc: Konstantin Kostiuk, QEMU, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Wed, Mar 16, 2022 at 4:41 PM Helge Konetzka <hk@zapateado.de> wrote:
> Compiling with clang++ of msys2 toolchain clang64 leads to an error
> on initializing 'char*' variable nul with a 'const char*' value
>
> Signed-off-by: Helge Konetzka <hk@zapateado.de>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> Compiling with clang++ of msys2 toolchain clang64 leads to
>
> [1445/1747] Compiling C++ object
> qga/vss-win32/qga-vss.dll.p/install.cpp.obj
> FAILED: qga/vss-win32/qga-vss.dll.p/install.cpp.obj
> ...
> qga/vss-win32/install.cpp:49:24: error: cannot initialize a variable of
> type 'char *' with an rvalue of type 'const char *'
> char *msg = NULL, *nul = strchr(text, '(');
> ^ ~~~~~~~~~~~~~~~~~
> 1 error generated.
> ninja: build stopped: subcommand failed.
> make: *** [Makefile:163: run-ninja] Error 1
> ==> ERROR: A failure occurred in build().
> Aborting...
> ---
> qga/vss-win32/install.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index 8076efe3cb..b57508fbe0 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -46,7 +46,8 @@ void errmsg(DWORD err, const char *text)
> * If text doesn't contains '(', negative precision is given, which
> is
> * treated as though it were missing.
> */
> - char *msg = NULL, *nul = strchr(text, '(');
> + char *msg = NULL;
> + const char *nul = strchr(text, '(');
> int len = nul ? nul - text : -1;
>
> FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER |
> --
> 2.30.2
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2574 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++
2022-03-16 12:31 [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++ Helge Konetzka
2022-03-16 12:56 ` Marc-André Lureau
@ 2022-03-16 12:58 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-16 12:58 UTC (permalink / raw)
To: Helge Konetzka, qemu-devel; +Cc: Konstantin Kostiuk, Michael Roth
On 16/3/22 13:31, Helge Konetzka wrote:
> Compiling with clang++ of msys2 toolchain clang64 leads to an error
> on initializing 'char*' variable nul with a 'const char*' value
Can you include the error message in the description? I.e.:
'''
This fixes:
qga/vss-win32/install.cpp:49:24: error: cannot initialize a variable of
type 'char *' with an rvalue of type 'const char *'
char *msg = NULL, *nul = strchr(text, '(');
^ ~~~~~~~~~~~~~~~~~
'''
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Helge Konetzka <hk@zapateado.de>
> ---
> Compiling with clang++ of msys2 toolchain clang64 leads to
>
> [1445/1747] Compiling C++ object
> qga/vss-win32/qga-vss.dll.p/install.cpp.obj
> FAILED: qga/vss-win32/qga-vss.dll.p/install.cpp.obj
> ...
> qga/vss-win32/install.cpp:49:24: error: cannot initialize a variable of
> type 'char *' with an rvalue of type 'const char *'
> char *msg = NULL, *nul = strchr(text, '(');
> ^ ~~~~~~~~~~~~~~~~~
> 1 error generated.
> ninja: build stopped: subcommand failed.
> make: *** [Makefile:163: run-ninja] Error 1
> ==> ERROR: A failure occurred in build().
> Aborting...
> ---
> qga/vss-win32/install.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index 8076efe3cb..b57508fbe0 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -46,7 +46,8 @@ void errmsg(DWORD err, const char *text)
> * If text doesn't contains '(', negative precision is given,
> which is
> * treated as though it were missing.
> */
> - char *msg = NULL, *nul = strchr(text, '(');
> + char *msg = NULL;
> + const char *nul = strchr(text, '(');
> int len = nul ? nul - text : -1;
>
> FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-16 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 12:31 [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++ Helge Konetzka
2022-03-16 12:56 ` Marc-André Lureau
2022-03-16 12:58 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.