From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
<architt@codeaurora.org>, <a.hajda@samsung.com>,
<Laurent.pinchart@ideasonboard.com>, <airlied@linux.ie>,
<horms@verge.net.au>, <magnus.damm@gmail.com>,
<geert@linux-m68k.org>, <niklas.soderlund@ragnatech.se>,
<sergei.shtylyov@cogentembedded.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>
Cc: <dri-devel@lists.freedesktop.org>,
<linux-renesas-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver
Date: Thu, 19 Apr 2018 14:18:30 +0300 [thread overview]
Message-ID: <241462f3-0396-c763-6fb4-aff8fc5d29bd@mentor.com> (raw)
In-Reply-To: <1523357590-3841-3-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo,
On 04/10/2018 01:53 PM, Jacopo Mondi wrote:
> Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel
> output converter.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Generally I have only one pretty ignorable comment.
> +
> +enum thc63_ports {
> + THC63_LVDS_IN0,
> + THC63_LVDS_IN1,
> + THC63_RGB_OUT0,
> + THC63_RGB_OUT1,
> +};
> +
The driver uses only THC63_RGB_OUT0 value, or port@2, and MODE{0,1,2} IC
configuration is ignored.
I don't know if right from the beginning it would be better to support
dual-out modes, preferably both single-in and dual-in ones. Will it
impact port enumeration?
I do understand that the extension is possible, and likely only hardware
accessibility postpones it.
--
With best wishes,
Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
architt@codeaurora.org, a.hajda@samsung.com,
Laurent.pinchart@ideasonboard.com, airlied@linux.ie,
horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org,
niklas.soderlund@ragnatech.se,
sergei.shtylyov@cogentembedded.com, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver
Date: Thu, 19 Apr 2018 14:18:30 +0300 [thread overview]
Message-ID: <241462f3-0396-c763-6fb4-aff8fc5d29bd@mentor.com> (raw)
In-Reply-To: <1523357590-3841-3-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo,
On 04/10/2018 01:53 PM, Jacopo Mondi wrote:
> Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel
> output converter.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Generally I have only one pretty ignorable comment.
> +
> +enum thc63_ports {
> + THC63_LVDS_IN0,
> + THC63_LVDS_IN1,
> + THC63_RGB_OUT0,
> + THC63_RGB_OUT1,
> +};
> +
The driver uses only THC63_RGB_OUT0 value, or port@2, and MODE{0,1,2} IC
configuration is ignored.
I don't know if right from the beginning it would be better to support
dual-out modes, preferably both single-in and dual-in ones. Will it
impact port enumeration?
I do understand that the extension is possible, and likely only hardware
accessibility postpones it.
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2018-04-19 11:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 10:53 [PATCH v8 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge Jacopo Mondi
2018-04-10 10:53 ` [PATCH v8 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Jacopo Mondi
2018-04-13 21:12 ` Rob Herring
2018-04-13 21:12 ` Rob Herring
2018-04-19 9:44 ` Vladimir Zapolskiy
2018-04-19 9:44 ` Vladimir Zapolskiy
2018-04-19 9:48 ` Vladimir Zapolskiy
2018-04-19 9:48 ` Vladimir Zapolskiy
2018-04-19 10:10 ` Vladimir Zapolskiy
2018-04-19 10:10 ` Vladimir Zapolskiy
2018-04-19 10:32 ` jacopo mondi
2018-04-19 10:32 ` jacopo mondi
2018-04-10 10:53 ` [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver Jacopo Mondi
2018-04-13 16:28 ` jacopo mondi
2018-04-13 16:28 ` jacopo mondi
2018-04-19 11:18 ` Vladimir Zapolskiy [this message]
2018-04-19 11:18 ` Vladimir Zapolskiy
2018-04-19 12:33 ` jacopo mondi
2018-04-19 12:33 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=241462f3-0396-c763-6fb4-aff8fc5d29bd@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.