* [PATCH] Make pci_set_power_state() check register version
@ 2004-12-17 16:58 David Howells
2004-12-17 21:45 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2004-12-17 16:58 UTC (permalink / raw)
To: akpm, greg; +Cc: linux-kernel
The attached patch makes pci_set_power_state() check the PM register version
and ignore non-version 2 registers. Trampling on earlier version PM registers
such as are sported by the Promise 20269 IDE card can cause the system to
hang.
Signed-Off-By: David Howells <dhowells@redhat.com>
---
warthog>diffstat pci-pm-2610rc3mm1.diff
pci.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff -uNrp linux-2.6.10-rc3-mm1-asmoffsets/drivers/pci/pci.c linux-2.6.10-rc3-mm1-debug/drivers/pci/pci.c
--- linux-2.6.10-rc3-mm1-asmoffsets/drivers/pci/pci.c 2004-12-13 14:29:51.000000000 +0000
+++ linux-2.6.10-rc3-mm1-debug/drivers/pci/pci.c 2004-12-17 16:50:09.637295082 +0000
@@ -245,7 +245,7 @@ int
pci_set_power_state(struct pci_dev *dev, int state)
{
int pm;
- u16 pmcsr;
+ u16 pmcsr, pmc;
/* bound the state we're entering */
if (state > 3) state = 3;
@@ -265,10 +265,16 @@ pci_set_power_state(struct pci_dev *dev,
/* abort if the device doesn't support PM capabilities */
if (!pm) return -EIO;
+ pci_read_config_word(dev,pm + PCI_PM_PMC,&pmc);
+ if ((pmc & PCI_PM_CAP_VER_MASK) != 2) {
+ printk(KERN_WARNING
+ "PCI: %s has unsupported PM cap regs version (%u)\n",
+ dev->slot_name, pmc & PCI_PM_CAP_VER_MASK);
+ return -EIO;
+ }
+
/* check if this device supports the desired state */
if (state == 1 || state == 2) {
- u16 pmc;
- pci_read_config_word(dev,pm + PCI_PM_PMC,&pmc);
if (state == 1 && !(pmc & PCI_PM_CAP_D1)) return -EIO;
else if (state == 2 && !(pmc & PCI_PM_CAP_D2)) return -EIO;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Make pci_set_power_state() check register version
2004-12-17 16:58 [PATCH] Make pci_set_power_state() check register version David Howells
@ 2004-12-17 21:45 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2004-12-17 21:45 UTC (permalink / raw)
To: David Howells; +Cc: akpm, linux-kernel
On Fri, Dec 17, 2004 at 04:58:52PM +0000, David Howells wrote:
>
> The attached patch makes pci_set_power_state() check the PM register version
> and ignore non-version 2 registers. Trampling on earlier version PM registers
> such as are sported by the Promise 20269 IDE card can cause the system to
> hang.
>
> Signed-Off-By: David Howells <dhowells@redhat.com>
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-12-17 21:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-17 16:58 [PATCH] Make pci_set_power_state() check register version David Howells
2004-12-17 21:45 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.