Re: [PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting

Re: [PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Wednesday, 26 January 2022 15:04:23 CET Diederik de Haas wrote:
> Therefor remove the 'at_console_ setting block.

Grr, the last underscore should've been a single quote.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Hi Diederik,

On 1/26/22 13:14, Diederik de Haas wrote:
> On Wednesday, 26 January 2022 15:12:38 CET Diederik de Haas wrote:
>> On Wednesday, 26 January 2022 15:04:23 CET Diederik de Haas wrote:
>>> Therefor remove the 'at_console_ setting block.
>>
>> Grr, the last underscore should've been a single quote.
> 
> And the title/subject is also suboptimal, maybe this?
> dbus: Remove 'at_console' and add 'netdev' policy settings
> 
> Should I submit a v2 patch for that or can/will that be corrected when
> committing the patch?

I haven't looked yet, so feel free to just submit a v2.

Regards,
-Denis

Re: [PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Wednesday, 26 January 2022 15:12:38 CET Diederik de Haas wrote:
> On Wednesday, 26 January 2022 15:04:23 CET Diederik de Haas wrote:
> > Therefor remove the 'at_console_ setting block.
> 
> Grr, the last underscore should've been a single quote.

And the title/subject is also suboptimal, maybe this?
dbus: Remove 'at_console' and add 'netdev' policy settings

Should I submit a v2 patch for that or can/will that be corrected when 
committing the patch?

Cheers,
  Diederik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting

[Diederik de Haas]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

The 'at_console' D-Bus policy setting has been deprecated for more then
10 years and could be ignored at any time in the future. Moreover, while the
intend was to allow locally logged on users to interact with iwd, it didn't
actually do that. https://www.spinics.net/lists/linux-bluetooth/msg75267.html
and https://gitlab.freedesktop.org/dbus/dbus/-/issues/52 contain more
details. Therefor remove the 'at_console_ setting block.

On Debian (based) systems, there is a standard defined group which is
allowed to manage network interfaces, and that is the 'netdev' group.
So add a D-Bus setting block to grant the 'netdev' group that access.
---
 src/iwd-dbus.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/iwd-dbus.conf b/src/iwd-dbus.conf
index 6b07ba9e..257b0b14 100644
--- a/src/iwd-dbus.conf
+++ b/src/iwd-dbus.conf
@@ -18,7 +18,7 @@
     <allow send_interface="net.connman.iwd.Agent"/>
   </policy>
 
-  <policy at_console="true">
+  <policy group="netdev">
     <allow send_destination="net.connman.iwd"/>
     <allow send_interface="net.connman.iwd.Agent"/>
   </policy>
-- 
2.34.1