* [PATCH] cpufreq: ondemand: Set MIN_FREQUENCY_UP_THRESHOLD to 1
@ 2016-01-04 4:14 Chen Yu
2016-01-04 5:56 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Chen Yu @ 2016-01-04 4:14 UTC (permalink / raw)
To: linux-pm; +Cc: rjw, viresh.kumar, linux-kernel, sworddragon2, Chen Yu
Currently the minimal up_threshold is 11, and user may want to
use a smaller minimal up_threshold for performance tuning,
so MIN_FREQUENCY_UP_THRESHOLD could be set to 1 because:
1. Current systems wouldn't be affected as they have already
a value >= 11.
2. New systems with a default kernel would keep still the default
value that is >= 11.
Users now have the advantage that they can make their own decisions
and customize the 'trip point' to switch to the max frequency.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=65501
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
drivers/cpufreq/cpufreq_ondemand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 03ac6ce..2a093b5 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -24,7 +24,7 @@
#define MAX_SAMPLING_DOWN_FACTOR (100000)
#define MICRO_FREQUENCY_UP_THRESHOLD (95)
#define MICRO_FREQUENCY_MIN_SAMPLE_RATE (10000)
-#define MIN_FREQUENCY_UP_THRESHOLD (11)
+#define MIN_FREQUENCY_UP_THRESHOLD (1)
#define MAX_FREQUENCY_UP_THRESHOLD (100)
static DEFINE_PER_CPU(struct od_cpu_dbs_info_s, od_cpu_dbs_info);
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: ondemand: Set MIN_FREQUENCY_UP_THRESHOLD to 1
2016-01-04 4:14 [PATCH] cpufreq: ondemand: Set MIN_FREQUENCY_UP_THRESHOLD to 1 Chen Yu
@ 2016-01-04 5:56 ` Viresh Kumar
2016-01-05 13:02 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2016-01-04 5:56 UTC (permalink / raw)
To: Chen Yu; +Cc: linux-pm, rjw, linux-kernel, sworddragon2
On 04-01-16, 12:14, Chen Yu wrote:
> Currently the minimal up_threshold is 11, and user may want to
> use a smaller minimal up_threshold for performance tuning,
> so MIN_FREQUENCY_UP_THRESHOLD could be set to 1 because:
>
> 1. Current systems wouldn't be affected as they have already
> a value >= 11.
> 2. New systems with a default kernel would keep still the default
> value that is >= 11.
>
> Users now have the advantage that they can make their own decisions
> and customize the 'trip point' to switch to the max frequency.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=65501
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
> drivers/cpufreq/cpufreq_ondemand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index 03ac6ce..2a093b5 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -24,7 +24,7 @@
> #define MAX_SAMPLING_DOWN_FACTOR (100000)
> #define MICRO_FREQUENCY_UP_THRESHOLD (95)
> #define MICRO_FREQUENCY_MIN_SAMPLE_RATE (10000)
> -#define MIN_FREQUENCY_UP_THRESHOLD (11)
> +#define MIN_FREQUENCY_UP_THRESHOLD (1)
> #define MAX_FREQUENCY_UP_THRESHOLD (100)
>
> static DEFINE_PER_CPU(struct od_cpu_dbs_info_s, od_cpu_dbs_info);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: ondemand: Set MIN_FREQUENCY_UP_THRESHOLD to 1
2016-01-04 5:56 ` Viresh Kumar
@ 2016-01-05 13:02 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-01-05 13:02 UTC (permalink / raw)
To: Viresh Kumar, Chen Yu; +Cc: linux-pm, linux-kernel, sworddragon2
On Monday, January 04, 2016 11:26:51 AM Viresh Kumar wrote:
> On 04-01-16, 12:14, Chen Yu wrote:
> > Currently the minimal up_threshold is 11, and user may want to
> > use a smaller minimal up_threshold for performance tuning,
> > so MIN_FREQUENCY_UP_THRESHOLD could be set to 1 because:
> >
> > 1. Current systems wouldn't be affected as they have already
> > a value >= 11.
> > 2. New systems with a default kernel would keep still the default
> > value that is >= 11.
> >
> > Users now have the advantage that they can make their own decisions
> > and customize the 'trip point' to switch to the max frequency.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=65501
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > ---
> > drivers/cpufreq/cpufreq_ondemand.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> > index 03ac6ce..2a093b5 100644
> > --- a/drivers/cpufreq/cpufreq_ondemand.c
> > +++ b/drivers/cpufreq/cpufreq_ondemand.c
> > @@ -24,7 +24,7 @@
> > #define MAX_SAMPLING_DOWN_FACTOR (100000)
> > #define MICRO_FREQUENCY_UP_THRESHOLD (95)
> > #define MICRO_FREQUENCY_MIN_SAMPLE_RATE (10000)
> > -#define MIN_FREQUENCY_UP_THRESHOLD (11)
> > +#define MIN_FREQUENCY_UP_THRESHOLD (1)
> > #define MAX_FREQUENCY_UP_THRESHOLD (100)
> >
> > static DEFINE_PER_CPU(struct od_cpu_dbs_info_s, od_cpu_dbs_info);
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-05 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-04 4:14 [PATCH] cpufreq: ondemand: Set MIN_FREQUENCY_UP_THRESHOLD to 1 Chen Yu
2016-01-04 5:56 ` Viresh Kumar
2016-01-05 13:02 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.