Question about FRU read/write function

Question about FRU read/write function

[Ivan Li11]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi Team,

I found the output FRU raw data via FRU read command doesn't totally match with input FRU raw data via FRU write command.
FRU write command:
https://github.com/openbmc/ipmi-fru-parser/blob/master/strgfnhandler.cpp#L20
FRU read command:
https://github.com/openbmc/phosphor-host-ipmid/blob/master/storagehandler.cpp#L659

Have you encountered this situation ?
If yes, please help to share your comment about it.

Thanks,
Ivan

[-- Attachment #2: Type: text/html, Size: 3288 bytes --]

re: Question about FRU read/write function

[Joseph Reynolds]

Ivan Li11 rli11 at lenovo.com 
<mailto:openbmc%40lists.ozlabs.org?Subject=Re%3A%20Question%20about%20FRU%20read/write%20function&In-Reply-To=%3C24239ac0c21341d9af32893d5c6beb76%40lenovo.com%3E>
Mon Aug 26 03:00:33 AEST 2019/

/> Hi Team,
 >
 > I found the output FRU raw data via FRU read command doesn't totally 
match with input FRU raw data via FRU write command.
 > FRU write command:
 > 
https://github.com/openbmc/ipmi-fru-parser/blob/master/strgfnhandler.cpp#L20 

 > FRU read command:
 > 
https://github.com/openbmc/phosphor-host-ipmid/blob/master/storagehandler.cpp#L659 

 >
 > Have you encountered this situation ?
 > If yes, please help to share your comment about it.

There are some FRU test cases here:
https://github.com/openbmc/openbmc-test-automation/blob/master/tests/ipmi/test_fru.robot
https://github.com/openbmc/openbmc-test-automation/blob/master/tests/test_inventory.robot#L186
https://github.com/openbmc/openbmc-test-automation/blob/master/data/ipmi_raw_cmd_table.py

Can you write a test to reproduce the problem?

- Joseph

 > Thanks,
 > Ivan