* [xen-unstable test] 153602: regressions - FAIL
@ 2020-09-03 10:24 osstest service owner
2020-09-03 14:02 ` Jan Beulich
0 siblings, 1 reply; 15+ messages in thread
From: osstest service owner @ 2020-09-03 10:24 UTC (permalink / raw)
To: xen-devel, osstest-admin
flight 153602 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/153602/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
Tests which are failing intermittently (not blocking):
test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 10 debian-hvm-install fail in 153591 pass in 153602
test-armhf-armhf-xl-credit1 7 xen-boot fail pass in 153591
Tests which did not succeed, but are not blocking:
test-armhf-armhf-xl-credit1 13 migrate-support-check fail in 153591 never pass
test-armhf-armhf-xl-credit1 14 saverestore-support-check fail in 153591 never pass
test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail like 152849
test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 152877
test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 152877
test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 152877
test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 152877
test-armhf-armhf-libvirt 14 saverestore-support-check fail like 152877
test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 152877
test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 152877
test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 152877
test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 152877
test-amd64-i386-xl-pvshim 12 guest-start fail never pass
test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass
test-amd64-amd64-libvirt 13 migrate-support-check fail never pass
test-amd64-i386-libvirt 13 migrate-support-check fail never pass
test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass
test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass
test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass
test-arm64-arm64-xl 13 migrate-support-check fail never pass
test-arm64-arm64-xl 14 saverestore-support-check fail never pass
test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass
test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass
test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass
test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass
test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass
test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass
test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass
test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass
test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass
test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass
test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass
test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass
test-armhf-armhf-xl 13 migrate-support-check fail never pass
test-armhf-armhf-xl 14 saverestore-support-check fail never pass
test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass
test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass
test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass
test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass
test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass
test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass
test-armhf-armhf-libvirt 13 migrate-support-check fail never pass
test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass
test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass
test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass
test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass
test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass
test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass
test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass
test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass
version targeted for testing:
xen afe018e041ec112d90a8b4e6ed607d22aa06f280
baseline version:
xen 7a8d8bde9820387c3e168182b99fd9761c223fff
Last test of basis 152877 2020-08-27 01:51:40 Z 7 days
Failing since 152896 2020-08-27 13:07:51 Z 6 days 21 attempts
Testing same since 153400 2020-08-31 18:07:29 Z 2 days 8 attempts
------------------------------------------------------------
People who touched revisions under test:
Andrew Cooper <andrew.cooper3@citrix.com>
Costin Lupu <costin.lupu@cs.pub.ro>
Hubert Jasudowicz <hubert.jasudowicz@cert.pl>
Ian Jackson <ian.jackson@eu.citrix.com>
Ian Jackson <iwj@xenproject.org>
Jan Beulich <jbeulich@suse.com>
Juergen Gross <jgross@suse.com>
Julien Grall <jgrall@amazon.com>
Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Paul Durrant <pdurrant@amazon.com>
Roger Pau Monné <roger.pau@citrix.com>
Wei Liu <wl@xen.org>
jobs:
build-amd64-xsm pass
build-arm64-xsm pass
build-i386-xsm pass
build-amd64-xtf pass
build-amd64 pass
build-arm64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt pass
build-arm64-libvirt pass
build-armhf-libvirt pass
build-i386-libvirt pass
build-amd64-prev pass
build-i386-prev pass
build-amd64-pvops pass
build-arm64-pvops pass
build-armhf-pvops pass
build-i386-pvops pass
test-xtf-amd64-amd64-1 pass
test-xtf-amd64-amd64-2 pass
test-xtf-amd64-amd64-3 pass
test-xtf-amd64-amd64-4 pass
test-xtf-amd64-amd64-5 pass
test-amd64-amd64-xl pass
test-amd64-coresched-amd64-xl pass
test-arm64-arm64-xl pass
test-armhf-armhf-xl pass
test-amd64-i386-xl pass
test-amd64-coresched-i386-xl pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail
test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass
test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass
test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass
test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass
test-amd64-amd64-libvirt-xsm pass
test-arm64-arm64-libvirt-xsm pass
test-amd64-i386-libvirt-xsm pass
test-amd64-amd64-xl-xsm pass
test-arm64-arm64-xl-xsm pass
test-amd64-i386-xl-xsm pass
test-amd64-amd64-qemuu-nested-amd fail
test-amd64-amd64-xl-pvhv2-amd pass
test-amd64-i386-qemut-rhel6hvm-amd pass
test-amd64-i386-qemuu-rhel6hvm-amd pass
test-amd64-amd64-dom0pvh-xl-amd pass
test-amd64-amd64-xl-qemut-debianhvm-amd64 pass
test-amd64-i386-xl-qemut-debianhvm-amd64 pass
test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass
test-amd64-i386-xl-qemuu-debianhvm-amd64 pass
test-amd64-i386-freebsd10-amd64 pass
test-amd64-amd64-qemuu-freebsd11-amd64 pass
test-amd64-amd64-qemuu-freebsd12-amd64 pass
test-amd64-amd64-xl-qemuu-ovmf-amd64 pass
test-amd64-i386-xl-qemuu-ovmf-amd64 pass
test-amd64-amd64-xl-qemut-win7-amd64 fail
test-amd64-i386-xl-qemut-win7-amd64 fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-i386-xl-qemuu-win7-amd64 fail
test-amd64-amd64-xl-qemut-ws16-amd64 fail
test-amd64-i386-xl-qemut-ws16-amd64 fail
test-amd64-amd64-xl-qemuu-ws16-amd64 fail
test-amd64-i386-xl-qemuu-ws16-amd64 fail
test-armhf-armhf-xl-arndale pass
test-amd64-amd64-xl-credit1 pass
test-arm64-arm64-xl-credit1 pass
test-armhf-armhf-xl-credit1 fail
test-amd64-amd64-xl-credit2 pass
test-arm64-arm64-xl-credit2 pass
test-armhf-armhf-xl-credit2 pass
test-armhf-armhf-xl-cubietruck pass
test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass
test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass
test-amd64-amd64-examine pass
test-arm64-arm64-examine pass
test-armhf-armhf-examine pass
test-amd64-i386-examine pass
test-amd64-i386-freebsd10-i386 pass
test-amd64-amd64-qemuu-nested-intel pass
test-amd64-amd64-xl-pvhv2-intel pass
test-amd64-i386-qemut-rhel6hvm-intel pass
test-amd64-i386-qemuu-rhel6hvm-intel pass
test-amd64-amd64-dom0pvh-xl-intel pass
test-amd64-amd64-libvirt pass
test-armhf-armhf-libvirt pass
test-amd64-i386-libvirt pass
test-amd64-amd64-livepatch pass
test-amd64-i386-livepatch pass
test-amd64-amd64-migrupgrade pass
test-amd64-i386-migrupgrade pass
test-amd64-amd64-xl-multivcpu pass
test-armhf-armhf-xl-multivcpu pass
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-amd64-amd64-libvirt-pair pass
test-amd64-i386-libvirt-pair pass
test-amd64-amd64-amd64-pvgrub pass
test-amd64-amd64-i386-pvgrub pass
test-amd64-amd64-xl-pvshim pass
test-amd64-i386-xl-pvshim fail
test-amd64-amd64-pygrub pass
test-amd64-amd64-xl-qcow2 pass
test-armhf-armhf-libvirt-raw pass
test-amd64-i386-xl-raw pass
test-amd64-amd64-xl-rtds pass
test-armhf-armhf-xl-rtds fail
test-arm64-arm64-xl-seattle pass
test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass
test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass
test-amd64-amd64-xl-shadow pass
test-amd64-i386-xl-shadow pass
test-arm64-arm64-xl-thunderx pass
test-amd64-amd64-libvirt-vhd pass
test-armhf-armhf-xl-vhd pass
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 581 lines long.)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL
2020-09-03 10:24 [xen-unstable test] 153602: regressions - FAIL osstest service owner
@ 2020-09-03 14:02 ` Jan Beulich
2020-09-03 16:17 ` Ian Jackson
0 siblings, 1 reply; 15+ messages in thread
From: Jan Beulich @ 2020-09-03 14:02 UTC (permalink / raw)
To: Costin Lupu; +Cc: osstest service owner, xen-devel, Wei Liu
On 03.09.2020 12:24, osstest service owner wrote:
> flight 153602 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/153602/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
While at least the hypervisor logs don't provide clear indication
(and I don't know where else to look among the files osstest
provides) I can't help thinking that stubdom apparently
crashing is still fallout from the mini-os changes (and no-one
really looks to care). In particular I think that this
@@ -374,6 +376,10 @@ out:
}
if (ip)
*ip = strdup(ldev->ip);
+ if (mask)
+ *mask = strdup(ldev->mask);
+ if (gw)
+ *gw = strdup(ldev->gw);
was insufficient, as it doesn't guard against ldev->mask and/or
ldev->gw being NULL, despite that being the result (afaict) when
only an IP address is found in the parsed string. Please can you
urgently look into the failures, even if it isn't 100% certain
that your change is the culprit?
Jan
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL
2020-09-03 14:02 ` Jan Beulich
@ 2020-09-03 16:17 ` Ian Jackson
2020-09-03 16:29 ` Costin Lupu
2020-09-04 6:32 ` Jan Beulich
0 siblings, 2 replies; 15+ messages in thread
From: Ian Jackson @ 2020-09-03 16:17 UTC (permalink / raw)
To: Jan Beulich; +Cc: Costin Lupu, xen-devel, Wei Liu
Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
> On 03.09.2020 12:24, osstest service owner wrote:
> > flight 153602 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/153602/
> >
> > Regressions :-(
> >
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
> > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>
> While at least the hypervisor logs don't provide clear indication
> (and I don't know where else to look among the files osstest
> provides) I can't help thinking that stubdom apparently
> crashing is still fallout from the mini-os changes (and no-one
> really looks to care). In particular I think that this
I haven't looked at this in detail but I notice that I am having
build failures.
Prior to e013e8514389 "config: use mini-os master for unstable", the
version of mini-os used for builds was controlled by xen.git's
Config.mk.
Since then it has been mini-os master. NB there is no push gate for
mini-os. IIRC we discussed this at the time and it was thought that
breakage due to mini-os would be unlikely.
To unblock development in xen.git I suggest reverting the minios part
of 165f3afbfc3d "Config.mk: Unnail versions (for unstable branch)",
choosing some known-working version of minios to put in Config.mk.
Perhaps there should indeed be a minios pushgate. Then osstest would
use the tested version.
Ian.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL
2020-09-03 16:17 ` Ian Jackson
@ 2020-09-03 16:29 ` Costin Lupu
2020-09-04 6:32 ` Jan Beulich
1 sibling, 0 replies; 15+ messages in thread
From: Costin Lupu @ 2020-09-03 16:29 UTC (permalink / raw)
To: Ian Jackson, Jan Beulich; +Cc: xen-devel, Wei Liu
On 9/3/20 7:17 PM, Ian Jackson wrote:
> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
>> On 03.09.2020 12:24, osstest service owner wrote:
>>> flight 153602 xen-unstable real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/153602/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>
>> While at least the hypervisor logs don't provide clear indication
>> (and I don't know where else to look among the files osstest
>> provides) I can't help thinking that stubdom apparently
>> crashing is still fallout from the mini-os changes (and no-one
>> really looks to care). In particular I think that this
>
> I haven't looked at this in detail but I notice that I am having
> build failures.
>
> Prior to e013e8514389 "config: use mini-os master for unstable", the
> version of mini-os used for builds was controlled by xen.git's
> Config.mk.
>
> Since then it has been mini-os master. NB there is no push gate for
> mini-os. IIRC we discussed this at the time and it was thought that
> breakage due to mini-os would be unlikely.
>
> To unblock development in xen.git I suggest reverting the minios part
> of 165f3afbfc3d "Config.mk: Unnail versions (for unstable branch)",
> choosing some known-working version of minios to put in Config.mk.
>
> Perhaps there should indeed be a minios pushgate. Then osstest would
> use the tested version.
Sorry for breaking this, guys. I've just sent the fix for mini-os on the
mailing list.
Cheers,
Costin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL
2020-09-03 16:17 ` Ian Jackson
2020-09-03 16:29 ` Costin Lupu
@ 2020-09-04 6:32 ` Jan Beulich
2020-09-04 6:38 ` Jürgen Groß
1 sibling, 1 reply; 15+ messages in thread
From: Jan Beulich @ 2020-09-04 6:32 UTC (permalink / raw)
To: Ian Jackson; +Cc: Costin Lupu, xen-devel, Wei Liu, Juergen Gross
On 03.09.2020 18:17, Ian Jackson wrote:
> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
>> On 03.09.2020 12:24, osstest service owner wrote:
>>> flight 153602 xen-unstable real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/153602/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>
>> While at least the hypervisor logs don't provide clear indication
>> (and I don't know where else to look among the files osstest
>> provides) I can't help thinking that stubdom apparently
>> crashing is still fallout from the mini-os changes (and no-one
>> really looks to care). In particular I think that this
>
> I haven't looked at this in detail but I notice that I am having
> build failures.
>
> Prior to e013e8514389 "config: use mini-os master for unstable", the
> version of mini-os used for builds was controlled by xen.git's
> Config.mk.
>
> Since then it has been mini-os master. NB there is no push gate for
> mini-os. IIRC we discussed this at the time and it was thought that
> breakage due to mini-os would be unlikely.
>
> To unblock development in xen.git I suggest reverting the minios part
> of 165f3afbfc3d "Config.mk: Unnail versions (for unstable branch)",
> choosing some known-working version of minios to put in Config.mk.
Afaict this would still not work, due to 8d990807ec2c ("stubdom/grub:
update init_netfront() call for mini-os"). The dependencies between
the two trees aren't helpful at all in a case like this one.
> Perhaps there should indeed be a minios pushgate. Then osstest would
> use the tested version.
I did suggest this in a reply to an earlier test failure report, but
as per above I don't see how this would work either in a case like
this one.
Jan
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL
2020-09-04 6:32 ` Jan Beulich
@ 2020-09-04 6:38 ` Jürgen Groß
2020-09-04 6:52 ` Jan Beulich
2020-09-04 16:50 ` [xen-unstable test] 153602: regressions - FAIL [and 1 more messages] Ian Jackson
0 siblings, 2 replies; 15+ messages in thread
From: Jürgen Groß @ 2020-09-04 6:38 UTC (permalink / raw)
To: Jan Beulich, Ian Jackson; +Cc: Costin Lupu, xen-devel, Wei Liu
On 04.09.20 08:32, Jan Beulich wrote:
> On 03.09.2020 18:17, Ian Jackson wrote:
>> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
>>> On 03.09.2020 12:24, osstest service owner wrote:
>>>> flight 153602 xen-unstable real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/153602/
>>>>
>>>> Regressions :-(
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>>> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>>
>>> While at least the hypervisor logs don't provide clear indication
>>> (and I don't know where else to look among the files osstest
>>> provides) I can't help thinking that stubdom apparently
>>> crashing is still fallout from the mini-os changes (and no-one
>>> really looks to care). In particular I think that this
>>
>> I haven't looked at this in detail but I notice that I am having
>> build failures.
>>
>> Prior to e013e8514389 "config: use mini-os master for unstable", the
>> version of mini-os used for builds was controlled by xen.git's
>> Config.mk.
>>
>> Since then it has been mini-os master. NB there is no push gate for
>> mini-os. IIRC we discussed this at the time and it was thought that
>> breakage due to mini-os would be unlikely.
>>
>> To unblock development in xen.git I suggest reverting the minios part
>> of 165f3afbfc3d "Config.mk: Unnail versions (for unstable branch)",
>> choosing some known-working version of minios to put in Config.mk.
>
> Afaict this would still not work, due to 8d990807ec2c ("stubdom/grub:
> update init_netfront() call for mini-os"). The dependencies between
> the two trees aren't helpful at all in a case like this one.
This is clearly a problem of the mini-os private interfaces used by
stubdom/grub. The clean solution here would be either to add a stable
ABI to mini-os usable by stubdom/grub (and probably others in similar
cases) in order to avoid such issues, or to have feature defines like
for libxl in order to be able to specify to use the old interfaces of
mini-os by stubdoms (which could be removed after all users having been
switched to the new interfaces).
Juergen
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL
2020-09-04 6:38 ` Jürgen Groß
@ 2020-09-04 6:52 ` Jan Beulich
2020-09-04 16:00 ` [PATCH] minios: Revert recent change and revert to working minios Ian Jackson
2020-09-04 16:50 ` [xen-unstable test] 153602: regressions - FAIL [and 1 more messages] Ian Jackson
1 sibling, 1 reply; 15+ messages in thread
From: Jan Beulich @ 2020-09-04 6:52 UTC (permalink / raw)
To: Jürgen Groß, Ian Jackson; +Cc: Costin Lupu, xen-devel, Wei Liu
On 04.09.2020 08:38, Jürgen Groß wrote:
> On 04.09.20 08:32, Jan Beulich wrote:
>> On 03.09.2020 18:17, Ian Jackson wrote:
>>> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
>>>> On 03.09.2020 12:24, osstest service owner wrote:
>>>>> flight 153602 xen-unstable real [real]
>>>>> http://logs.test-lab.xenproject.org/osstest/logs/153602/
>>>>>
>>>>> Regressions :-(
>>>>>
>>>>> Tests which did not succeed and are blocking,
>>>>> including tests which could not be run:
>>>>> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>>>> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877
>>>>
>>>> While at least the hypervisor logs don't provide clear indication
>>>> (and I don't know where else to look among the files osstest
>>>> provides) I can't help thinking that stubdom apparently
>>>> crashing is still fallout from the mini-os changes (and no-one
>>>> really looks to care). In particular I think that this
>>>
>>> I haven't looked at this in detail but I notice that I am having
>>> build failures.
>>>
>>> Prior to e013e8514389 "config: use mini-os master for unstable", the
>>> version of mini-os used for builds was controlled by xen.git's
>>> Config.mk.
>>>
>>> Since then it has been mini-os master. NB there is no push gate for
>>> mini-os. IIRC we discussed this at the time and it was thought that
>>> breakage due to mini-os would be unlikely.
>>>
>>> To unblock development in xen.git I suggest reverting the minios part
>>> of 165f3afbfc3d "Config.mk: Unnail versions (for unstable branch)",
>>> choosing some known-working version of minios to put in Config.mk.
>>
>> Afaict this would still not work, due to 8d990807ec2c ("stubdom/grub:
>> update init_netfront() call for mini-os"). The dependencies between
>> the two trees aren't helpful at all in a case like this one.
>
> This is clearly a problem of the mini-os private interfaces used by
> stubdom/grub. The clean solution here would be either to add a stable
> ABI to mini-os usable by stubdom/grub (and probably others in similar
> cases) in order to avoid such issues, or to have feature defines like
> for libxl in order to be able to specify to use the old interfaces of
> mini-os by stubdoms (which could be removed after all users having been
> switched to the new interfaces).
Actually, with also reverting 8d990807ec2c in the main tree (along with
effectively reverting e013e8514389, which comes down to the same as Ian
suggested for 165f3afbfc3d), and with its future re-installment at the
same time bumping the mini-os commit to use, things ought to work I
would think. That would then be the same model again as used for
qemu-trad.
Jan
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] minios: Revert recent change and revert to working minios
2020-09-04 6:52 ` Jan Beulich
@ 2020-09-04 16:00 ` Ian Jackson
2020-09-04 22:01 ` Jason Long
0 siblings, 1 reply; 15+ messages in thread
From: Ian Jackson @ 2020-09-04 16:00 UTC (permalink / raw)
To: xen-devel; +Cc: iwj, Jan Beulich, Costin Lupu, Wei Liu, Samuel Thibault
Currently, xen.git#staging does not build in many environments because
of issues with minios master. This regression was introduced in an
uncontrolled manner by an update to mini-os.git#master.
This is because in e013e8514389 "config: use mini-os master for
unstable" we switched to tracking minios master in an uncontrolled
manner. At the time we thought it was unlikely that minios changes
would break the Xen build. This turns out to have been overly
optimistic.
Xen currently uses unstable internal interfaces of minios. Until this
can be sorted out, internal changes to minios can require lockstep
changes in Xen.
All this means that "config: use mini-os master for unstable" was
wrong. We should undo it. Instead, we go back to the previous
situation: xen.git names a specific minios commit.
This scheme is the model used for qemu-xen-traditional.
That nailed commit must be updated manually, to have xen.git pick up
changes from minios. If the minios changes require changes in xen.git
too, to avoid breaking the Xen build, they can be made freely in
minios without adverse consequences. When the minios commitid is
updated in xen.git, the corresponding changes to the actual source
files in xen.git should be bundled together.
For example, when minios is fixed, 8d990807ec2c "stubdom/grub: update
init_netfront() call for mini-os" will need to be reapplied, folded
into the same commit as updates MINIOS_UPSTREAM_REVISION. For now
that commit must be reverted as we are going back to a previous
version of minios.
This reverts commit 8d990807ec2cde3061222a5ed2df62aba78bace9.
This reverts commit e013e8514389b739153016349e49f5a78e34ddf0.
CC: Jan Beulich <jbeulich@suse.com>
CC: Costin Lupu <costin.lupu@cs.pub.ro>
CC: Wei Liu <wl@xen.org>
CC: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
Config.mk | 2 +-
stubdom/grub/mini-os.c | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Config.mk b/Config.mk
index 8269503f73..db434ee2c6 100644
--- a/Config.mk
+++ b/Config.mk
@@ -246,7 +246,7 @@ MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git
endif
OVMF_UPSTREAM_REVISION ?= a3741780fe3535e19e02efa869a7cac481891129
QEMU_UPSTREAM_REVISION ?= master
-MINIOS_UPSTREAM_REVISION ?= master
+MINIOS_UPSTREAM_REVISION ?= 0b4b7897e08b967a09bed2028a79fabff82342dd
SEABIOS_UPSTREAM_REVISION ?= rel-1.14.0
diff --git a/stubdom/grub/mini-os.c b/stubdom/grub/mini-os.c
index b33dbf02fb..4fc052a255 100644
--- a/stubdom/grub/mini-os.c
+++ b/stubdom/grub/mini-os.c
@@ -291,6 +291,8 @@ struct netfront_dev *net_dev;
int
minios_probe (struct nic *nic)
{
+ char *ip;
+
if (net_dev)
return 1;
@@ -298,7 +300,7 @@ minios_probe (struct nic *nic)
grub_memset ((char *) arptable, 0,
MAX_ARP * sizeof (struct arptable_t));
- net_dev = init_netfront(NULL, (void*) -1, nic->node_addr, NULL, NULL, NULL);
+ net_dev = init_netfront(NULL, (void*) -1, nic->node_addr, &ip);
if (!net_dev)
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL [and 1 more messages]
2020-09-04 6:38 ` Jürgen Groß
2020-09-04 6:52 ` Jan Beulich
@ 2020-09-04 16:50 ` Ian Jackson
2020-09-04 17:35 ` Wei Liu
2020-09-05 4:50 ` Jürgen Groß
1 sibling, 2 replies; 15+ messages in thread
From: Ian Jackson @ 2020-09-04 16:50 UTC (permalink / raw)
To: Jan Beulich, Jürgen Groß,
Costin Lupu, Wei Liu, Samuel Thibault
Cc: xen-devel
Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
> Actually, with also reverting 8d990807ec2c in the main tree (along with
> effectively reverting e013e8514389, which comes down to the same as Ian
> suggested for 165f3afbfc3d), and with its future re-installment at the
> same time bumping the mini-os commit to use, things ought to work I
> would think. That would then be the same model again as used for
> qemu-trad.
I implemented this here:
Ian Jackson writes ("[PATCH] minios: Revert recent change and revert to working minios"):
> Currently, xen.git#staging does not build in many environments because
> of issues with minios master. This regression was introduced in an
> uncontrolled manner by an update to mini-os.git#master.
I don't have any formal acks for this but, having build-tested it, I
am going to push it now, because the build is broken.
Ian.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL [and 1 more messages]
2020-09-04 16:50 ` [xen-unstable test] 153602: regressions - FAIL [and 1 more messages] Ian Jackson
@ 2020-09-04 17:35 ` Wei Liu
2020-09-05 4:50 ` Jürgen Groß
1 sibling, 0 replies; 15+ messages in thread
From: Wei Liu @ 2020-09-04 17:35 UTC (permalink / raw)
To: Ian Jackson
Cc: Jan Beulich, Jürgen Groß,
Costin Lupu, Wei Liu, Samuel Thibault, xen-devel
On Fri, Sep 04, 2020 at 05:50:28PM +0100, Ian Jackson wrote:
> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
> > Actually, with also reverting 8d990807ec2c in the main tree (along with
> > effectively reverting e013e8514389, which comes down to the same as Ian
> > suggested for 165f3afbfc3d), and with its future re-installment at the
> > same time bumping the mini-os commit to use, things ought to work I
> > would think. That would then be the same model again as used for
> > qemu-trad.
>
> I implemented this here:
>
> Ian Jackson writes ("[PATCH] minios: Revert recent change and revert to working minios"):
> > Currently, xen.git#staging does not build in many environments because
> > of issues with minios master. This regression was introduced in an
> > uncontrolled manner by an update to mini-os.git#master.
>
> I don't have any formal acks for this but, having build-tested it, I
> am going to push it now, because the build is broken.
Thanks for handling this.
Wei.
>
> Ian.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] minios: Revert recent change and revert to working minios
2020-09-04 16:00 ` [PATCH] minios: Revert recent change and revert to working minios Ian Jackson
@ 2020-09-04 22:01 ` Jason Long
2020-09-05 18:12 ` Samuel Thibault
0 siblings, 1 reply; 15+ messages in thread
From: Jason Long @ 2020-09-04 22:01 UTC (permalink / raw)
To: Ian Jackson, xen-devel
Cc: iwj, Jan Beulich, Costin Lupu, Wei Liu, Samuel Thibault
[-- Attachment #1: Type: text/plain, Size: 3386 bytes --]
Hello,Can anyone tell me about the goal and features of Mini-OS?
Sent from Yahoo Mail on Android
On Fri, Sep 4, 2020 at 8:31 PM, Ian Jackson<iwj@xenproject.org> wrote: Currently, xen.git#staging does not build in many environments because
of issues with minios master. This regression was introduced in an
uncontrolled manner by an update to mini-os.git#master.
This is because in e013e8514389 "config: use mini-os master for
unstable" we switched to tracking minios master in an uncontrolled
manner. At the time we thought it was unlikely that minios changes
would break the Xen build. This turns out to have been overly
optimistic.
Xen currently uses unstable internal interfaces of minios. Until this
can be sorted out, internal changes to minios can require lockstep
changes in Xen.
All this means that "config: use mini-os master for unstable" was
wrong. We should undo it. Instead, we go back to the previous
situation: xen.git names a specific minios commit.
This scheme is the model used for qemu-xen-traditional.
That nailed commit must be updated manually, to have xen.git pick up
changes from minios. If the minios changes require changes in xen.git
too, to avoid breaking the Xen build, they can be made freely in
minios without adverse consequences. When the minios commitid is
updated in xen.git, the corresponding changes to the actual source
files in xen.git should be bundled together.
For example, when minios is fixed, 8d990807ec2c "stubdom/grub: update
init_netfront() call for mini-os" will need to be reapplied, folded
into the same commit as updates MINIOS_UPSTREAM_REVISION. For now
that commit must be reverted as we are going back to a previous
version of minios.
This reverts commit 8d990807ec2cde3061222a5ed2df62aba78bace9.
This reverts commit e013e8514389b739153016349e49f5a78e34ddf0.
CC: Jan Beulich <jbeulich@suse.com>
CC: Costin Lupu <costin.lupu@cs.pub.ro>
CC: Wei Liu <wl@xen.org>
CC: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
Config.mk | 2 +-
stubdom/grub/mini-os.c | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Config.mk b/Config.mk
index 8269503f73..db434ee2c6 100644
--- a/Config.mk
+++ b/Config.mk
@@ -246,7 +246,7 @@ MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git
endif
OVMF_UPSTREAM_REVISION ?= a3741780fe3535e19e02efa869a7cac481891129
QEMU_UPSTREAM_REVISION ?= master
-MINIOS_UPSTREAM_REVISION ?= master
+MINIOS_UPSTREAM_REVISION ?= 0b4b7897e08b967a09bed2028a79fabff82342dd
SEABIOS_UPSTREAM_REVISION ?= rel-1.14.0
diff --git a/stubdom/grub/mini-os.c b/stubdom/grub/mini-os.c
index b33dbf02fb..4fc052a255 100644
--- a/stubdom/grub/mini-os.c
+++ b/stubdom/grub/mini-os.c
@@ -291,6 +291,8 @@ struct netfront_dev *net_dev;
int
minios_probe (struct nic *nic)
{
+ char *ip;
+
if (net_dev)
return 1;
@@ -298,7 +300,7 @@ minios_probe (struct nic *nic)
grub_memset ((char *) arptable, 0,
MAX_ARP * sizeof (struct arptable_t));
- net_dev = init_netfront(NULL, (void*) -1, nic->node_addr, NULL, NULL, NULL);
+ net_dev = init_netfront(NULL, (void*) -1, nic->node_addr, &ip);
if (!net_dev)
return 0;
--
2.20.1
[-- Attachment #2: Type: text/html, Size: 6583 bytes --]
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [xen-unstable test] 153602: regressions - FAIL [and 1 more messages]
2020-09-04 16:50 ` [xen-unstable test] 153602: regressions - FAIL [and 1 more messages] Ian Jackson
2020-09-04 17:35 ` Wei Liu
@ 2020-09-05 4:50 ` Jürgen Groß
1 sibling, 0 replies; 15+ messages in thread
From: Jürgen Groß @ 2020-09-05 4:50 UTC (permalink / raw)
To: Ian Jackson, Jan Beulich, Costin Lupu, Wei Liu, Samuel Thibault; +Cc: xen-devel
On 04.09.20 18:50, Ian Jackson wrote:
> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
>> Actually, with also reverting 8d990807ec2c in the main tree (along with
>> effectively reverting e013e8514389, which comes down to the same as Ian
>> suggested for 165f3afbfc3d), and with its future re-installment at the
>> same time bumping the mini-os commit to use, things ought to work I
>> would think. That would then be the same model again as used for
>> qemu-trad.
>
> I implemented this here:
>
> Ian Jackson writes ("[PATCH] minios: Revert recent change and revert to working minios"):
>> Currently, xen.git#staging does not build in many environments because
>> of issues with minios master. This regression was introduced in an
>> uncontrolled manner by an update to mini-os.git#master.
>
> I don't have any formal acks for this but, having build-tested it, I
> am going to push it now, because the build is broken.
Any reason you selected the 4.13 tag instead of the 4.14 one?
Would you even consider using d8a7bd2430a590a958f3c17fc1b2f7f563a04db2
in order not to block my libbuild series?
Juergen
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] minios: Revert recent change and revert to working minios
2020-09-04 22:01 ` Jason Long
@ 2020-09-05 18:12 ` Samuel Thibault
2020-09-05 21:02 ` Jason Long
0 siblings, 1 reply; 15+ messages in thread
From: Samuel Thibault @ 2020-09-05 18:12 UTC (permalink / raw)
To: Jason Long; +Cc: Ian Jackson, xen-devel, Jan Beulich, Costin Lupu, Wei Liu
Hello,
Jason Long, le ven. 04 sept. 2020 22:01:42 +0000, a ecrit:
> Can anyone tell me about the goal and features of Mini-OS?
https://wiki.xen.org/wiki/Mini-OS
Samuel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] minios: Revert recent change and revert to working minios
2020-09-05 18:12 ` Samuel Thibault
@ 2020-09-05 21:02 ` Jason Long
2020-09-05 21:35 ` Samuel Thibault
0 siblings, 1 reply; 15+ messages in thread
From: Jason Long @ 2020-09-05 21:02 UTC (permalink / raw)
To: Samuel Thibault; +Cc: Ian Jackson, xen-devel, Jan Beulich, Costin Lupu, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
What is the difference with Unikraft?
Sent from Yahoo Mail on Android
On Sat, Sep 5, 2020 at 10:43 PM, Samuel Thibault<samuel.thibault@ens-lyon.org> wrote: Hello,
Jason Long, le ven. 04 sept. 2020 22:01:42 +0000, a ecrit:
> Can anyone tell me about the goal and features of Mini-OS?
https://wiki.xen.org/wiki/Mini-OS
Samuel
[-- Attachment #2: Type: text/html, Size: 1189 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] minios: Revert recent change and revert to working minios
2020-09-05 21:02 ` Jason Long
@ 2020-09-05 21:35 ` Samuel Thibault
0 siblings, 0 replies; 15+ messages in thread
From: Samuel Thibault @ 2020-09-05 21:35 UTC (permalink / raw)
To: Jason Long; +Cc: Ian Jackson, xen-devel, Jan Beulich, Costin Lupu, Wei Liu
Jason Long, le sam. 05 sept. 2020 21:02:16 +0000, a ecrit:
> What is the difference with Unikraft?
Unikraft is originally based on MiniOS, and AIUI is actively being
worked on while MiniOS is mostly only maintained.
Samuel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-09-05 21:36 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 10:24 [xen-unstable test] 153602: regressions - FAIL osstest service owner
2020-09-03 14:02 ` Jan Beulich
2020-09-03 16:17 ` Ian Jackson
2020-09-03 16:29 ` Costin Lupu
2020-09-04 6:32 ` Jan Beulich
2020-09-04 6:38 ` Jürgen Groß
2020-09-04 6:52 ` Jan Beulich
2020-09-04 16:00 ` [PATCH] minios: Revert recent change and revert to working minios Ian Jackson
2020-09-04 22:01 ` Jason Long
2020-09-05 18:12 ` Samuel Thibault
2020-09-05 21:02 ` Jason Long
2020-09-05 21:35 ` Samuel Thibault
2020-09-04 16:50 ` [xen-unstable test] 153602: regressions - FAIL [and 1 more messages] Ian Jackson
2020-09-04 17:35 ` Wei Liu
2020-09-05 4:50 ` Jürgen Groß
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.