From: Richard Weinberger <richard@nod.at> To: chengzhihao1 <chengzhihao1@huawei.com> Cc: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, mcoquelin stm32 <mcoquelin.stm32@gmail.com>, kirill shutemov <kirill.shutemov@linux.intel.com>, Sascha Hauer <s.hauer@pengutronix.de>, linux-mtd <linux-mtd@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v6 12/15] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 Date: Tue, 11 Jan 2022 08:27:46 +0100 (CET) [thread overview] Message-ID: <244238061.248369.1641886066066.JavaMail.zimbra@nod.at> (raw) In-Reply-To: <6f7df7ba-9557-58a3-7978-e5d14a72f234@huawei.com> ----- Ursprüngliche Mail ----- > Von: "chengzhihao1" <chengzhihao1@huawei.com> > An: "richard" <richard@nod.at> > CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "mcoquelin stm32" > <mcoquelin.stm32@gmail.com>, "kirill shutemov" <kirill.shutemov@linux.intel.com>, "Sascha Hauer" > <s.hauer@pengutronix.de>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org> > Gesendet: Dienstag, 11. Januar 2022 03:48:24 > Betreff: Re: [PATCH v6 12/15] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 > Hi Richard, >> scan_ai->fastmap may contain also old fastmap PEBs. >> In the area < UBI_FM_MAX_START you can find outdated fastmap PEBs. >> e.g. after power-cut. >> That's why scan_ai->fastmap is copied into ai->fastmap. >> Later in ubi_wl_init() these outdated PEBs will get erased. >> So, you cannot remove this code. > I thought old fastmap PEBs(async erase works in ubi_update_fastmap()) > will be counted into erase PEBs in the next attaching process, because I > saw following code snippet in ubi_write_fastmap(): > 1260 list_for_each_entry(ubi_wrk, &ubi->works, list) { > > 1261 if (ubi_is_erase_work(ubi_wrk)) { > > 1262 wl_e = ubi_wrk->e; > > 1263 ubi_assert(wl_e); > > 1264 > > 1265 fec = (struct ubi_fm_ec *)(fm_raw + > fm_pos); > 1266 > > 1267 fec->pnum = cpu_to_be32(wl_e->pnum); > > 1268 set_seen(ubi, wl_e->pnum, seen_pebs); > > 1269 fec->ec = cpu_to_be32(wl_e->ec); > > 1270 > > 1271 erase_peb_count++; > > 1272 fm_pos += sizeof(*fec); > > 1273 ubi_assert(fm_pos <= ubi->fm_size); > > 1274 } > > 1275 } > > 1276 fmh->erase_peb_count = cpu_to_be32(erase_peb_count); > Half-writing on fastmap will be recognized in scanning, and UBI > fallbacks full scanning, So, I come up with two situations: > 1. power-cut before new fastmap written, the old fastmap is completely > saved until next attaching, and some free PEBs are written with new > fastmap data. Luckly, fastmap anchor PEB's vid header is written first > of all, bad fastmap will be returned by ubi_attach_fastmap() in next > attaching. > 2. power-cut after new fastmap written, the old fastmap PEBs will be > added into 'ai->erase' list in next attaching. > Did I miss other possible circumstances? In ubi_wl_init() there is another corner case documented: /* * The fastmap update code might not find a free PEB for * writing the fastmap anchor to and then reuses the * current fastmap anchor PEB. When this PEB gets erased * and a power cut happens before it is written again we * must make sure that the fastmap attach code doesn't * find any outdated fastmap anchors, hence we erase the * outdated fastmap anchor PEBs synchronously here. */ if (aeb->vol_id == UBI_FM_SB_VOLUME_ID) sync = true; So ubi_wl_init() makes sure that all old fastmap anchors get erased before UBI starts to operate. With your change this is no longer satisfied. Thanks, //richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at> To: chengzhihao1 <chengzhihao1@huawei.com> Cc: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, mcoquelin stm32 <mcoquelin.stm32@gmail.com>, kirill shutemov <kirill.shutemov@linux.intel.com>, Sascha Hauer <s.hauer@pengutronix.de>, linux-mtd <linux-mtd@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v6 12/15] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 Date: Tue, 11 Jan 2022 08:27:46 +0100 (CET) [thread overview] Message-ID: <244238061.248369.1641886066066.JavaMail.zimbra@nod.at> (raw) In-Reply-To: <6f7df7ba-9557-58a3-7978-e5d14a72f234@huawei.com> ----- Ursprüngliche Mail ----- > Von: "chengzhihao1" <chengzhihao1@huawei.com> > An: "richard" <richard@nod.at> > CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "mcoquelin stm32" > <mcoquelin.stm32@gmail.com>, "kirill shutemov" <kirill.shutemov@linux.intel.com>, "Sascha Hauer" > <s.hauer@pengutronix.de>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org> > Gesendet: Dienstag, 11. Januar 2022 03:48:24 > Betreff: Re: [PATCH v6 12/15] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 > Hi Richard, >> scan_ai->fastmap may contain also old fastmap PEBs. >> In the area < UBI_FM_MAX_START you can find outdated fastmap PEBs. >> e.g. after power-cut. >> That's why scan_ai->fastmap is copied into ai->fastmap. >> Later in ubi_wl_init() these outdated PEBs will get erased. >> So, you cannot remove this code. > I thought old fastmap PEBs(async erase works in ubi_update_fastmap()) > will be counted into erase PEBs in the next attaching process, because I > saw following code snippet in ubi_write_fastmap(): > 1260 list_for_each_entry(ubi_wrk, &ubi->works, list) { > > 1261 if (ubi_is_erase_work(ubi_wrk)) { > > 1262 wl_e = ubi_wrk->e; > > 1263 ubi_assert(wl_e); > > 1264 > > 1265 fec = (struct ubi_fm_ec *)(fm_raw + > fm_pos); > 1266 > > 1267 fec->pnum = cpu_to_be32(wl_e->pnum); > > 1268 set_seen(ubi, wl_e->pnum, seen_pebs); > > 1269 fec->ec = cpu_to_be32(wl_e->ec); > > 1270 > > 1271 erase_peb_count++; > > 1272 fm_pos += sizeof(*fec); > > 1273 ubi_assert(fm_pos <= ubi->fm_size); > > 1274 } > > 1275 } > > 1276 fmh->erase_peb_count = cpu_to_be32(erase_peb_count); > Half-writing on fastmap will be recognized in scanning, and UBI > fallbacks full scanning, So, I come up with two situations: > 1. power-cut before new fastmap written, the old fastmap is completely > saved until next attaching, and some free PEBs are written with new > fastmap data. Luckly, fastmap anchor PEB's vid header is written first > of all, bad fastmap will be returned by ubi_attach_fastmap() in next > attaching. > 2. power-cut after new fastmap written, the old fastmap PEBs will be > added into 'ai->erase' list in next attaching. > Did I miss other possible circumstances? In ubi_wl_init() there is another corner case documented: /* * The fastmap update code might not find a free PEB for * writing the fastmap anchor to and then reuses the * current fastmap anchor PEB. When this PEB gets erased * and a power cut happens before it is written again we * must make sure that the fastmap attach code doesn't * find any outdated fastmap anchors, hence we erase the * outdated fastmap anchor PEBs synchronously here. */ if (aeb->vol_id == UBI_FM_SB_VOLUME_ID) sync = true; So ubi_wl_init() makes sure that all old fastmap anchors get erased before UBI starts to operate. With your change this is no longer satisfied. Thanks, //richard ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-01-11 7:27 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-27 3:22 [PATCH v6 00/15] Some bugfixs for ubi/ubifs Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 01/15] ubifs: rename_whiteout: Fix double free for whiteout_ui->data Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 02/15] ubifs: Fix deadlock in concurrent rename whiteout and inode writeback Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 03/15] ubifs: Fix wrong number of inodes locked by ui_mutex in ubifs_inode comment Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 04/15] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 05/15] ubifs: Rename whiteout atomically Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2022-01-09 21:14 ` Richard Weinberger 2022-01-09 21:14 ` Richard Weinberger 2022-01-10 9:35 ` Zhihao Cheng 2022-01-10 9:35 ` Zhihao Cheng 2022-01-10 10:14 ` Richard Weinberger 2022-01-10 10:14 ` Richard Weinberger 2022-01-10 20:58 ` Richard Weinberger 2022-01-10 20:58 ` Richard Weinberger 2021-12-27 3:22 ` [PATCH v6 06/15] ubifs: Fix 'ui->dirty' race between do_tmpfile() and writeback work Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 07/15] ubifs: Rectify space amount budget for mkdir/tmpfile operations Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 08/15] ubifs: setflags: Make dirtied_ino_d 8 bytes aligned Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 09/15] ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock() Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 10/15] ubifs: Fix to add refcount once page is set private Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 11/15] ubi: fastmap: Return error code if memory allocation fails in add_aeb() Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 12/15] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2022-01-10 23:23 ` Richard Weinberger 2022-01-10 23:23 ` Richard Weinberger 2022-01-11 2:48 ` Zhihao Cheng 2022-01-11 2:48 ` Zhihao Cheng 2022-01-11 7:27 ` Richard Weinberger [this message] 2022-01-11 7:27 ` Richard Weinberger 2022-01-11 11:44 ` Zhihao Cheng 2022-01-11 11:44 ` Zhihao Cheng 2022-01-11 11:57 ` Richard Weinberger 2022-01-11 11:57 ` Richard Weinberger 2022-01-11 13:23 ` Zhihao Cheng 2022-01-11 13:23 ` Zhihao Cheng 2022-01-11 13:56 ` Richard Weinberger 2022-01-11 13:56 ` Richard Weinberger 2022-01-12 3:46 ` Zhihao Cheng 2022-01-12 3:46 ` Zhihao Cheng 2022-01-14 18:45 ` Richard Weinberger 2022-01-14 18:45 ` Richard Weinberger 2022-01-15 8:22 ` Zhihao Cheng 2022-01-15 8:22 ` Zhihao Cheng 2022-01-15 8:46 ` Zhihao Cheng 2022-01-15 8:46 ` Zhihao Cheng 2022-01-15 10:01 ` Richard Weinberger 2022-01-15 10:01 ` Richard Weinberger 2022-01-17 1:31 ` Zhihao Cheng 2022-01-17 1:31 ` Zhihao Cheng 2022-01-17 2:52 ` Zhihao Cheng 2022-01-17 2:52 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 13/15] ubifs: ubifs_writepage: Mark page dirty after writing inode failed Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 14/15] ubifs: ubifs_releasepage: Remove ubifs_assert(0) to valid this process Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2021-12-27 3:22 ` [PATCH v6 15/15] ubi: fastmap: Fix high cpu usage of ubi_bgt by making sure wl_pool not empty Zhihao Cheng 2021-12-27 3:22 ` Zhihao Cheng 2022-01-17 1:40 ` Zhihao Cheng 2022-01-17 1:40 ` Zhihao Cheng 2021-12-27 10:13 ` [PATCH v6 00/15] Some bugfixs for ubi/ubifs Richard Weinberger 2021-12-27 10:13 ` Richard Weinberger 2021-12-27 12:19 ` Zhihao Cheng 2021-12-27 12:19 ` Zhihao Cheng 2021-12-27 13:00 ` Richard Weinberger 2021-12-27 13:00 ` Richard Weinberger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=244238061.248369.1641886066066.JavaMail.zimbra@nod.at \ --to=richard@nod.at \ --cc=chengzhihao1@huawei.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=mcoquelin.stm32@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=s.hauer@pengutronix.de \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.