[PATCH] android: Fix memory leak: uuid free

[PATCH] android: Fix memory leak: uuid free

[Andrei Emeltchenko]

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Free uuid before exiting.
---
 android/bluetooth.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/android/bluetooth.c b/android/bluetooth.c
index 5de3401..b818e88 100644
--- a/android/bluetooth.c
+++ b/android/bluetooth.c
@@ -1557,6 +1557,8 @@ int bt_adapter_add_record(sdp_record_t *rec, uint8_t svc_hint)
 
 		sdp_uuid2strn(uuid, uuid_str, sizeof(uuid_str));
 		DBG("UUID %s already added", uuid_str);
+
+		bt_free(uuid);
 		return -EALREADY;
 	}
 
-- 
1.8.3.2

Re: [PATCH] android: Fix memory leak: uuid free

[Andrei Emeltchenko]

On Wed, Feb 12, 2014 at 04:22:07PM +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> Free uuid before exiting.

ping

> ---
>  android/bluetooth.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index 5de3401..b818e88 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -1557,6 +1557,8 @@ int bt_adapter_add_record(sdp_record_t *rec, uint8_t svc_hint)
>  
>  		sdp_uuid2strn(uuid, uuid_str, sizeof(uuid_str));
>  		DBG("UUID %s already added", uuid_str);
> +
> +		bt_free(uuid);
>  		return -EALREADY;
>  	}
>  
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] android: Fix memory leak: uuid free

[Szymon Janc]

Hi Andrei,

On Wednesday 12 of February 2014 16:22:07 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> Free uuid before exiting.
> ---
>  android/bluetooth.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index 5de3401..b818e88 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -1557,6 +1557,8 @@ int bt_adapter_add_record(sdp_record_t *rec, uint8_t svc_hint)
>  
>  		sdp_uuid2strn(uuid, uuid_str, sizeof(uuid_str));
>  		DBG("UUID %s already added", uuid_str);
> +
> +		bt_free(uuid);
>  		return -EALREADY;
>  	}

Applied, thanks.

-- 
Best regards, 
Szymon Janc