Re: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Michael Neuling <mikey@neuling.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Milton Miller <miltonm@bga.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	devicetree-discuss@lists.ozlabs.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions
Date: Mon, 06 Feb 2012 16:22:41 +1100	[thread overview]
Message-ID: <24476.1328505761@neuling.org> (raw)
In-Reply-To: <1327700179-17454-22-git-send-email-grant.likely@secretlab.ca>

>  static const struct irq_domain_ops pmac_pic_host_ops = {
>  	.match = pmac_pic_host_match,
>  	.map = pmac_pic_host_map,
> -	.xlate = pmac_pic_host_xlate,
> +	.xlate = irq_domain_xlate_onecell;
>  };
>  

This causes a compile fail (in next-20120206):
  arch/powerpc/platforms/powermac/pic.c:294: error: expected '}' before ';' token
Trivial fix below:



irqdomain/powerpc: Fix compile error in powermac/pic.c

Error introduced in:
  commit 72d6b477675374eafd206720d6c9146520df18ce
  Author: Grant Likely <grant.likely@secretlab.ca>
  irqdomain/powerpc: Replace custom xlate functions with library functions

Signed-off-by: Michael Neuling <mikey@neuling.org>

diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index 3af29d1..92afc38 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -291,7 +291,7 @@ static int pmac_pic_host_map(struct irq_domain *h, unsigned int virq,
 static const struct irq_domain_ops pmac_pic_host_ops = {
 	.match = pmac_pic_host_match,
 	.map = pmac_pic_host_map,
-	.xlate = irq_domain_xlate_onecell;
+	.xlate = irq_domain_xlate_onecell,
 };
 
 static void __init pmac_pic_probe_oldstyle(void)

WARNING: multiple messages have this Message-ID (diff)

From: Michael Neuling <mikey@neuling.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Rob Herring <rob.herring@calxeda.com>,
	Milton Miller <miltonm@bga.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions
Date: Mon, 06 Feb 2012 16:22:41 +1100	[thread overview]
Message-ID: <24476.1328505761@neuling.org> (raw)
In-Reply-To: <1327700179-17454-22-git-send-email-grant.likely@secretlab.ca>

>  static const struct irq_domain_ops pmac_pic_host_ops = {
>  	.match = pmac_pic_host_match,
>  	.map = pmac_pic_host_map,
> -	.xlate = pmac_pic_host_xlate,
> +	.xlate = irq_domain_xlate_onecell;
>  };
>  

This causes a compile fail (in next-20120206):
  arch/powerpc/platforms/powermac/pic.c:294: error: expected '}' before ';' token
Trivial fix below:



irqdomain/powerpc: Fix compile error in powermac/pic.c

Error introduced in:
  commit 72d6b477675374eafd206720d6c9146520df18ce
  Author: Grant Likely <grant.likely@secretlab.ca>
  irqdomain/powerpc: Replace custom xlate functions with library functions

Signed-off-by: Michael Neuling <mikey@neuling.org>

diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index 3af29d1..92afc38 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -291,7 +291,7 @@ static int pmac_pic_host_map(struct irq_domain *h, unsigned int virq,
 static const struct irq_domain_ops pmac_pic_host_ops = {
 	.match = pmac_pic_host_match,
 	.map = pmac_pic_host_map,
-	.xlate = irq_domain_xlate_onecell;
+	.xlate = irq_domain_xlate_onecell,
 };
 
 static void __init pmac_pic_probe_oldstyle(void)

WARNING: multiple messages have this Message-ID (diff)

From: mikey@neuling.org (Michael Neuling)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions
Date: Mon, 06 Feb 2012 16:22:41 +1100	[thread overview]
Message-ID: <24476.1328505761@neuling.org> (raw)
In-Reply-To: <1327700179-17454-22-git-send-email-grant.likely@secretlab.ca>

>  static const struct irq_domain_ops pmac_pic_host_ops = {
>  	.match = pmac_pic_host_match,
>  	.map = pmac_pic_host_map,
> -	.xlate = pmac_pic_host_xlate,
> +	.xlate = irq_domain_xlate_onecell;
>  };
>  

This causes a compile fail (in next-20120206):
  arch/powerpc/platforms/powermac/pic.c:294: error: expected '}' before ';' token
Trivial fix below:



irqdomain/powerpc: Fix compile error in powermac/pic.c

Error introduced in:
  commit 72d6b477675374eafd206720d6c9146520df18ce
  Author: Grant Likely <grant.likely@secretlab.ca>
  irqdomain/powerpc: Replace custom xlate functions with library functions

Signed-off-by: Michael Neuling <mikey@neuling.org>

diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index 3af29d1..92afc38 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -291,7 +291,7 @@ static int pmac_pic_host_map(struct irq_domain *h, unsigned int virq,
 static const struct irq_domain_ops pmac_pic_host_ops = {
 	.match = pmac_pic_host_match,
 	.map = pmac_pic_host_map,
-	.xlate = irq_domain_xlate_onecell;
+	.xlate = irq_domain_xlate_onecell,
 };
 
 static void __init pmac_pic_probe_oldstyle(void)

next prev parent reply	other threads:[~2012-02-06  5:22 UTC|newest]

Thread overview: 224+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 21:35 [PATCH v3 00/25] irq_domain generalization and refinement Grant Likely
2012-01-27 21:35 ` Grant Likely
2012-01-27 21:35 ` Grant Likely
2012-01-27 21:35 ` [PATCH v3 01/25] irq_domain: add documentation and MAINTAINERS entry Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-28 18:23   ` Randy Dunlap
2012-01-28 18:23     ` Randy Dunlap
2012-01-28 18:23     ` Randy Dunlap
2012-01-28 18:23     ` Randy Dunlap
     [not found]     ` <4F243D2C.7040709-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-01-28 19:59       ` Grant Likely
2012-01-28 19:59         ` Grant Likely
2012-01-27 21:35 ` [PATCH v3 02/25] dt: Make irqdomain less verbose Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35 ` [PATCH v3 03/25] irq_domain: Make irq_domain structure match powerpc's irq_host Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35 ` [PATCH v3 04/25] irq_domain: convert microblaze from irq_host to irq_domain Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35 ` [PATCH v3 05/25] irq_domain/powerpc: Use common irq_domain structure instead of irq_host Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:35   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 06/25] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 07/25] irq_domain/powerpc: Eliminate virq_is_host() Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 08/25] irq_domain: Move irq_domain code from powerpc to kernel/irq Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 09/25] irqdomain: remove NO_IRQ from irq domain code Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 10/25] irq_domain: Remove references to old irq_host names Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 11/25] irq_domain: Replace irq_alloc_host() with revmap-specific initializers Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 12/25] irq_domain: Add support for base irq and hwirq in legacy mappings Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 13/25] irq_domain: Remove 'new' irq_domain in favour of the ppc one Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-02-03 14:48   ` Cousson, Benoit
2012-02-03 14:48     ` Cousson, Benoit
2012-02-03 14:48     ` Cousson, Benoit
2012-02-03 14:48     ` Cousson, Benoit
2012-02-03 16:42     ` Grant Likely
2012-02-03 16:42       ` Grant Likely
2012-02-03 16:42       ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 14/25] irq_domain: Remove irq_domain_add_simple() Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-31 12:45   ` Shawn Guo
2012-01-31 12:45     ` Shawn Guo
2012-01-31 12:45     ` Shawn Guo
2012-01-31 13:15     ` Rob Herring
2012-01-31 13:15       ` Rob Herring
2012-01-31 13:15       ` Rob Herring
2012-01-31 13:58       ` Shawn Guo
2012-01-31 13:58         ` Shawn Guo
2012-01-31 13:58         ` Shawn Guo
2012-01-31 13:58         ` Shawn Guo
2012-02-01  0:08         ` Grant Likely
2012-02-01  0:08           ` Grant Likely
2012-02-01  0:08           ` Grant Likely
2012-02-01  5:46   ` [PATCH] irq_domain: fix the irq number of imx5 tzic Shawn Guo
2012-02-01  5:46     ` Shawn Guo
2012-02-01  5:46     ` Shawn Guo
2012-02-02  4:58     ` Grant Likely
2012-02-02  4:58       ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 15/25] irq_domain: Create common xlate functions that device drivers can use Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 16/25] irq_domain: constify irq_domain_ops Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 17/25] irq_domain/c6x: Convert c6x to use generic irq_domain support Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 18/25] irq_domain/c6x: constify irq_domain structures Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 19/25] irq_domain/c6x: Use library of xlate functions Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 20/25] irq_domain/powerpc: constify irq_domain_ops Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-02-06  5:22   ` Michael Neuling [this message]
2012-02-06  5:22     ` Michael Neuling
2012-02-06  5:22     ` Michael Neuling
2012-02-06  6:00     ` Grant Likely
2012-02-06  6:00       ` Grant Likely
2012-02-06  6:00       ` Grant Likely
2012-02-06  6:00       ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 22/25] irq_domain/x86: Convert x86 (embedded) to use common irq_domain Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-28 16:44   ` Sebastian Andrzej Siewior
2012-01-28 16:44     ` Sebastian Andrzej Siewior
2012-01-28 16:44     ` Sebastian Andrzej Siewior
2012-01-29  0:35     ` Grant Likely
2012-01-29  0:35       ` Grant Likely
2012-01-29  0:35       ` Grant Likely
2012-01-29  0:35       ` Grant Likely
2012-01-29  0:39       ` Grant Likely
2012-01-29  0:39         ` Grant Likely
2012-01-29  0:39         ` Grant Likely
2012-01-29  0:39         ` Grant Likely
2012-01-30 19:58     ` Grant Likely
2012-01-30 19:58       ` Grant Likely
2012-01-30 19:58       ` Grant Likely
2012-02-01 14:17       ` Sebastian Andrzej Siewior
2012-02-01 14:17         ` Sebastian Andrzej Siewior
2012-02-01 14:17         ` Sebastian Andrzej Siewior
2012-02-01 14:17         ` Sebastian Andrzej Siewior
2012-02-01 18:06         ` Grant Likely
2012-02-01 18:06           ` Grant Likely
2012-02-01 18:06           ` Grant Likely
2012-02-01 18:06           ` Grant Likely
2012-02-23 19:56           ` Grant Likely
2012-02-23 19:56             ` Grant Likely
2012-02-23 19:56             ` Grant Likely
2012-02-23 21:22             ` Sebastian Andrzej Siewior
2012-02-23 21:22               ` Sebastian Andrzej Siewior
2012-02-23 21:22               ` Sebastian Andrzej Siewior
2012-02-23 21:39               ` Grant Likely
2012-02-23 21:39                 ` Grant Likely
2012-02-23 21:39                 ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 23/25] irq_domain: Include hwirq number in /proc/interrupts Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36 ` [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-02-07 18:07   ` Nicolas Ferre
2012-02-07 18:07     ` Nicolas Ferre
2012-02-07 18:07     ` Nicolas Ferre
2012-02-07 18:07     ` Nicolas Ferre
2012-02-15 15:04     ` Nicolas Ferre
2012-02-15 15:04       ` Nicolas Ferre
2012-02-15 20:21       ` Grant Likely
2012-02-15 20:21         ` Grant Likely
2012-02-15 20:21         ` Grant Likely
2012-02-15 21:50         ` Shawn Guo
2012-02-15 21:50           ` Shawn Guo
2012-02-15 21:50           ` Shawn Guo
2012-02-16  5:32           ` Grant Likely
2012-02-16  5:32             ` Grant Likely
2012-02-16  5:32             ` Grant Likely
2012-02-16  6:03             ` Shawn Guo
2012-02-16  6:03               ` Shawn Guo
2012-02-16  6:03               ` Shawn Guo
2012-01-27 21:36 ` [PATCH v3 25/25] irq_domain: mostly eliminate slow-path revmap lookups Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-01-27 21:36   ` Grant Likely
2012-02-15 16:36   ` Nicolas Ferre
2012-02-15 16:36     ` Nicolas Ferre
2012-02-15 16:36     ` Nicolas Ferre
2012-02-15 20:29     ` Grant Likely
2012-02-15 20:29       ` Grant Likely
2012-02-15 20:29       ` Grant Likely
2012-01-28 18:38 ` [PATCH v3 00/25] irq_domain generalization and refinement Rob Herring
2012-01-28 18:38   ` Rob Herring
2012-01-28 18:38   ` Rob Herring
2012-01-28 18:38   ` Rob Herring
     [not found]   ` <4F2440A2.5080601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-28 19:10     ` Grant Likely
2012-01-28 19:10       ` Grant Likely
2012-01-31  4:53 ` Olof Johansson
2012-01-31  4:53   ` Olof Johansson
2012-01-31  4:53   ` Olof Johansson
2012-02-01  0:07   ` Grant Likely
2012-02-01  0:07     ` Grant Likely
2012-02-01  0:07     ` Grant Likely
2012-02-04 22:17 ` Russell King - ARM Linux
2012-02-04 22:17   ` Russell King - ARM Linux
2012-02-04 22:17   ` Russell King - ARM Linux
2012-02-04 22:17   ` Russell King - ARM Linux
2012-02-04 22:31   ` Russell King - ARM Linux
2012-02-04 22:31     ` Russell King - ARM Linux
2012-02-04 22:31     ` Russell King - ARM Linux
2012-02-04 22:31     ` Russell King - ARM Linux
2012-02-05  1:38     ` Tony Lindgren
2012-02-05  1:38       ` Tony Lindgren
2012-02-05  1:38       ` Tony Lindgren
2012-02-05  1:38       ` Tony Lindgren
2012-02-05 16:13       ` Russell King - ARM Linux
2012-02-05 16:13         ` Russell King - ARM Linux
2012-02-05 16:13         ` Russell King - ARM Linux
2012-02-05 16:13         ` Russell King - ARM Linux
2012-02-07 15:26         ` Mark Brown
2012-02-07 15:26           ` Mark Brown
2012-02-07 15:26           ` Mark Brown
2012-02-15 20:33           ` Grant Likely
2012-02-15 20:33             ` Grant Likely
2012-02-15 20:33             ` Grant Likely
2012-02-05  0:01   ` Benjamin Herrenschmidt
2012-02-05  0:01     ` Benjamin Herrenschmidt
2012-02-05  0:01     ` Benjamin Herrenschmidt
2012-02-05  0:01     ` Benjamin Herrenschmidt
2012-02-06  0:51   ` Rob Herring
2012-02-06  0:51     ` Rob Herring
2012-02-06  0:51     ` Rob Herring
2012-02-06  0:51     ` Rob Herring
2012-02-06  5:56   ` Grant Likely
2012-02-06  5:56     ` Grant Likely
2012-02-06  5:56     ` Grant Likely

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:3af29d1 dfblob:3af29d1 dfblob:3af29d1 dfblob:92afc38
dfblob:92afc38 dfblob:92afc38
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24476.1328505761@neuling.org \
    --to=mikey@neuling.org \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=rob.herring@calxeda.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.