* [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information
@ 2021-04-09 12:35 matthias.bgg at kernel.org
2021-04-09 12:35 ` [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver matthias.bgg at kernel.org
2021-04-09 13:13 ` [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information Fabian Vogt
0 siblings, 2 replies; 5+ messages in thread
From: matthias.bgg at kernel.org @ 2021-04-09 12:35 UTC (permalink / raw)
To: u-boot
From: Matthias Brugger <mbrugger@suse.com>
At present SMBIOS tables are emtpy, which breaks some use-cases that
rely on that. Add some minimal information to fullfill this.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
arch/arm/dts/bcm283x-u-boot.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
index 68d03627f4..f5235cb083 100644
--- a/arch/arm/dts/bcm283x-u-boot.dtsi
+++ b/arch/arm/dts/bcm283x-u-boot.dtsi
@@ -6,6 +6,26 @@
* (C) Copyright 2016 Fabian Vogt <fvogt@suse.com>
*/
+/ {
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+ smbios {
+ system {
+ manufacturer = "raspberrypi";
+ product = "rpi";
+ };
+ baseboard {
+ manufacturer = "raspberrypi";
+ product = "rpi";
+ };
+ chassis {
+ manufacturer = "raspberrypi";
+ product = "rpi";
+ };
+ };
+ };
+};
+
&uart0 {
skip-init;
u-boot,dm-pre-reloc;
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver
2021-04-09 12:35 [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information matthias.bgg at kernel.org
@ 2021-04-09 12:35 ` matthias.bgg at kernel.org
2021-04-09 13:13 ` Fabian Vogt
2021-04-09 13:13 ` [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information Fabian Vogt
1 sibling, 1 reply; 5+ messages in thread
From: matthias.bgg at kernel.org @ 2021-04-09 12:35 UTC (permalink / raw)
To: u-boot
From: Matthias Brugger <mbrugger@suse.com>
Enalbe this driver to allow U-Boot to get SMBIOS table information from
a device tree node.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
configs/rpi_0_w_defconfig | 2 ++
configs/rpi_2_defconfig | 2 ++
configs/rpi_3_32b_defconfig | 2 ++
configs/rpi_3_b_plus_defconfig | 2 ++
configs/rpi_3_defconfig | 2 ++
configs/rpi_4_32b_defconfig | 2 ++
configs/rpi_4_defconfig | 2 ++
configs/rpi_arm64_defconfig | 2 ++
configs/rpi_defconfig | 2 ++
9 files changed, 18 insertions(+)
diff --git a/configs/rpi_0_w_defconfig b/configs/rpi_0_w_defconfig
index c0a9b6c788..206be1590c 100644
--- a/configs/rpi_0_w_defconfig
+++ b/configs/rpi_0_w_defconfig
@@ -28,6 +28,8 @@ CONFIG_DM_ETH=y
CONFIG_PINCTRL=y
# CONFIG_PINCTRL_GENERIC is not set
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_DWC2=y
diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
index 33e0ef6989..d3d62f3028 100644
--- a/configs/rpi_2_defconfig
+++ b/configs/rpi_2_defconfig
@@ -28,6 +28,8 @@ CONFIG_DM_ETH=y
CONFIG_PINCTRL=y
# CONFIG_PINCTRL_GENERIC is not set
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_DWC2=y
diff --git a/configs/rpi_3_32b_defconfig b/configs/rpi_3_32b_defconfig
index 15c62adc69..b69bc05833 100644
--- a/configs/rpi_3_32b_defconfig
+++ b/configs/rpi_3_32b_defconfig
@@ -30,6 +30,8 @@ CONFIG_DM_ETH=y
CONFIG_PINCTRL=y
# CONFIG_PINCTRL_GENERIC is not set
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_DWC2=y
diff --git a/configs/rpi_3_b_plus_defconfig b/configs/rpi_3_b_plus_defconfig
index ebab0b4f86..8316a43116 100644
--- a/configs/rpi_3_b_plus_defconfig
+++ b/configs/rpi_3_b_plus_defconfig
@@ -30,6 +30,8 @@ CONFIG_DM_ETH=y
CONFIG_PINCTRL=y
# CONFIG_PINCTRL_GENERIC is not set
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_DWC2=y
diff --git a/configs/rpi_3_defconfig b/configs/rpi_3_defconfig
index daeb6d1b64..bdfac3f31a 100644
--- a/configs/rpi_3_defconfig
+++ b/configs/rpi_3_defconfig
@@ -30,6 +30,8 @@ CONFIG_DM_ETH=y
CONFIG_PINCTRL=y
# CONFIG_PINCTRL_GENERIC is not set
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_DWC2=y
diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
index 0cbdd5fee1..7a10d4b0d4 100644
--- a/configs/rpi_4_32b_defconfig
+++ b/configs/rpi_4_32b_defconfig
@@ -39,6 +39,8 @@ CONFIG_DM_RESET=y
CONFIG_DM_RNG=y
CONFIG_RNG_IPROC200=y
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_DM_USB_GADGET=y
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
index 3f21f99edb..5d889df794 100644
--- a/configs/rpi_4_defconfig
+++ b/configs/rpi_4_defconfig
@@ -39,6 +39,8 @@ CONFIG_DM_RESET=y
CONFIG_DM_RNG=y
CONFIG_RNG_IPROC200=y
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_DM_USB_GADGET=y
diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig
index d282d509ce..af45178962 100644
--- a/configs/rpi_arm64_defconfig
+++ b/configs/rpi_arm64_defconfig
@@ -36,6 +36,8 @@ CONFIG_DM_RESET=y
CONFIG_DM_RNG=y
CONFIG_RNG_IPROC200=y
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_XHCI_HCD=y
diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
index 06b390d907..af084c8505 100644
--- a/configs/rpi_defconfig
+++ b/configs/rpi_defconfig
@@ -28,6 +28,8 @@ CONFIG_DM_ETH=y
CONFIG_PINCTRL=y
# CONFIG_PINCTRL_GENERIC is not set
# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_DWC2=y
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information
2021-04-09 12:35 [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information matthias.bgg at kernel.org
2021-04-09 12:35 ` [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver matthias.bgg at kernel.org
@ 2021-04-09 13:13 ` Fabian Vogt
2021-04-12 13:33 ` Matthias Brugger
1 sibling, 1 reply; 5+ messages in thread
From: Fabian Vogt @ 2021-04-09 13:13 UTC (permalink / raw)
To: u-boot
Am Freitag, 9. April 2021, 14:35:10 CEST schrieb matthias.bgg at kernel.org:
> From: Matthias Brugger <mbrugger@suse.com>
>
> At present SMBIOS tables are emtpy,
^ typo
> which breaks some use-cases that rely on that.
Can you give an example?
> Add some minimal information to
Isn't it possible to get the complete information from the firmware here?
That would allow to have the correct product and serial at least.
If that's not possible or too complex, then I suggest to use the proper
strings, e.g. "Raspberry Pi", as those are user visible.
> fullfill this.
^ typo
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>
> arch/arm/dts/bcm283x-u-boot.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> index 68d03627f4..f5235cb083 100644
> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> @@ -6,6 +6,26 @@
> * (C) Copyright 2016 Fabian Vogt <fvogt@suse.com>
> */
>
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> + smbios {
> + system {
> + manufacturer = "raspberrypi";
> + product = "rpi";
> + };
> + baseboard {
> + manufacturer = "raspberrypi";
> + product = "rpi";
> + };
> + chassis {
> + manufacturer = "raspberrypi";
> + product = "rpi";
According to doc/device-tree-bindings/sysinfo/smbios.txt, "chassis"
doesn't have a "product".
Cheers,
Fabian
> + };
> + };
> + };
> +};
> +
> &uart0 {
> skip-init;
> u-boot,dm-pre-reloc;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver
2021-04-09 12:35 ` [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver matthias.bgg at kernel.org
@ 2021-04-09 13:13 ` Fabian Vogt
0 siblings, 0 replies; 5+ messages in thread
From: Fabian Vogt @ 2021-04-09 13:13 UTC (permalink / raw)
To: u-boot
Am Freitag, 9. April 2021, 14:35:11 CEST schrieb matthias.bgg at kernel.org:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Enalbe this driver to allow U-Boot to get SMBIOS table information from
^ typo
Other than that,
Acked-by: Fabian Vogt <fvogt@suse.com>
Cheers,
Fabian
> a device tree node.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> configs/rpi_0_w_defconfig | 2 ++
> configs/rpi_2_defconfig | 2 ++
> configs/rpi_3_32b_defconfig | 2 ++
> configs/rpi_3_b_plus_defconfig | 2 ++
> configs/rpi_3_defconfig | 2 ++
> configs/rpi_4_32b_defconfig | 2 ++
> configs/rpi_4_defconfig | 2 ++
> configs/rpi_arm64_defconfig | 2 ++
> configs/rpi_defconfig | 2 ++
> 9 files changed, 18 insertions(+)
>
> diff --git a/configs/rpi_0_w_defconfig b/configs/rpi_0_w_defconfig
> index c0a9b6c788..206be1590c 100644
> --- a/configs/rpi_0_w_defconfig
> +++ b/configs/rpi_0_w_defconfig
> @@ -28,6 +28,8 @@ CONFIG_DM_ETH=y
> CONFIG_PINCTRL=y
> # CONFIG_PINCTRL_GENERIC is not set
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_DWC2=y
> diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
> index 33e0ef6989..d3d62f3028 100644
> --- a/configs/rpi_2_defconfig
> +++ b/configs/rpi_2_defconfig
> @@ -28,6 +28,8 @@ CONFIG_DM_ETH=y
> CONFIG_PINCTRL=y
> # CONFIG_PINCTRL_GENERIC is not set
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_DWC2=y
> diff --git a/configs/rpi_3_32b_defconfig b/configs/rpi_3_32b_defconfig
> index 15c62adc69..b69bc05833 100644
> --- a/configs/rpi_3_32b_defconfig
> +++ b/configs/rpi_3_32b_defconfig
> @@ -30,6 +30,8 @@ CONFIG_DM_ETH=y
> CONFIG_PINCTRL=y
> # CONFIG_PINCTRL_GENERIC is not set
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_DWC2=y
> diff --git a/configs/rpi_3_b_plus_defconfig b/configs/rpi_3_b_plus_defconfig
> index ebab0b4f86..8316a43116 100644
> --- a/configs/rpi_3_b_plus_defconfig
> +++ b/configs/rpi_3_b_plus_defconfig
> @@ -30,6 +30,8 @@ CONFIG_DM_ETH=y
> CONFIG_PINCTRL=y
> # CONFIG_PINCTRL_GENERIC is not set
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_DWC2=y
> diff --git a/configs/rpi_3_defconfig b/configs/rpi_3_defconfig
> index daeb6d1b64..bdfac3f31a 100644
> --- a/configs/rpi_3_defconfig
> +++ b/configs/rpi_3_defconfig
> @@ -30,6 +30,8 @@ CONFIG_DM_ETH=y
> CONFIG_PINCTRL=y
> # CONFIG_PINCTRL_GENERIC is not set
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_DWC2=y
> diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
> index 0cbdd5fee1..7a10d4b0d4 100644
> --- a/configs/rpi_4_32b_defconfig
> +++ b/configs/rpi_4_32b_defconfig
> @@ -39,6 +39,8 @@ CONFIG_DM_RESET=y
> CONFIG_DM_RNG=y
> CONFIG_RNG_IPROC200=y
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_DM_USB_GADGET=y
> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
> index 3f21f99edb..5d889df794 100644
> --- a/configs/rpi_4_defconfig
> +++ b/configs/rpi_4_defconfig
> @@ -39,6 +39,8 @@ CONFIG_DM_RESET=y
> CONFIG_DM_RNG=y
> CONFIG_RNG_IPROC200=y
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_DM_USB_GADGET=y
> diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig
> index d282d509ce..af45178962 100644
> --- a/configs/rpi_arm64_defconfig
> +++ b/configs/rpi_arm64_defconfig
> @@ -36,6 +36,8 @@ CONFIG_DM_RESET=y
> CONFIG_DM_RNG=y
> CONFIG_RNG_IPROC200=y
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_XHCI_HCD=y
> diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
> index 06b390d907..af084c8505 100644
> --- a/configs/rpi_defconfig
> +++ b/configs/rpi_defconfig
> @@ -28,6 +28,8 @@ CONFIG_DM_ETH=y
> CONFIG_PINCTRL=y
> # CONFIG_PINCTRL_GENERIC is not set
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_USB=y
> CONFIG_DM_USB=y
> CONFIG_USB_DWC2=y
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information
2021-04-09 13:13 ` [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information Fabian Vogt
@ 2021-04-12 13:33 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2021-04-12 13:33 UTC (permalink / raw)
To: u-boot
On Fri, Apr 09, 2021 at 03:13:25PM +0200, Fabian Vogt wrote:
> Am Freitag, 9. April 2021, 14:35:10 CEST schrieb matthias.bgg at kernel.org:
> > From: Matthias Brugger <mbrugger@suse.com>
> >
> > At present SMBIOS tables are emtpy,
> ^ typo
>
> > which breaks some use-cases that rely on that.
> Can you give an example?
Management software that want's to know what HW a node is based on.
>
> > Add some minimal information to
> Isn't it possible to get the complete information from the firmware here?
> That would allow to have the correct product and serial at least.
That's the plan for the long run.
> If that's not possible or too complex, then I suggest to use the proper
> strings, e.g. "Raspberry Pi", as those are user visible.
I'd like to stay backwards compatible to older U-Boot versions for now.
>
> > fullfill this.
> ^ typo
>
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> > ---
> >
> > arch/arm/dts/bcm283x-u-boot.dtsi | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> > index 68d03627f4..f5235cb083 100644
> > --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> > +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> > @@ -6,6 +6,26 @@
> > * (C) Copyright 2016 Fabian Vogt <fvogt@suse.com>
> > */
> >
> > +/ {
> > + smbios {
> > + compatible = "u-boot,sysinfo-smbios";
> > + smbios {
> > + system {
> > + manufacturer = "raspberrypi";
> > + product = "rpi";
> > + };
> > + baseboard {
> > + manufacturer = "raspberrypi";
> > + product = "rpi";
> > + };
> > + chassis {
> > + manufacturer = "raspberrypi";
> > + product = "rpi";
>
> According to doc/device-tree-bindings/sysinfo/smbios.txt, "chassis"
> doesn't have a "product".
>
You are correct. I'll fix the typos and this in the next version.
Regards,
Matthias
> Cheers,
> Fabian
>
> > + };
> > + };
> > + };
> > +};
> > +
> > &uart0 {
> > skip-init;
> > u-boot,dm-pre-reloc;
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-12 13:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 12:35 [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information matthias.bgg at kernel.org
2021-04-09 12:35 ` [PATCH 2/2] configs: rpi: Enable SMBIOS sysinfo driver matthias.bgg at kernel.org
2021-04-09 13:13 ` Fabian Vogt
2021-04-09 13:13 ` [PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information Fabian Vogt
2021-04-12 13:33 ` Matthias Brugger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.