From: Ian Jackson <iwj@xenproject.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>, <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v1] xl: use proper name for bash_completion file
Date: Fri, 22 Jan 2021 14:22:59 +0000 [thread overview]
Message-ID: <24586.57283.613836.976947@mariner.uk.xensource.com> (raw)
In-Reply-To: <391d3d0b-0c07-b3e0-47ea-e9918f591587@citrix.com>
Andrew Cooper writes ("Re: [PATCH v1] xl: use proper name for bash_completion file"):
> On 20/10/2020 13:39, Olaf Hering wrote:
> > Files in the bash-completion dirs should be named like the commands,
> > without suffix. Without this change 'xl' will not be recognized as a
> > command with completion support if BASH_COMPLETION_DIR is set to
> > /usr/share/bash-completion/completions.
> >
> > Fixes commit 9136a919b19929ecb242ef327053d55d824397df
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> This obviously fell through the cracks, but definitely matches how
> systems are typically set up.
Technically speaking this might need a release-ack as it's enabling a
feature that was previously defeated by a bug. I think it's fine at
this stage, so:
Release-Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
prev parent reply other threads:[~2021-01-22 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 12:39 [PATCH v1] xl: use proper name for bash_completion file Olaf Hering
2021-01-22 13:33 ` Andrew Cooper
2021-01-22 14:22 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24586.57283.613836.976947@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=olaf@aepfle.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.