All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>, <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v1] xl: use proper name for bash_completion file
Date: Fri, 22 Jan 2021 13:33:47 +0000	[thread overview]
Message-ID: <391d3d0b-0c07-b3e0-47ea-e9918f591587@citrix.com> (raw)
In-Reply-To: <20201020123928.27099-1-olaf@aepfle.de>

On 20/10/2020 13:39, Olaf Hering wrote:
> Files in the bash-completion dirs should be named like the commands,
> without suffix. Without this change 'xl' will not be recognized as a
> command with completion support if BASH_COMPLETION_DIR is set to
> /usr/share/bash-completion/completions.
>
> Fixes commit 9136a919b19929ecb242ef327053d55d824397df
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

This obviously fell through the cracks, but definitely matches how
systems are typically set up.

> ---
>  tools/xl/Makefile        | 4 ++--
>  tools/xl/bash-completion | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/xl/Makefile b/tools/xl/Makefile
> index bdf67c8464..656b21c7da 100644
> --- a/tools/xl/Makefile
> +++ b/tools/xl/Makefile
> @@ -45,11 +45,11 @@ install: all
>  	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
>  	$(INSTALL_DIR) $(DESTDIR)$(BASH_COMPLETION_DIR)
>  	$(INSTALL_PROG) xl $(DESTDIR)$(sbindir)
> -	$(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
> +	$(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl
>  
>  .PHONY: uninstall
>  uninstall:
> -	rm -f $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
> +	rm -f $(DESTDIR)$(BASH_COMPLETION_DIR)/xl
>  	rm -f $(DESTDIR)$(sbindir)/xl
>  
>  .PHONY: clean
> diff --git a/tools/xl/bash-completion b/tools/xl/bash-completion
> index b7cd6b3992..7c6ed32f88 100644
> --- a/tools/xl/bash-completion
> +++ b/tools/xl/bash-completion
> @@ -1,4 +1,4 @@
> -# Copy this file to /etc/bash_completion.d/xl.sh
> +# Copy this file to /etc/bash_completion.d/xl
>  
>  _xl()
>  {
>



  reply	other threads:[~2021-01-22 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 12:39 [PATCH v1] xl: use proper name for bash_completion file Olaf Hering
2021-01-22 13:33 ` Andrew Cooper [this message]
2021-01-22 14:22   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=391d3d0b-0c07-b3e0-47ea-e9918f591587@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=olaf@aepfle.de \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.