From: Ian Jackson <iwj@xenproject.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
"Manuel Bouyer" <bouyer@netbsd.org>
Subject: Re: [PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource
Date: Wed, 3 Feb 2021 17:51:14 +0000 [thread overview]
Message-ID: <24602.58002.389945.787614@mariner.uk.xensource.com> (raw)
In-Reply-To: <20210203163750.7564-2-andrew.cooper3@citrix.com>
Andrew Cooper writes ("[PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource"):
> Simplify the FreeBSD logic, and duplicate it for NetBSD as the userpace ABI
> appears to be to consistently provide EOPNOTSUPP for missing Xen/Kernel
> support.
>
> The Linux logic was contorted in what appears to be a deliberate attempt to
> skip the now-deleted logic for the EOPNOTSUPP case. Simplify it.
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Sorry for my earlier confusion. I had lost the context between the
two patches. I will explain my reasoning for the R-A:
For the first two hunks (freebsd.c): these are consequential cleanup
from patch 1/2 of this series. Splitting this up made this easier to
review and we don't want to leave the rather unfortunate constructs
which arise from some hunks of 1/1. IOW, the combination of 1/1 plus
the first two hunks here is definitely release-worthy and the split
has helped review.
The final hunk is a straightforward bugfix.
This combination of two completely different kinds of thing is a bit
confusing but now that I have explained it to myself I'm satisfied.
Ian.
next prev parent reply other threads:[~2021-02-03 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:37 [PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging Andrew Cooper
2021-02-03 16:37 ` [PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource Andrew Cooper
2021-02-03 17:18 ` Ian Jackson
2021-02-03 17:27 ` Andrew Cooper
2021-02-03 17:51 ` Ian Jackson [this message]
2021-02-03 17:52 ` Andrew Cooper
2021-02-03 17:16 ` [PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging Ian Jackson
2021-02-03 17:26 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24602.58002.389945.787614@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=bouyer@netbsd.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.