All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
	"Manuel Bouyer" <bouyer@netbsd.org>
Subject: Re: [PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging
Date: Wed, 3 Feb 2021 17:26:01 +0000	[thread overview]
Message-ID: <684c5f26-64ac-77cf-4b24-8a83376f8f70@citrix.com> (raw)
In-Reply-To: <24602.55938.208939.124502@mariner.uk.xensource.com>

On 03/02/2021 17:16, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging"):
>> These log lines are all in response to single system calls, and do not provide
>> any information which the immediate caller can't determine themselves.  It is
>> however exceedinly rude to put junk like this onto stderr, especially as
>> system call failures are not even error conditions in certain circumstances.
>>
>> The FreeBSD logging has stale function names in, and solaris shouldn't have
>> passed code review to start with.
>>
>> No functional change.
> Thanks.
>
> Reviewed-by: Ian Jackson <iwj@xenproject.org>
> Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks,

>
>>          int saved_errno = errno;
>> -        PERROR("XXXXXXXX");
>> +
> That's particularly wtf...

My thoughts exactly.

~Andrew


      reply	other threads:[~2021-02-03 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 16:37 [PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging Andrew Cooper
2021-02-03 16:37 ` [PATCH for-4.15 2/2] libs/foreignmem: Fix/simplify errno handling for map_resource Andrew Cooper
2021-02-03 17:18   ` Ian Jackson
2021-02-03 17:27     ` Andrew Cooper
2021-02-03 17:51   ` Ian Jackson
2021-02-03 17:52     ` Andrew Cooper
2021-02-03 17:16 ` [PATCH for-4.15 1/2] libs/foreignmem: Drop useless and/or misleading logging Ian Jackson
2021-02-03 17:26   ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=684c5f26-64ac-77cf-4b24-8a83376f8f70@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=bouyer@netbsd.org \
    --cc=iwj@xenproject.org \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.