All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH for-4.15] tools/tests: fix resource test build on FreeBSD
@ 2021-02-05 12:19 Roger Pau Monne
  2021-02-05 12:50 ` Andrew Cooper
  2021-02-05 15:38 ` Ian Jackson
  0 siblings, 2 replies; 3+ messages in thread
From: Roger Pau Monne @ 2021-02-05 12:19 UTC (permalink / raw)
  To: xen-devel; +Cc: Roger Pau Monne, Ian Jackson, Wei Liu

error.h is not a standard header, and none of the functions declared
there are actually used by the code. This fixes the build on FreeBSD
that doesn't have error.h

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Build tested on both Linux and FreeBSD. The risk would be breaking the
build, but it's already broken on FreeBSD so there's not much to lose.
Build breakages on Linux will be spotted fast by either osstest of the
gitlab build.
---
 tools/tests/resource/test-resource.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c
index a409a82f44..1caaa60e62 100644
--- a/tools/tests/resource/test-resource.c
+++ b/tools/tests/resource/test-resource.c
@@ -1,6 +1,5 @@
 #include <err.h>
 #include <errno.h>
-#include <error.h>
 #include <stdio.h>
 #include <string.h>
 #include <sys/mman.h>
-- 
2.29.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH for-4.15] tools/tests: fix resource test build on FreeBSD
  2021-02-05 12:19 [PATCH for-4.15] tools/tests: fix resource test build on FreeBSD Roger Pau Monne
@ 2021-02-05 12:50 ` Andrew Cooper
  2021-02-05 15:38 ` Ian Jackson
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2021-02-05 12:50 UTC (permalink / raw)
  To: Roger Pau Monne, xen-devel; +Cc: Ian Jackson, Wei Liu

On 05/02/2021 12:19, Roger Pau Monne wrote:
> error.h is not a standard header, and none of the functions declared
> there are actually used by the code. This fixes the build on FreeBSD
> that doesn't have error.h
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Urgh sorry.  Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH for-4.15] tools/tests: fix resource test build on FreeBSD
  2021-02-05 12:19 [PATCH for-4.15] tools/tests: fix resource test build on FreeBSD Roger Pau Monne
  2021-02-05 12:50 ` Andrew Cooper
@ 2021-02-05 15:38 ` Ian Jackson
  1 sibling, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2021-02-05 15:38 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel, Wei Liu

Roger Pau Monne writes ("[PATCH for-4.15] tools/tests: fix resource test build on FreeBSD"):
> error.h is not a standard header, and none of the functions declared
> there are actually used by the code. This fixes the build on FreeBSD
> that doesn't have error.h
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Build tested on both Linux and FreeBSD. The risk would be breaking the
> build, but it's already broken on FreeBSD so there's not much to lose.
> Build breakages on Linux will be spotted fast by either osstest of the
> gitlab build.

Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks.  I think this was probably a typo.

Ian.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-05 15:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 12:19 [PATCH for-4.15] tools/tests: fix resource test build on FreeBSD Roger Pau Monne
2021-02-05 12:50 ` Andrew Cooper
2021-02-05 15:38 ` Ian Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.