* [MPTCP] Re: [PATCH mptcp-next] Squash to "mptcp: only admit explicitly supported sockopt"
@ 2021-03-11 10:43 Paolo Abeni
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2021-03-11 10:43 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Thu, 2021-03-11 at 11:11 +0100, Matthieu Baerts wrote:
> SO_SNDTIMEO_{OLD,NEW} were missing in the list. They are considered as
> "quite common but need a better implementation".
>
> Indeed, as mentioned by Paolo: these settings are applied only to the
> first subflow, while mptcp_recvmsg()/mptcp_sendmsg() will look for the
> timeout value in the msk socket.
>
> At least with these patches, we can have MPTCP BPF selftest passing:
>
> ./test_progs -n 66
>
> Reported-and-tested-by: Geliang Tang <geliangtang(a)gmail.com>
> Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
> ---
>
> Notes:
> to be squashed in "mptcp: only admit explicitly supported sockopt"
>
> net/mptcp/sockopt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c
> index 3eda9127debb..fb98fab252df 100644
> --- a/net/mptcp/sockopt.c
> +++ b/net/mptcp/sockopt.c
> @@ -110,6 +110,8 @@ static bool mptcp_supported_sockopt(int level, int optname)
> case SO_RCVLOWAT:
> case SO_RCVTIMEO_OLD:
> case SO_RCVTIMEO_NEW:
> + case SO_SNDTIMEO_OLD:
> + case SO_SNDTIMEO_NEW:
> case SO_MARK:
> case SO_INCOMING_CPU:
> case SO_BINDTOIFINDEX:
LGTM!
Thanks,
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
* [MPTCP] Re: [PATCH mptcp-next] Squash to "mptcp: only admit explicitly supported sockopt"
@ 2021-03-11 11:05 Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2021-03-11 11:05 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
Hi Paolo,
On 11/03/2021 11:43, Paolo Abeni wrote:
> On Thu, 2021-03-11 at 11:11 +0100, Matthieu Baerts wrote:
>> SO_SNDTIMEO_{OLD,NEW} were missing in the list. They are considered as
>> "quite common but need a better implementation".
>>
>> Indeed, as mentioned by Paolo: these settings are applied only to the
>> first subflow, while mptcp_recvmsg()/mptcp_sendmsg() will look for the
>> timeout value in the msk socket.
>>
>> At least with these patches, we can have MPTCP BPF selftest passing:
>>
>> ./test_progs -n 66
>>
>> Reported-and-tested-by: Geliang Tang <geliangtang(a)gmail.com>
>> Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
>> ---
>>
>> Notes:
>> to be squashed in "mptcp: only admit explicitly supported sockopt"
>>
>> net/mptcp/sockopt.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c
>> index 3eda9127debb..fb98fab252df 100644
>> --- a/net/mptcp/sockopt.c
>> +++ b/net/mptcp/sockopt.c
>> @@ -110,6 +110,8 @@ static bool mptcp_supported_sockopt(int level, int optname)
>> case SO_RCVLOWAT:
>> case SO_RCVTIMEO_OLD:
>> case SO_RCVTIMEO_NEW:
>> + case SO_SNDTIMEO_OLD:
>> + case SO_SNDTIMEO_NEW:
>> case SO_MARK:
>> case SO_INCOMING_CPU:
>> case SO_BINDTOIFINDEX:
>
> LGTM!
Thank you for the review!
- 2b1cba1c2163: "squashed" in "mptcp: only admit explicitly supported
sockopt"
- 9d7b32e1e6c7: "Signed-off-by" + "Co-developed-by" auto-added (doesn't
feel right compared to all the work you did, I'm not sure I should keep
that)
- Results: b75b267765e6..d92688622965
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 10:43 [MPTCP] Re: [PATCH mptcp-next] Squash to "mptcp: only admit explicitly supported sockopt" Paolo Abeni
2021-03-11 11:05 Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.