* [PATCH for-4.14] tools: Fix pkg-config file for libxenstore
@ 2021-03-22 16:20 Andrew Cooper
2021-03-22 16:32 ` Jürgen Groß
2021-03-22 16:38 ` [PATCH v2 " Andrew Cooper
0 siblings, 2 replies; 7+ messages in thread
From: Andrew Cooper @ 2021-03-22 16:20 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Ian Jackson, Wei Liu, Juergen Gross, Jan Beulich
There is no dependency on libxenctrl.
Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Jan Beulich <JBeulich@suse.com>
This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and older
cause everything linking against libxenstore to also try linking against
libxenctrl. It also causes RPM to create unexpected dependencies between
subpackages, which is a problem when trying to separate the stable and
unstable libs.
---
tools/xenstore/xenstore.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstore/xenstore.pc.in b/tools/xenstore/xenstore.pc.in
index 2f64a6b824..98c3f1ab39 100644
--- a/tools/xenstore/xenstore.pc.in
+++ b/tools/xenstore/xenstore.pc.in
@@ -8,4 +8,4 @@ Version: @@version@@
Cflags: -I${includedir} @@cflagslocal@@
Libs: @@libsflag@@${libdir} -lxenstore
Libs.private: -ldl
-Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore
+Requires.private: xenevtchn,xengnttab,xentoolcore
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore
2021-03-22 16:20 [PATCH for-4.14] tools: Fix pkg-config file for libxenstore Andrew Cooper
@ 2021-03-22 16:32 ` Jürgen Groß
2021-03-22 16:35 ` Andrew Cooper
2021-03-22 16:38 ` [PATCH v2 " Andrew Cooper
1 sibling, 1 reply; 7+ messages in thread
From: Jürgen Groß @ 2021-03-22 16:32 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Ian Jackson, Wei Liu, Jan Beulich
[-- Attachment #1.1.1: Type: text/plain, Size: 1336 bytes --]
On 22.03.21 17:20, Andrew Cooper wrote:
> There is no dependency on libxenctrl.
>
> Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Ian Jackson <iwj@xenproject.org>
> CC: Wei Liu <wl@xen.org>
> CC: Juergen Gross <jgross@suse.com>
> CC: Jan Beulich <JBeulich@suse.com>
>
> This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and older
> cause everything linking against libxenstore to also try linking against
> libxenctrl. It also causes RPM to create unexpected dependencies between
> subpackages, which is a problem when trying to separate the stable and
> unstable libs.
> ---
> tools/xenstore/xenstore.pc.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xenstore/xenstore.pc.in b/tools/xenstore/xenstore.pc.in
> index 2f64a6b824..98c3f1ab39 100644
> --- a/tools/xenstore/xenstore.pc.in
> +++ b/tools/xenstore/xenstore.pc.in
> @@ -8,4 +8,4 @@ Version: @@version@@
> Cflags: -I${includedir} @@cflagslocal@@
> Libs: @@libsflag@@${libdir} -lxenstore
> Libs.private: -ldl
> -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore
> +Requires.private: xenevtchn,xengnttab,xentoolcore
Any reason you are keeping xenevtchn and xengnttab?
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore
2021-03-22 16:32 ` Jürgen Groß
@ 2021-03-22 16:35 ` Andrew Cooper
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Cooper @ 2021-03-22 16:35 UTC (permalink / raw)
To: Jürgen Groß, Xen-devel; +Cc: Ian Jackson, Wei Liu, Jan Beulich
On 22/03/2021 16:32, Jürgen Groß wrote:
> On 22.03.21 17:20, Andrew Cooper wrote:
>> There is no dependency on libxenctrl.
>>
>> Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Ian Jackson <iwj@xenproject.org>
>> CC: Wei Liu <wl@xen.org>
>> CC: Juergen Gross <jgross@suse.com>
>> CC: Jan Beulich <JBeulich@suse.com>
>>
>> This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and
>> older
>> cause everything linking against libxenstore to also try linking against
>> libxenctrl. It also causes RPM to create unexpected dependencies
>> between
>> subpackages, which is a problem when trying to separate the stable and
>> unstable libs.
>> ---
>> tools/xenstore/xenstore.pc.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/xenstore/xenstore.pc.in
>> b/tools/xenstore/xenstore.pc.in
>> index 2f64a6b824..98c3f1ab39 100644
>> --- a/tools/xenstore/xenstore.pc.in
>> +++ b/tools/xenstore/xenstore.pc.in
>> @@ -8,4 +8,4 @@ Version: @@version@@
>> Cflags: -I${includedir} @@cflagslocal@@
>> Libs: @@libsflag@@${libdir} -lxenstore
>> Libs.private: -ldl
>> -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore
>> +Requires.private: xenevtchn,xengnttab,xentoolcore
>
> Any reason you are keeping xenevtchn and xengnttab?
Oh - good point. I misread uselibs. Its only toolcore who's dependency
remains in 4.15.
I'll send out a v2.
~Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore
2021-03-22 16:20 [PATCH for-4.14] tools: Fix pkg-config file for libxenstore Andrew Cooper
2021-03-22 16:32 ` Jürgen Groß
@ 2021-03-22 16:38 ` Andrew Cooper
2021-03-23 5:20 ` Jürgen Groß
2021-03-23 12:57 ` Wei Liu
1 sibling, 2 replies; 7+ messages in thread
From: Andrew Cooper @ 2021-03-22 16:38 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Ian Jackson, Wei Liu, Juergen Gross, Jan Beulich
There are no dependenices on evtchn, ctrl or gnttab.
Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Jan Beulich <JBeulich@suse.com>
v2:
* Drop xenevtchn and xengnttab as well
This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and older
cause everything linking against libxenstore to also try linking against
libxenctrl. It also causes RPM to create unexpected dependencies between
subpackages, which is a problem when trying to separate the stable and
unstable libs.
---
tools/xenstore/xenstore.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstore/xenstore.pc.in b/tools/xenstore/xenstore.pc.in
index 2f64a6b824..2a278b4395 100644
--- a/tools/xenstore/xenstore.pc.in
+++ b/tools/xenstore/xenstore.pc.in
@@ -8,4 +8,4 @@ Version: @@version@@
Cflags: -I${includedir} @@cflagslocal@@
Libs: @@libsflag@@${libdir} -lxenstore
Libs.private: -ldl
-Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore
+Requires.private: xentoolcore
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore
2021-03-22 16:38 ` [PATCH v2 " Andrew Cooper
@ 2021-03-23 5:20 ` Jürgen Groß
2021-03-23 12:57 ` Wei Liu
1 sibling, 0 replies; 7+ messages in thread
From: Jürgen Groß @ 2021-03-23 5:20 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Ian Jackson, Wei Liu, Jan Beulich
[-- Attachment #1.1.1: Type: text/plain, Size: 292 bytes --]
On 22.03.21 17:38, Andrew Cooper wrote:
> There are no dependenices on evtchn, ctrl or gnttab.
>
> Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore
2021-03-22 16:38 ` [PATCH v2 " Andrew Cooper
2021-03-23 5:20 ` Jürgen Groß
@ 2021-03-23 12:57 ` Wei Liu
2021-03-23 13:30 ` Ian Jackson
1 sibling, 1 reply; 7+ messages in thread
From: Wei Liu @ 2021-03-23 12:57 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel, Ian Jackson, Wei Liu, Juergen Gross, Jan Beulich
On Mon, Mar 22, 2021 at 04:38:47PM +0000, Andrew Cooper wrote:
> There are no dependenices on evtchn, ctrl or gnttab.
>
> Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wl@xen.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore
2021-03-23 12:57 ` Wei Liu
@ 2021-03-23 13:30 ` Ian Jackson
0 siblings, 0 replies; 7+ messages in thread
From: Ian Jackson @ 2021-03-23 13:30 UTC (permalink / raw)
To: Wei Liu; +Cc: Andrew Cooper, Xen-devel, Juergen Gross, Jan Beulich
Wei Liu writes ("Re: [PATCH v2 for-4.14] tools: Fix pkg-config file for libxenstore"):
> On Mon, Mar 22, 2021 at 04:38:47PM +0000, Andrew Cooper wrote:
> > There are no dependenices on evtchn, ctrl or gnttab.
> >
> > Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Acked-by: Wei Liu <wl@xen.org>
Having slept on this and I am not convinced that this warrants
backporting. I prefer to take a generally cautious approach to
changes to packaging and the build system, as this is much less
disruptive to downstreams.
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-23 13:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 16:20 [PATCH for-4.14] tools: Fix pkg-config file for libxenstore Andrew Cooper
2021-03-22 16:32 ` Jürgen Groß
2021-03-22 16:35 ` Andrew Cooper
2021-03-22 16:38 ` [PATCH v2 " Andrew Cooper
2021-03-23 5:20 ` Jürgen Groß
2021-03-23 12:57 ` Wei Liu
2021-03-23 13:30 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.