All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>,
	Alexander Kanavin <alexander.kanavin@linux.intel.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>,
	Paul Eggleton <paul.eggleton@linux.intel.com>
Subject: Re: [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified
Date: Mon, 11 Dec 2017 14:14:33 +0800	[thread overview]
Message-ID: <24700d85-61ad-0801-14e1-17b0bb3b7e31@windriver.com> (raw)
In-Reply-To: <CAJTo0LaRAFuMxp5WYFSKT2_ziG4ZR9bu9viL7US8qPOVp7Q8Nw@mail.gmail.com>



On 12/09/2017 12:20 AM, Burton, Ross wrote:
> On 8 December 2017 at 14:07, Alexander Kanavin 
> <alexander.kanavin@linux.intel.com <mailto:alexander.kanavin@linux.intel.com>> 
> wrote:
> 
>     On 12/08/2017 03:51 AM, Robert Yang wrote:
> 
>             I'm not sure about this one. Commits shouldn't be created
>             automatically on a person's behalf and then also signed-off - I'd
>             say you need to first look at them.
> 
> 
>         IMHO, Auh is a helper, when user run:
>         $ auh less
> 
>         It helps create commits, should be the same as user run "git commit",
>         and the
>         user should responsible for it. Or how about add a -S option:
> 
>         -S, --SOB    Use git user as the author and add SOB.
> 
> 
>     Yeah, as long as maintainers don't send those raw commits straight to
>     mailing list, it's okay. It's rare that such an auto-created commit doesn't
>     need further work (e.g. to explain changes in patches or license, or other
>     adjustments).
> 
> 
> The lack of a SOB was intentional for exactly this reason.  No SOB means a human 
> didn't look at it *at all*/

Makes sense, so let's drop this patch.

// Robert


> 
> Ross


  reply	other threads:[~2017-12-11  6:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07  7:37 [PATCH 00/12] [auh] make it easy to use by recipe maintainer Robert Yang
2017-12-07  7:37 ` [PATCH 01/12] upgradehelper.py: fix checking for do_checkpkg Robert Yang
2017-12-07  7:37 ` [PATCH 02/12] upgradehelper.py: support upgrade multiple recipes Robert Yang
2017-12-07  7:37 ` [PATCH 03/12] upgradehelper.py: use UniverseUpdater for all cases Robert Yang
2017-12-07  7:37 ` [PATCH 04/12] modules/steps.py: fix warn when skip compilation Robert Yang
2017-12-07  7:37 ` [PATCH 05/12] " Robert Yang
2017-12-07 12:47   ` Alexander Kanavin
2017-12-07  7:37 ` [PATCH 06/12] upgradehelper.py: only check email settings when -e is specified Robert Yang
2017-12-07  7:37 ` [PATCH 07/12] upgradehelper.py: always do upgrade when recipes are specified Robert Yang
2017-12-07  7:37 ` [PATCH 08/12] upgradehelper.py: clean repo only once " Robert Yang
2017-12-07 12:58   ` Alexander Kanavin
2017-12-08  1:43     ` Robert Yang
2017-12-08  2:00       ` Robert Yang
2017-12-08 14:18         ` Alexander Kanavin
2017-12-11  6:13           ` Robert Yang
2017-12-12 12:26             ` Alexander Kanavin
2017-12-13  1:16               ` Robert Yang
2017-12-13 13:18                 ` Alexander Kanavin
2017-12-14  2:13                   ` Robert Yang
2017-12-14 16:38                     ` Alexander Kanavin
2017-12-15 13:35                       ` Alexander Kanavin
2017-12-19  7:20                         ` Robert Yang
2017-12-07  7:37 ` [PATCH 09/12] upgradehelper.py: use git user in commit " Robert Yang
2017-12-07 13:02   ` Alexander Kanavin
2017-12-08  1:51     ` Robert Yang
2017-12-08 14:07       ` Alexander Kanavin
2017-12-08 16:20         ` Burton, Ross
2017-12-11  6:14           ` Robert Yang [this message]
2017-12-07  7:37 ` [PATCH 10/12] upgradehelper.py: add --apply-failed option Robert Yang
2017-12-07 13:05   ` Alexander Kanavin
2017-12-08  2:02     ` Robert Yang
2017-12-07  7:37 ` [PATCH 11/12] upgradehelper.py: print info when recipe is skipped to upgrade Robert Yang
2017-12-07  7:37 ` [PATCH 12/12] upgradehelper.py: don't build gcc-runtime when --skip-compilation Robert Yang
2017-12-07  7:46 ` [PATCH 00/12] [auh] make it easy to use by recipe maintainer Robert Yang
2017-12-07  8:53 ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24700d85-61ad-0801-14e1-17b0bb3b7e31@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=alexander.kanavin@linux.intel.com \
    --cc=paul.eggleton@linux.intel.com \
    --cc=ross.burton@intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.