All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: <yocto@yoctoproject.org>
Cc: paul.eggleton@linux.intel.com
Subject: [PATCH 06/12] upgradehelper.py: only check email settings when -e is specified
Date: Thu, 7 Dec 2017 15:37:11 +0800	[thread overview]
Message-ID: <26cf02c172df0d19a9d9694c758228c90fc19d30.1512630627.git.liezhi.yang@windriver.com> (raw)
In-Reply-To: <cover.1512630627.git.liezhi.yang@windriver.com>

Fixed:
$ upgradehelper.py less
ERROR: smtp host not set! Sending emails disabled!
ERROR: 'From' address not set! Sending emails disabled!

Only check email settings when "-e" is specified can fix the problem.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 upgradehelper.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/upgradehelper.py b/upgradehelper.py
index 605114b..70b9e8d 100755
--- a/upgradehelper.py
+++ b/upgradehelper.py
@@ -149,7 +149,8 @@ class Updater(object):
 
         self._add_file_logger()
 
-        self.email_handler = Email(settings)
+        if self.args.send_emails:
+            self.email_handler = Email(settings)
         self.statistics = Statistics()
 
     def _set_options(self):
-- 
2.7.4



  parent reply	other threads:[~2017-12-07  7:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07  7:37 [PATCH 00/12] [auh] make it easy to use by recipe maintainer Robert Yang
2017-12-07  7:37 ` [PATCH 01/12] upgradehelper.py: fix checking for do_checkpkg Robert Yang
2017-12-07  7:37 ` [PATCH 02/12] upgradehelper.py: support upgrade multiple recipes Robert Yang
2017-12-07  7:37 ` [PATCH 03/12] upgradehelper.py: use UniverseUpdater for all cases Robert Yang
2017-12-07  7:37 ` [PATCH 04/12] modules/steps.py: fix warn when skip compilation Robert Yang
2017-12-07  7:37 ` [PATCH 05/12] " Robert Yang
2017-12-07 12:47   ` Alexander Kanavin
2017-12-07  7:37 ` Robert Yang [this message]
2017-12-07  7:37 ` [PATCH 07/12] upgradehelper.py: always do upgrade when recipes are specified Robert Yang
2017-12-07  7:37 ` [PATCH 08/12] upgradehelper.py: clean repo only once " Robert Yang
2017-12-07 12:58   ` Alexander Kanavin
2017-12-08  1:43     ` Robert Yang
2017-12-08  2:00       ` Robert Yang
2017-12-08 14:18         ` Alexander Kanavin
2017-12-11  6:13           ` Robert Yang
2017-12-12 12:26             ` Alexander Kanavin
2017-12-13  1:16               ` Robert Yang
2017-12-13 13:18                 ` Alexander Kanavin
2017-12-14  2:13                   ` Robert Yang
2017-12-14 16:38                     ` Alexander Kanavin
2017-12-15 13:35                       ` Alexander Kanavin
2017-12-19  7:20                         ` Robert Yang
2017-12-07  7:37 ` [PATCH 09/12] upgradehelper.py: use git user in commit " Robert Yang
2017-12-07 13:02   ` Alexander Kanavin
2017-12-08  1:51     ` Robert Yang
2017-12-08 14:07       ` Alexander Kanavin
2017-12-08 16:20         ` Burton, Ross
2017-12-11  6:14           ` Robert Yang
2017-12-07  7:37 ` [PATCH 10/12] upgradehelper.py: add --apply-failed option Robert Yang
2017-12-07 13:05   ` Alexander Kanavin
2017-12-08  2:02     ` Robert Yang
2017-12-07  7:37 ` [PATCH 11/12] upgradehelper.py: print info when recipe is skipped to upgrade Robert Yang
2017-12-07  7:37 ` [PATCH 12/12] upgradehelper.py: don't build gcc-runtime when --skip-compilation Robert Yang
2017-12-07  7:46 ` [PATCH 00/12] [auh] make it easy to use by recipe maintainer Robert Yang
2017-12-07  8:53 ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26cf02c172df0d19a9d9694c758228c90fc19d30.1512630627.git.liezhi.yang@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=paul.eggleton@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.