From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: Michael J Gruber <git@grubix.eu>, git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] commit-template: change a message to be more intuitive
Date: Thu, 14 Sep 2017 19:47:51 +0530 [thread overview]
Message-ID: <2480c33b-7e44-5c7c-cd31-feae9168b9dc@gmail.com> (raw)
In-Reply-To: <862e71a1-2dee-4a20-d828-69a0547fa5ec@grubix.eu>
On Thursday 14 September 2017 01:06 PM, Michael J Gruber wrote:
> Kaartic Sivaraam venit, vidit, dixit 13.09.2017 15:05:
>> void wt_status_add_cut_line(FILE *fp)
>> {
>> - const char *explanation = _("Do not touch the line above.\nEverything below will be removed.");
>> + const char *explanation = _("Do not modify or remove the line above.\nEverything below will be removed.");
> I don't want to complicate things. But now - due to the repeated usage
> of "remove" - these two sentences seem to be connected by an invisible
> "or else" ("will" vs. "would" not withstanding). i.e. "or else
> everything below will be removed, too", which is wrong. Before, they
> were separated more clearly.
At least I don't think they are connected by an invisible "or else" because
they appear on different lines,
#
# ------------------------ >8 ------------------------
# Do not modify or remove the line above.
# Everything below will be removed.
diff --git a/hook-checks/hooks/applypatch-msg b/hook-checks/hooks/applypatch-msg
new file mode 100755
index 0000000..a5d7b84
--- /dev/null
+++ b/hook-checks/hooks/applypatch-msg
> Also, given all the translations that we have, it seems somewhat strange
> to try and foresee and workaround possible misunderstandings of commonly
> used English phrases.
I thought the translators wouldn't mind this! If they do, then it's
better to drop
this patch.
---
Kaartic
next prev parent reply other threads:[~2017-09-14 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<e656d1b4-c95e-e51d-5f48-bb3450580fa4@gmail.com>
2017-09-13 13:05 ` [PATCH v2] commit-template: change a message to be more intuitive Kaartic Sivaraam
2017-09-14 7:36 ` Michael J Gruber
2017-09-14 14:17 ` Kaartic Sivaraam [this message]
2017-09-14 14:41 ` Jeff King
2017-09-15 2:18 ` Junio C Hamano
2017-09-15 4:50 ` [PATCH v3] " Kaartic Sivaraam
2017-09-15 10:00 ` Michael J Gruber
2017-09-15 12:39 ` Kaartic Sivaraam
2017-09-15 1:58 ` [PATCH v2] " Kaartic Sivaraam
2017-09-12 10:55 [PATCH] " Kaartic Sivaraam
2017-09-13 10:29 ` Kevin Daudt
2017-09-13 11:20 ` Jeff King
2017-09-13 12:31 ` Kaartic Sivaraam
2017-09-13 13:05 ` [PATCH v2] " Kaartic Sivaraam
2017-09-13 12:29 ` [PATCH] " Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2480c33b-7e44-5c7c-cd31-feae9168b9dc@gmail.com \
--to=kaarticsivaraam91196@gmail.com \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.