All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Liron Himi <lironh@marvell.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org, jerinj@marvell.com
Subject: Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers
Date: Mon, 11 Jan 2021 12:28:13 +0100	[thread overview]
Message-ID: <2489984.pHaSLPtmOr@thomas> (raw)
In-Reply-To: <20201216213652.5760-1-lironh@marvell.com>

16/12/2020 22:36, lironh@marvell.com:
> From: Liron Himi <lironh@marvell.com>
> 
> With pkg-config support available within musdk library
> (from musdk-release-SDK-10.3.5.0-PR2 version),
> meson option 'lib_musdk_dir' can be removed.
> PKG_CONFIG_PATH environment variable should be set appropriately
> to use the musdk library.

Sorry, it does not work.

First, when installing MUSDK, the .pc file is not updated
with the correct prefix path:
	make install DESTDIR=$(readlink -f install)
In install/mv/lib/pkgconfig/libmusdk.pc:
	prefix=/mv
instead of:
	prefix=/musdk_path/install/mv

Second, after manually fixing the prefix path and compiling DPDK:

In file included from musdk/install/mv/include/mv_std.h:101,
                 from musdk/install/mv/include/drivers/mv_neta.h:100,
                 from dpdk/drivers/net/mvneta/mvneta_ethdev.h:24,
                 from dpdk/drivers/net/mvneta/mvneta_rxtx.h:10,
                 from dpdk/drivers/net/mvneta/mvneta_rxtx.c:7:
musdk/install/mv/include/env/mv_autogen_build_assert.h:43:5: error:
"MVCONF_DMA_PHYS_ADDR_T_SIZE" is not defined, evaluates to 0 [-Werror=undef]
musdk/install/mv/include/env/mv_autogen_build_assert.h:44:2: error:
#error "MVCONF_DMA_PHYS_ADDR_T_SIZE must match size used during musdk_lib compilation."

The CFLAGS may be incomplete:
	Cflags: -I${includedir} -DMVCONF_TYPES_PUBLIC -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
I fixed it by adding:
	-DMVCONF_DMA_PHYS_ADDR_T_SIZE=64

Please could you fix MUSDK quickly?

I think I will pull next-net as is, but I consider it is broken.



  parent reply	other threads:[~2021-01-11 11:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 13:05 [dpdk-dev] [PATCH v1 0/2] armada: introduce musdk pkg-config lironh
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers lironh
2020-12-09 10:49   ` Ferruh Yigit
2020-12-13 20:06     ` [dpdk-dev] [EXT] " Liron Himi
2020-12-14  9:57       ` Ferruh Yigit
2020-12-15 10:04         ` Liron Himi
2020-12-15 10:29           ` Ferruh Yigit
2020-12-15 22:19   ` [dpdk-dev] [PATCH v2] " lironh
2020-12-15 22:23   ` lironh
2020-12-16 13:37     ` Ferruh Yigit
2020-12-16 13:41       ` [dpdk-dev] [EXT] " Liron Himi
2020-12-16 13:48         ` Ferruh Yigit
2020-12-16 21:15           ` Liron Himi
2020-12-16 13:52         ` Ferruh Yigit
2020-12-17 10:06           ` Luca Boccassi
2020-12-17 10:16             ` Ferruh Yigit
2020-12-16 21:36     ` [dpdk-dev] [PATCH v3] " lironh
2020-12-17 12:15       ` Ferruh Yigit
2021-01-11 11:28       ` Thomas Monjalon [this message]
2021-01-11 15:29         ` [dpdk-dev] [EXT] " Liron Himi
2021-01-11 16:05           ` Thomas Monjalon
2021-01-11 16:08             ` Liron Himi
2021-01-11 16:17               ` Thomas Monjalon
2021-01-11 17:07                 ` Bruce Richardson
2021-01-11 17:30                   ` Thomas Monjalon
2021-01-11 18:01                   ` Luca Boccassi
2021-01-11 17:04             ` Bruce Richardson
2021-01-11 17:06               ` Thomas Monjalon
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 2/2] doc: update armada docs lironh
2020-12-09 10:45   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2489984.pHaSLPtmOr@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=lironh@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.