Re: [dpdk-dev] [PATCH v2] meson: update meson build for armada drivers

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 12/15/2020 10:23 PM, lironh@marvell.com wrote:
> From: Liron Himi <lironh@marvell.com>
> 
> With pkg-config support available within musdk library
> (from musdk-release-SDK-10.3.5.0-PR2 version),
> meson option 'lib_musdk_dir' can be removed.
> PKG_CONFIG_PATH environment variable should be set appropriately
> to use the musdk library.

Hi Liron,

It is good change to get rid of an custom meson option, can we or should we 
backport this to the v20.11?

> 
> docs are updated with new musdk version and meson instructions.
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> ---
> v2:
> * include updated docs in this patch
> * add musdk version in commit message
> ---
>   doc/guides/nics/mvneta.rst         | 13 ++++++++-----
>   doc/guides/nics/mvpp2.rst          | 15 +++++++++------
>   drivers/common/mvep/meson.build    | 14 +++++---------
>   drivers/crypto/mvsam/meson.build   | 15 +++++----------

@Ahil, is it OK if I get this to the next-net, since logically related?

>   drivers/net/mvneta/meson.build     | 19 +++++--------------
>   drivers/net/mvneta/mvneta_ethdev.h |  1 +
>   drivers/net/mvpp2/meson.build      | 15 +++++----------
>   meson_options.txt                  |  2 --
>   8 files changed, 38 insertions(+), 56 deletions(-)
> 

<...>

> @@ -94,7 +94,7 @@ be passed as part of EAL arguments.
>       -c 3 -- -i --p 3 -a
>   
>   
> -Building DPDK
> +Building MUSDK
>   -------------
>   

This is giving doc warning because of "Title underline too short".

<...>

> @@ -108,7 +108,7 @@ Prerequisites
>     DPDK environment.
>   
>   
> -Building DPDK
> +Building MUSDK
>   -------------
>   

Ditto.

<...>

> diff --git a/drivers/net/mvneta/mvneta_ethdev.h b/drivers/net/mvneta/mvneta_ethdev.h
> index ef8067790..e090abc25 100644
> --- a/drivers/net/mvneta/mvneta_ethdev.h
> +++ b/drivers/net/mvneta/mvneta_ethdev.h
> @@ -21,6 +21,7 @@
>   #undef container_of
>   #endif
>   
> +#include <env/mv_autogen_comp_flags.h>

Is this include related with this patch?