From: Jon Hunter <jonathanh@nvidia.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathias Nyman <mathias.nyman@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org> Subject: Re: [PATCH V2 3/5] usb: xhci: tegra: Add genpd support Date: Fri, 12 Oct 2018 09:41:35 +0100 [thread overview] Message-ID: <248afd79-1a7d-7342-5939-6fa998d04d5b@nvidia.com> (raw) In-Reply-To: <20181011164753.GA7393@ulmo> On 11/10/18 17:47, Thierry Reding wrote: > On Fri, Sep 28, 2018 at 03:11:48PM +0100, Jon Hunter wrote: >> The generic power-domain framework has been updated to allow devices >> that require more than one power-domain to create a new device for >> each power-domain required and then link these new power-domain >> devices to the consumer device. >> >> Update the Tegra xHCI driver to use the new APIs provided by the >> generic power-domain framework so we can use the generic power-domain >> framework for managing the xHCI controllers power-domains. Please >> note that to maintain backward compatibility with older device-tree >> blobs these new generic power-domain APIs are only used if the >> 'power-domains' property is present and otherwise we fall back to >> using the legacy Tegra APIs for managing the power-domains. >> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> --- >> drivers/usb/host/xhci-tegra.c | 89 +++++++++++++++++++++++++++++++++++++------ >> 1 file changed, 77 insertions(+), 12 deletions(-) > > It'd be nice if we could eventually get rid of the legacy Tegra APIs, > but that's a separate issue, and this patch looks fine as-is: Unfortunately, I don't think it is possible as it will break DT backward compatibility. However, one way to do it would be to force on all power domains on boot if PM is not supported. > Acked-by: Thierry Reding <treding@nvidia.com> Thanks! Jon -- nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathias Nyman <mathias.nyman@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>, Ulf Hansson <ulf.hansson@linaro.org> Subject: Re: [PATCH V2 3/5] usb: xhci: tegra: Add genpd support Date: Fri, 12 Oct 2018 09:41:35 +0100 [thread overview] Message-ID: <248afd79-1a7d-7342-5939-6fa998d04d5b@nvidia.com> (raw) In-Reply-To: <20181011164753.GA7393@ulmo> On 11/10/18 17:47, Thierry Reding wrote: > On Fri, Sep 28, 2018 at 03:11:48PM +0100, Jon Hunter wrote: >> The generic power-domain framework has been updated to allow devices >> that require more than one power-domain to create a new device for >> each power-domain required and then link these new power-domain >> devices to the consumer device. >> >> Update the Tegra xHCI driver to use the new APIs provided by the >> generic power-domain framework so we can use the generic power-domain >> framework for managing the xHCI controllers power-domains. Please >> note that to maintain backward compatibility with older device-tree >> blobs these new generic power-domain APIs are only used if the >> 'power-domains' property is present and otherwise we fall back to >> using the legacy Tegra APIs for managing the power-domains. >> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> --- >> drivers/usb/host/xhci-tegra.c | 89 +++++++++++++++++++++++++++++++++++++------ >> 1 file changed, 77 insertions(+), 12 deletions(-) > > It'd be nice if we could eventually get rid of the legacy Tegra APIs, > but that's a separate issue, and this patch looks fine as-is: Unfortunately, I don't think it is possible as it will break DT backward compatibility. However, one way to do it would be to force on all power domains on boot if PM is not supported. > Acked-by: Thierry Reding <treding@nvidia.com> Thanks! Jon -- nvpublic
next prev parent reply other threads:[~2018-10-12 8:41 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-28 14:11 [PATCH V2 0/5] Tegra xHCI genpd support Jon Hunter 2018-09-28 14:11 ` Jon Hunter 2018-09-28 14:11 ` [PATCH V2 1/5] dt-bindings: usb: xhci-tegra: Add power-domain details Jon Hunter 2018-09-28 14:11 ` Jon Hunter 2018-10-11 16:49 ` Thierry Reding 2018-10-12 7:36 ` Jon Hunter 2018-10-12 7:36 ` Jon Hunter 2018-10-12 19:38 ` Rob Herring 2018-10-12 19:38 ` Rob Herring 2018-09-28 14:11 ` [PATCH V2 2/5] usb: xhci: tegra: Power-off power-domains on removal Jon Hunter 2018-09-28 14:11 ` Jon Hunter 2018-10-11 16:48 ` Thierry Reding 2018-09-28 14:11 ` [PATCH V2 3/5] usb: xhci: tegra: Add genpd support Jon Hunter 2018-09-28 14:11 ` Jon Hunter 2018-10-03 9:52 ` Ulf Hansson 2018-10-03 13:44 ` Jon Hunter 2018-10-03 13:44 ` Jon Hunter 2018-10-11 16:47 ` Thierry Reding 2018-10-12 8:41 ` Jon Hunter [this message] 2018-10-12 8:41 ` Jon Hunter 2018-10-12 10:27 ` Thierry Reding 2018-10-15 13:29 ` Ulf Hansson 2018-09-28 14:11 ` [PATCH V2 4/5] soc/tegra: pmc: Don't power-up XUSB power-domains Jon Hunter 2018-09-28 14:11 ` Jon Hunter 2018-10-11 16:50 ` Thierry Reding 2018-09-28 14:11 ` [PATCH V2 5/5] arm64: dts: tegra210: Add power-domains for xHCI Jon Hunter 2018-09-28 14:11 ` Jon Hunter 2018-10-11 16:51 ` Thierry Reding 2018-10-15 12:40 ` [PATCH V2 0/5] Tegra xHCI genpd support Jon Hunter 2018-10-15 12:40 ` Jon Hunter 2018-10-16 11:00 ` Mathias Nyman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=248afd79-1a7d-7342-5939-6fa998d04d5b@nvidia.com \ --to=jonathanh@nvidia.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathias.nyman@intel.com \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.