From: Juergen Gross <jgross@suse.com>
To: Shyam Saini <mayhs11saini@gmail.com>, boris.ostrovsky@oracle.com
Cc: xen-devel@lists.xenproject.org, david.vrabel@citrix.com
Subject: Re: [PATCH] xen: events: Replace BUG() with BUG_ON()
Date: Mon, 2 Jan 2017 06:09:42 +0100 [thread overview]
Message-ID: <248f0799-3f21-357d-581c-0a509996277d@suse.com> (raw)
In-Reply-To: <1482569566-6575-1-git-send-email-mayhs11saini@gmail.com>
On 24/12/16 09:52, Shyam Saini wrote:
> Replace BUG() with BUG_ON() using coccinelle
>
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
> ---
> drivers/xen/events/events_fifo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
> index c03f9c8..3c41470 100644
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -369,8 +369,7 @@ static void evtchn_fifo_resume(void)
> }
>
> ret = init_control_block(cpu, control_block);
> - if (ret < 0)
> - BUG();
> + BUG_ON(ret < 0);
> }
>
> /*
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-02 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 8:52 [PATCH] xen: events: Replace BUG() with BUG_ON() Shyam Saini
2017-01-02 5:09 ` Juergen Gross [this message]
2017-01-03 13:40 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248f0799-3f21-357d-581c-0a509996277d@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=mayhs11saini@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.