[PATCH] xen: events: Replace BUG() with BUG_ON()

[PATCH] xen: events: Replace BUG() with BUG_ON()

[Shyam Saini]

Replace BUG() with BUG_ON() using coccinelle

Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
---
 drivers/xen/events/events_fifo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
index c03f9c8..3c41470 100644
--- a/drivers/xen/events/events_fifo.c
+++ b/drivers/xen/events/events_fifo.c
@@ -369,8 +369,7 @@ static void evtchn_fifo_resume(void)
 		}
 
 		ret = init_control_block(cpu, control_block);
-		if (ret < 0)
-			BUG();
+		BUG_ON(ret < 0);
 	}
 
 	/*
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] xen: events: Replace BUG() with BUG_ON()

[Juergen Gross]

On 24/12/16 09:52, Shyam Saini wrote:
> Replace BUG() with BUG_ON() using coccinelle
> 
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
>  drivers/xen/events/events_fifo.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c
> index c03f9c8..3c41470 100644
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -369,8 +369,7 @@ static void evtchn_fifo_resume(void)
>  		}
>  
>  		ret = init_control_block(cpu, control_block);
> -		if (ret < 0)
> -			BUG();
> +		BUG_ON(ret < 0);
>  	}
>  
>  	/*
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] xen: events: Replace BUG() with BUG_ON()

[Juergen Gross]

On 24/12/16 09:52, Shyam Saini wrote:
> Replace BUG() with BUG_ON() using coccinelle
> 
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>

Committed to xen/tip.git for-linus-4.10


Thanks,

Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel