* [PATCH v2 0/2] Staging: wlan-ng: Remove unused functions
@ 2016-02-16 14:36 Bhumika Goyal
2016-02-16 14:36 ` [PATCH v2 1/2] Staging: wlan-ng: Remove function hfa384x_drvr_commtallies Bhumika Goyal
2016-02-16 14:36 ` [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async Bhumika Goyal
0 siblings, 2 replies; 7+ messages in thread
From: Bhumika Goyal @ 2016-02-16 14:36 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Bhumika Goyal
The functions hfa384x_drvr_commtallies and hfa384x_drvr_getconfig_async
are not used anywhere in the kernel so remove it.
Also remove the function prototypes from the header file.
Changes in v2:
* Combine patches 1 and 2 of v1 in a single patch to remove function
hfa384x_drvr_commtallies and its prototype.
* Combine patches 3 and 4 of v1 in a single patch to remove function
hfa384x_drvr_getconfig_async and its prototype .
Bhumika Goyal (2):
Staging: wlan-ng: Remove function hfa384x_drvr_commtallies
Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async
drivers/staging/wlan-ng/hfa384x.h | 5 ---
drivers/staging/wlan-ng/hfa384x_usb.c | 66 -----------------------------------
2 files changed, 71 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] Staging: wlan-ng: Remove function hfa384x_drvr_commtallies
2016-02-16 14:36 [PATCH v2 0/2] Staging: wlan-ng: Remove unused functions Bhumika Goyal
@ 2016-02-16 14:36 ` Bhumika Goyal
2016-02-16 14:56 ` [Outreachy kernel] " Arnd Bergmann
2016-02-16 14:36 ` [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async Bhumika Goyal
1 sibling, 1 reply; 7+ messages in thread
From: Bhumika Goyal @ 2016-02-16 14:36 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Bhumika Goyal
The function hfa384x_drvr_commtallies is not used anywhere in the kernel
so remove it. Also remove its prototype from the header file.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
Changes in v2:
* Combine patches 1 and 2 of v1 in a single patch to remove both the
function and its prototype.
drivers/staging/wlan-ng/hfa384x.h | 1 -
drivers/staging/wlan-ng/hfa384x_usb.c | 31 -------------------------------
2 files changed, 32 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 8dfe438..4fd3145 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1360,7 +1360,6 @@ void hfa384x_destroy(hfa384x_t *hw);
int
hfa384x_corereset(hfa384x_t *hw, int holdtime, int settletime, int genesis);
-int hfa384x_drvr_commtallies(hfa384x_t *hw);
int hfa384x_drvr_disable(hfa384x_t *hw, u16 macport);
int hfa384x_drvr_enable(hfa384x_t *hw, u16 macport);
int hfa384x_drvr_flashdl_enable(hfa384x_t *hw);
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 682de77..7eda536 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1747,37 +1747,6 @@ done:
}
/*----------------------------------------------------------------
-* hfa384x_drvr_commtallies
-*
-* Send a commtallies inquiry to the MAC. Note that this is an async
-* call that will result in an info frame arriving sometime later.
-*
-* Arguments:
-* hw device structure
-*
-* Returns:
-* zero success.
-*
-* Side effects:
-*
-* Call context:
-* process
-----------------------------------------------------------------*/
-int hfa384x_drvr_commtallies(hfa384x_t *hw)
-{
- hfa384x_metacmd_t cmd;
-
- cmd.cmd = HFA384x_CMDCODE_INQ;
- cmd.parm0 = HFA384x_IT_COMMTALLIES;
- cmd.parm1 = 0;
- cmd.parm2 = 0;
-
- hfa384x_docmd_async(hw, &cmd, NULL, NULL, NULL);
-
- return 0;
-}
-
-/*----------------------------------------------------------------
* hfa384x_drvr_disable
*
* Issues the disable command to stop communications on one of
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async
2016-02-16 14:36 [PATCH v2 0/2] Staging: wlan-ng: Remove unused functions Bhumika Goyal
2016-02-16 14:36 ` [PATCH v2 1/2] Staging: wlan-ng: Remove function hfa384x_drvr_commtallies Bhumika Goyal
@ 2016-02-16 14:36 ` Bhumika Goyal
2016-02-16 14:57 ` [Outreachy kernel] " Arnd Bergmann
2016-02-17 5:18 ` Sudip Mukherjee
1 sibling, 2 replies; 7+ messages in thread
From: Bhumika Goyal @ 2016-02-16 14:36 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Bhumika Goyal
The function hfa384x_drvr_getconfig_async is not used anywhere in the
kernel so remove it. Also remove its prototype from the header file.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
Changes in v2:
* Combine patches 3 and 4 of v1 in a single patch to remove both the
function and its prototype.
drivers/staging/wlan-ng/hfa384x.h | 4 ----
drivers/staging/wlan-ng/hfa384x_usb.c | 35 -----------------------------------
2 files changed, 39 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 4fd3145..cec6d0b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1390,10 +1390,6 @@ static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
}
int
-hfa384x_drvr_getconfig_async(hfa384x_t *hw,
- u16 rid, ctlx_usercb_t usercb, void *usercb_data);
-
-int
hfa384x_drvr_setconfig_async(hfa384x_t *hw,
u16 rid,
void *buf,
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 7eda536..ee63c64 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -2091,41 +2091,6 @@ int hfa384x_drvr_getconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len)
}
/*----------------------------------------------------------------
- * hfa384x_drvr_getconfig_async
- *
- * Performs the sequence necessary to perform an async read of
- * of a config/info item.
- *
- * Arguments:
- * hw device structure
- * rid config/info record id (host order)
- * buf host side record buffer. Upon return it will
- * contain the body portion of the record (minus the
- * RID and len).
- * len buffer length (in bytes, should match record length)
- * cbfn caller supplied callback, called when the command
- * is done (successful or not).
- * cbfndata pointer to some caller supplied data that will be
- * passed in as an argument to the cbfn.
- *
- * Returns:
- * nothing the cbfn gets a status argument identifying if
- * any errors occur.
- * Side effects:
- * Queues an hfa384x_usbcmd_t for subsequent execution.
- *
- * Call context:
- * Any
- ----------------------------------------------------------------*/
-int
-hfa384x_drvr_getconfig_async(hfa384x_t *hw,
- u16 rid, ctlx_usercb_t usercb, void *usercb_data)
-{
- return hfa384x_dorrid_async(hw, rid, NULL, 0,
- hfa384x_cb_rrid, usercb, usercb_data);
-}
-
-/*----------------------------------------------------------------
* hfa384x_drvr_setconfig_async
*
* Performs the sequence necessary to write a config/info item.
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 1/2] Staging: wlan-ng: Remove function hfa384x_drvr_commtallies
2016-02-16 14:36 ` [PATCH v2 1/2] Staging: wlan-ng: Remove function hfa384x_drvr_commtallies Bhumika Goyal
@ 2016-02-16 14:56 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2016-02-16 14:56 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Bhumika Goyal
On Tuesday 16 February 2016 20:06:58 Bhumika Goyal wrote:
> The function hfa384x_drvr_commtallies is not used anywhere in the kernel
> so remove it. Also remove its prototype from the header file.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async
2016-02-16 14:36 ` [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async Bhumika Goyal
@ 2016-02-16 14:57 ` Arnd Bergmann
2016-02-17 5:18 ` Sudip Mukherjee
1 sibling, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2016-02-16 14:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Bhumika Goyal
On Tuesday 16 February 2016 20:06:59 Bhumika Goyal wrote:
> The function hfa384x_drvr_getconfig_async is not used anywhere in the
> kernel so remove it. Also remove its prototype from the header file.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async
2016-02-16 14:36 ` [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async Bhumika Goyal
2016-02-16 14:57 ` [Outreachy kernel] " Arnd Bergmann
@ 2016-02-17 5:18 ` Sudip Mukherjee
2016-02-17 5:26 ` Bhumika Goyal
1 sibling, 1 reply; 7+ messages in thread
From: Sudip Mukherjee @ 2016-02-17 5:18 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: outreachy-kernel
On Tue, Feb 16, 2016 at 08:06:59PM +0530, Bhumika Goyal wrote:
> The function hfa384x_drvr_getconfig_async is not used anywhere in the
> kernel so remove it. Also remove its prototype from the header file.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Just replied to your v1. Didn't see your v2 at that time. Quoting here also:
This patch introduces new build warning -
drivers/staging/wlan-ng/hfa384x_usb.c:839:13: warning: ‘hfa384x_cb_rrid’ defined but not used
regards
sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async
2016-02-17 5:18 ` Sudip Mukherjee
@ 2016-02-17 5:26 ` Bhumika Goyal
0 siblings, 0 replies; 7+ messages in thread
From: Bhumika Goyal @ 2016-02-17 5:26 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: outreachy-kernel
On Wed, Feb 17, 2016 at 10:48 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Tue, Feb 16, 2016 at 08:06:59PM +0530, Bhumika Goyal wrote:
>> The function hfa384x_drvr_getconfig_async is not used anywhere in the
>> kernel so remove it. Also remove its prototype from the header file.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>> ---
>
> Just replied to your v1. Didn't see your v2 at that time. Quoting here also:
> This patch introduces new build warning -
> drivers/staging/wlan-ng/hfa384x_usb.c:839:13: warning: ‘hfa384x_cb_rrid’ defined but not used
>
> regards
> sudip
Thank you for the input. I will send a v3 after removing hfa384x_cb_rrid.
Thank you
Bhumika
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-17 5:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-16 14:36 [PATCH v2 0/2] Staging: wlan-ng: Remove unused functions Bhumika Goyal
2016-02-16 14:36 ` [PATCH v2 1/2] Staging: wlan-ng: Remove function hfa384x_drvr_commtallies Bhumika Goyal
2016-02-16 14:56 ` [Outreachy kernel] " Arnd Bergmann
2016-02-16 14:36 ` [PATCH v2 2/2] Staging: wlan-ng: Remove function hfa384x_drvr_getconfig_async Bhumika Goyal
2016-02-16 14:57 ` [Outreachy kernel] " Arnd Bergmann
2016-02-17 5:18 ` Sudip Mukherjee
2016-02-17 5:26 ` Bhumika Goyal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.