Re: [PATCH] drm/amdgpu: Fix a bug that vm size is wrong on Raven

From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Yong Zhao <yong.zhao-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: Fix a bug that vm size is wrong on Raven
Date: Thu, 14 Dec 2017 09:47:35 +0100	[thread overview]
Message-ID: <24c4613c-ed30-2ac3-cca2-4aec5dd707d5@gmail.com> (raw)
In-Reply-To: <1513218350-29030-1-git-send-email-yong.zhao-5C7GfCeVMHo@public.gmane.org>

NAK, that really circumvents the intention of the patch to adjust the 
number of levels based on the vm_size.

Christian.

Am 14.12.2017 um 03:25 schrieb Yong Zhao:
> Change-Id: Id522c1cbadb8c069720f4e64a31cff42cd014733
> Signed-off-by: Yong Zhao <yong.zhao@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 709587d..3b9eb1a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2534,7 +2534,7 @@ void amdgpu_vm_adjust_size(struct amdgpu_device *adev, uint32_t vm_size,
>   	uint64_t tmp;
>   
>   	/* adjust vm size first */
> -	if (amdgpu_vm_size != -1) {
> +	if (amdgpu_vm_size != -1 && max_level == 1) {
>   		unsigned max_size = 1 << (max_bits - 30);
>   
>   		vm_size = amdgpu_vm_size;

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx