Re: [PATCH] drm/amdgpu: Fix a bug that vm size is wrong on Raven

From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Felix Kühling"
	<felix.kuehling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Yong Zhao" <yong.zhao-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: Fix a bug that vm size is wrong on Raven
Date: Mon, 18 Dec 2017 10:22:43 +0100	[thread overview]
Message-ID: <e3d20771-df70-b9e5-345b-9914c54db292@gmail.com> (raw)
In-Reply-To: <9ebd38b5-2b12-8797-65e5-3a920ce697aa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 1733 bytes --]

The problem was a merge conflict.

No idea what exactly went wrong, but Yong ended up with a branch where 
the vm_size was always overwritten with the value 64.

So we can completely drop this patch and yes when an user overrides the 
vm_size value he/she should know what the consequences are.

Regards,
Christian.

Am 17.12.2017 um 00:21 schrieb Felix Kühling:
> Is there a way to override the VM size for KFD VMs only? Only they
> depend on ATS, so only they need to be forced to be 48-bits.
>
> On the other hand, it could be argued that a user who manually sets the
> VM size with a module parameter knows what they're doing. So let them
> break ATS.
>
> Regards,
>    Felix
>
>
> Am 14.12.2017 um 17:45 schrieb Yong Zhao:
>> Change-Id: Id522c1cbadb8c069720f4e64a31cff42cd014733
>> Signed-off-by: Yong Zhao <yong.zhao-5C7GfCeVMHo@public.gmane.org>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 709587d..93500e6 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -2534,7 +2534,7 @@ void amdgpu_vm_adjust_size(struct amdgpu_device *adev, uint32_t vm_size,
>>   	uint64_t tmp;
>>   
>>   	/* adjust vm size first */
>> -	if (amdgpu_vm_size != -1) {
>> +	if (amdgpu_vm_size != -1 && adev->asic_type != CHIP_RAVEN) {
>>   		unsigned max_size = 1 << (max_bits - 30);
>>   
>>   		vm_size = amdgpu_vm_size;
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 2657 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx