* [XEN PATCH] automation/eclair_analysis: substitute deprecated service
@ 2024-04-17 14:51 Nicola Vetrini
2024-04-17 14:57 ` Julien Grall
2024-04-18 7:22 ` Jan Beulich
0 siblings, 2 replies; 8+ messages in thread
From: Nicola Vetrini @ 2024-04-17 14:51 UTC (permalink / raw)
To: xen-devel, nicola.vetrini
Cc: sstabellini, michal.orzel, xenia.ragiadakou, ayan.kumar.halder,
consulting, bertrand.marquis, julien, Simone Ballarin,
Doug Goldstein
The service STD.emptrecd is in the process of being removed in favour
of STD.anonstct.
No functional change.
Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl b/automation/eclair_analysis/ECLAIR/toolchain.ecl
index 71a1e2cce029..86e9a79b5231 100644
--- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
+++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
@@ -44,8 +44,8 @@
-doc_end
-doc_begin="See Section \"6.19 Structures with No Members\" of "GCC_MANUAL"."
--config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
--config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
+-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
+-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
-doc_end
-doc_begin="See Section \"6.18 Arrays of Length Zero\" of "GCC_MANUAL"."
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-17 14:51 [XEN PATCH] automation/eclair_analysis: substitute deprecated service Nicola Vetrini
@ 2024-04-17 14:57 ` Julien Grall
2024-04-17 15:05 ` Nicola Vetrini
2024-04-18 7:22 ` Jan Beulich
1 sibling, 1 reply; 8+ messages in thread
From: Julien Grall @ 2024-04-17 14:57 UTC (permalink / raw)
To: Nicola Vetrini, xen-devel
Cc: sstabellini, michal.orzel, xenia.ragiadakou, ayan.kumar.halder,
consulting, bertrand.marquis, Simone Ballarin, Doug Goldstein
Hi Nicola,
On 17/04/2024 15:51, Nicola Vetrini wrote:
> The service STD.emptrecd is in the process of being removed in favour
> of STD.anonstct.
I am guessing this is not a new feature and the current ECLAIR version
is supporting it?
Cheers,
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> ---
> automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> index 71a1e2cce029..86e9a79b5231 100644
> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> @@ -44,8 +44,8 @@
> -doc_end
>
> -doc_begin="See Section \"6.19 Structures with No Members\" of "GCC_MANUAL"."
> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
> -doc_end
>
> -doc_begin="See Section \"6.18 Arrays of Length Zero\" of "GCC_MANUAL"."
--
Julien Grall
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-17 14:57 ` Julien Grall
@ 2024-04-17 15:05 ` Nicola Vetrini
2024-04-17 15:50 ` Julien Grall
0 siblings, 1 reply; 8+ messages in thread
From: Nicola Vetrini @ 2024-04-17 15:05 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel, sstabellini, michal.orzel, xenia.ragiadakou,
ayan.kumar.halder, consulting, bertrand.marquis, Simone Ballarin,
Doug Goldstein
On 2024-04-17 16:57, Julien Grall wrote:
> Hi Nicola,
>
> On 17/04/2024 15:51, Nicola Vetrini wrote:
>> The service STD.emptrecd is in the process of being removed in favour
>> of STD.anonstct.
>
> I am guessing this is not a new feature and the current ECLAIR version
> is supporting it?
>
> Cheers,
>
Yes, it was just an oversight to leave the old emptrcd there. It will
eventually be phased out in the next release.
>>
>> No functional change.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>> ---
>> automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> index 71a1e2cce029..86e9a79b5231 100644
>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> @@ -44,8 +44,8 @@
>> -doc_end
>> -doc_begin="See Section \"6.19 Structures with No Members\" of
>> "GCC_MANUAL"."
>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>> -doc_end
>> -doc_begin="See Section \"6.18 Arrays of Length Zero\" of
>> "GCC_MANUAL"."
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-17 15:05 ` Nicola Vetrini
@ 2024-04-17 15:50 ` Julien Grall
0 siblings, 0 replies; 8+ messages in thread
From: Julien Grall @ 2024-04-17 15:50 UTC (permalink / raw)
To: Nicola Vetrini
Cc: xen-devel, sstabellini, michal.orzel, xenia.ragiadakou,
ayan.kumar.halder, consulting, bertrand.marquis, Simone Ballarin,
Doug Goldstein
On 17/04/2024 16:05, Nicola Vetrini wrote:
> On 2024-04-17 16:57, Julien Grall wrote:
>> Hi Nicola,
>>
>> On 17/04/2024 15:51, Nicola Vetrini wrote:
>>> The service STD.emptrecd is in the process of being removed in favour
>>> of STD.anonstct.
>>
>> I am guessing this is not a new feature and the current ECLAIR version
>> is supporting it?
>>
>> Cheers,
>>
>
> Yes, it was just an oversight to leave the old emptrcd there. It will
> eventually be phased out in the next release.
Thanks for confirming!
I don't have a way to test ECLAIR or any knowledge. But if you need an ack:
Acked-by: Julien Grall <jgrall@amazon.com>
Cheers,
>
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>>> ---
>>> automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> index 71a1e2cce029..86e9a79b5231 100644
>>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> @@ -44,8 +44,8 @@
>>> -doc_end
>>> -doc_begin="See Section \"6.19 Structures with No Members\" of
>>> "GCC_MANUAL"."
>>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>> -doc_end
>>> -doc_begin="See Section \"6.18 Arrays of Length Zero\" of
>>> "GCC_MANUAL"."
>
--
Julien Grall
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-17 14:51 [XEN PATCH] automation/eclair_analysis: substitute deprecated service Nicola Vetrini
2024-04-17 14:57 ` Julien Grall
@ 2024-04-18 7:22 ` Jan Beulich
2024-04-18 15:00 ` Nicola Vetrini
1 sibling, 1 reply; 8+ messages in thread
From: Jan Beulich @ 2024-04-18 7:22 UTC (permalink / raw)
To: Nicola Vetrini
Cc: sstabellini, michal.orzel, xenia.ragiadakou, ayan.kumar.halder,
consulting, bertrand.marquis, julien, Simone Ballarin,
Doug Goldstein, xen-devel
On 17.04.2024 16:51, Nicola Vetrini wrote:
> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> @@ -44,8 +44,8 @@
> -doc_end
>
> -doc_begin="See Section \"6.19 Structures with No Members\" of "GCC_MANUAL"."
> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
> -doc_end
I'm irritated by this, which may be in part because of too terse a description.
"emptrecd" looks like an abbreviation of "empty record" to me, in line with
"Structures with No Members". "anonstct" otoh looks an abbreviation of
"anonymous structures" to me, which is something different (structures without
names).
Jan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-18 7:22 ` Jan Beulich
@ 2024-04-18 15:00 ` Nicola Vetrini
2024-04-18 15:15 ` Jan Beulich
0 siblings, 1 reply; 8+ messages in thread
From: Nicola Vetrini @ 2024-04-18 15:00 UTC (permalink / raw)
To: Jan Beulich
Cc: sstabellini, michal.orzel, xenia.ragiadakou, ayan.kumar.halder,
consulting, bertrand.marquis, julien, Simone Ballarin,
Doug Goldstein, xen-devel
On 2024-04-18 09:22, Jan Beulich wrote:
> On 17.04.2024 16:51, Nicola Vetrini wrote:
>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> @@ -44,8 +44,8 @@
>> -doc_end
>>
>> -doc_begin="See Section \"6.19 Structures with No Members\" of
>> "GCC_MANUAL"."
>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>> -doc_end
>
> I'm irritated by this, which may be in part because of too terse a
> description.
> "emptrecd" looks like an abbreviation of "empty record" to me, in line
> with
> "Structures with No Members". "anonstct" otoh looks an abbreviation of
> "anonymous structures" to me, which is something different (structures
> without
> names).
>
> Jan
I'm afraid I can't do much about this. From a functionality standpoint
there is no difference for Xen.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-18 15:00 ` Nicola Vetrini
@ 2024-04-18 15:15 ` Jan Beulich
2024-04-18 19:49 ` Nicola Vetrini
0 siblings, 1 reply; 8+ messages in thread
From: Jan Beulich @ 2024-04-18 15:15 UTC (permalink / raw)
To: Nicola Vetrini
Cc: sstabellini, michal.orzel, xenia.ragiadakou, ayan.kumar.halder,
consulting, bertrand.marquis, julien, Simone Ballarin,
Doug Goldstein, xen-devel
On 18.04.2024 17:00, Nicola Vetrini wrote:
> On 2024-04-18 09:22, Jan Beulich wrote:
>> On 17.04.2024 16:51, Nicola Vetrini wrote:
>>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> @@ -44,8 +44,8 @@
>>> -doc_end
>>>
>>> -doc_begin="See Section \"6.19 Structures with No Members\" of
>>> "GCC_MANUAL"."
>>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>> -doc_end
>>
>> I'm irritated by this, which may be in part because of too terse a
>> description.
>> "emptrecd" looks like an abbreviation of "empty record" to me, in line
>> with
>> "Structures with No Members". "anonstct" otoh looks an abbreviation of
>> "anonymous structures" to me, which is something different (structures
>> without
>> names).
>
> I'm afraid I can't do much about this. From a functionality standpoint
> there is no difference for Xen.
What I'm pretty sure you can do is provide a patch description that
allows readers to understand anything seemingly (or actually) anomalous.
Jan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
2024-04-18 15:15 ` Jan Beulich
@ 2024-04-18 19:49 ` Nicola Vetrini
0 siblings, 0 replies; 8+ messages in thread
From: Nicola Vetrini @ 2024-04-18 19:49 UTC (permalink / raw)
To: Jan Beulich
Cc: sstabellini, michal.orzel, xenia.ragiadakou, ayan.kumar.halder,
consulting, bertrand.marquis, julien, Simone Ballarin,
Doug Goldstein, xen-devel
On 2024-04-18 17:15, Jan Beulich wrote:
> On 18.04.2024 17:00, Nicola Vetrini wrote:
>> On 2024-04-18 09:22, Jan Beulich wrote:
>>> On 17.04.2024 16:51, Nicola Vetrini wrote:
>>>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>>> @@ -44,8 +44,8 @@
>>>> -doc_end
>>>>
>>>> -doc_begin="See Section \"6.19 Structures with No Members\" of
>>>> "GCC_MANUAL"."
>>>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>>>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>>>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>>>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>>> -doc_end
>>>
>>> I'm irritated by this, which may be in part because of too terse a
>>> description.
>>> "emptrecd" looks like an abbreviation of "empty record" to me, in
>>> line
>>> with
>>> "Structures with No Members". "anonstct" otoh looks an abbreviation
>>> of
>>> "anonymous structures" to me, which is something different
>>> (structures
>>> without
>>> names).
>>
>> I'm afraid I can't do much about this. From a functionality standpoint
>> there is no difference for Xen.
>
> What I'm pretty sure you can do is provide a patch description that
> allows readers to understand anything seemingly (or actually)
> anomalous.
>
> Jan
Ok
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-04-18 19:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 14:51 [XEN PATCH] automation/eclair_analysis: substitute deprecated service Nicola Vetrini
2024-04-17 14:57 ` Julien Grall
2024-04-17 15:05 ` Nicola Vetrini
2024-04-17 15:50 ` Julien Grall
2024-04-18 7:22 ` Jan Beulich
2024-04-18 15:00 ` Nicola Vetrini
2024-04-18 15:15 ` Jan Beulich
2024-04-18 19:49 ` Nicola Vetrini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.