From: Schrempf Frieder <frieder.schrempf@exceet.de> To: Rob Herring <robh@kernel.org> Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>, "pawel.moll@arm.com" <pawel.moll@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, "galak@codeaurora.org" <galak@codeaurora.org>, "luis@debethencourt.com" <luis@debethencourt.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 2/3] input: pwm-beeper: add documentation for volume devicetree bindings Date: Tue, 11 Oct 2016 08:17:24 +0000 [thread overview] Message-ID: <24e35d49-7c3d-b094-f0b7-96367389f249@exceet.de> (raw) In-Reply-To: <20161010152055.GA6868@rob-hp-laptop> On 10.10.2016 17:20, Rob Herring wrote: > On Fri, Oct 07, 2016 at 09:08:17AM +0000, Schrempf Frieder wrote: >> This patch adds the documentation for the devicetree bindings to set >> the volume levels. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de> >> --- >> Changes in v2: >> - split into 3 separate patches >> - make volume properties optional >> >> .../devicetree/bindings/input/pwm-beeper.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt >> index be332ae..6d8ba4e 100644 >> --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt >> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt >> @@ -5,3 +5,25 @@ Registers a PWM device as beeper. >> Required properties: >> - compatible: should be "pwm-beeper" >> - pwms: phandle to the physical PWM device >> + >> +Optional properties: >> +- volume-levels: Array of distinct volume levels. These need to be in the >> + range of 0 to 500, while 0 means 0% duty cycle (mute) and 500 means >> + 50% duty cycle (max volume). >> + Please note that the actual volume of most beepers is highly >> + non-linear, which means that low volume levels are probably somewhere >> + in the range of 1 to 30 (0.1-3% duty cycle). > > What does the index correspond to? The linear volume? In most cases users probably need linear volume levels (e.g. 0%, 25%, 50%, 75%, 100%) and in this case the index would indeed correspond to the linear perceived volume. But also non-linear relations are possible (e.g. 0%, 20%, 100%), if the user needs for example "mute", "low", "high" as volume levels. The linearization (defining the corresponding duty cycle for each index) depends on the beeper and the perception of the user. For the example array definition below, I tried different duty cycles and found values of 0.8%, 2%, 4%, 50% to be approximately correspondent to perceived volume levels of 25%, 50%, 75%, 100% in my case. > >> +- default-volume-level: the default volume level (index into the >> + array defined by the "volume-levels" property) >> + >> +The volume level can be set via sysfs under /sys/class/input/inputX/volume. >> +The maximum volume level index can be read from /sys/class/input/inputX/max_volume_level. >> + >> +Example: >> + >> + pwm-beeper { >> + compatible = "pwm-beeper"; >> + pwms = <&pwm4 0 5000>; >> + volume-levels = <0 8 20 40 500>; >> + default-volume-level = <4>; >> + }; >> -- >> 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Schrempf Frieder <frieder.schrempf-wPoT/lNZgHizQB+pC5nmwQ@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "pawel.moll-5wv7dgnIgG8@public.gmane.org" <pawel.moll-5wv7dgnIgG8@public.gmane.org>, "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, "luis-HiykPkW1eAzzDCI4PIEvbQC/G2K4zDHf@public.gmane.org" <luis-HiykPkW1eAzzDCI4PIEvbQC/G2K4zDHf@public.gmane.org>, "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v2 2/3] input: pwm-beeper: add documentation for volume devicetree bindings Date: Tue, 11 Oct 2016 08:17:24 +0000 [thread overview] Message-ID: <24e35d49-7c3d-b094-f0b7-96367389f249@exceet.de> (raw) In-Reply-To: <20161010152055.GA6868@rob-hp-laptop> On 10.10.2016 17:20, Rob Herring wrote: > On Fri, Oct 07, 2016 at 09:08:17AM +0000, Schrempf Frieder wrote: >> This patch adds the documentation for the devicetree bindings to set >> the volume levels. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf-wPoT/lNZgHizQB+pC5nmwQ@public.gmane.org> >> --- >> Changes in v2: >> - split into 3 separate patches >> - make volume properties optional >> >> .../devicetree/bindings/input/pwm-beeper.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt >> index be332ae..6d8ba4e 100644 >> --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt >> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt >> @@ -5,3 +5,25 @@ Registers a PWM device as beeper. >> Required properties: >> - compatible: should be "pwm-beeper" >> - pwms: phandle to the physical PWM device >> + >> +Optional properties: >> +- volume-levels: Array of distinct volume levels. These need to be in the >> + range of 0 to 500, while 0 means 0% duty cycle (mute) and 500 means >> + 50% duty cycle (max volume). >> + Please note that the actual volume of most beepers is highly >> + non-linear, which means that low volume levels are probably somewhere >> + in the range of 1 to 30 (0.1-3% duty cycle). > > What does the index correspond to? The linear volume? In most cases users probably need linear volume levels (e.g. 0%, 25%, 50%, 75%, 100%) and in this case the index would indeed correspond to the linear perceived volume. But also non-linear relations are possible (e.g. 0%, 20%, 100%), if the user needs for example "mute", "low", "high" as volume levels. The linearization (defining the corresponding duty cycle for each index) depends on the beeper and the perception of the user. For the example array definition below, I tried different duty cycles and found values of 0.8%, 2%, 4%, 50% to be approximately correspondent to perceived volume levels of 25%, 50%, 75%, 100% in my case. > >> +- default-volume-level: the default volume level (index into the >> + array defined by the "volume-levels" property) >> + >> +The volume level can be set via sysfs under /sys/class/input/inputX/volume. >> +The maximum volume level index can be read from /sys/class/input/inputX/max_volume_level. >> + >> +Example: >> + >> + pwm-beeper { >> + compatible = "pwm-beeper"; >> + pwms = <&pwm4 0 5000>; >> + volume-levels = <0 8 20 40 500>; >> + default-volume-level = <4>; >> + }; >> -- >> 1.9.1-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-11 8:18 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-07 15:58 [PATCH 1/1] input: pwm-beeper: add feature to set volume via sysfs Schrempf Frieder 2016-04-07 15:58 ` Schrempf Frieder 2016-04-11 15:21 ` Rob Herring 2016-04-11 15:21 ` Rob Herring 2016-10-07 9:00 ` Schrempf Frieder 2016-10-07 9:00 ` Schrempf Frieder 2016-10-07 9:08 ` [PATCH v2 0/3] input: pwm-beeper: add feature to set volume level Schrempf Frieder 2016-10-07 9:08 ` [PATCH v2 1/3] input: pwm-beeper: add feature to set volume via sysfs Schrempf Frieder 2016-10-07 9:08 ` [PATCH v2 2/3] input: pwm-beeper: add documentation for volume devicetree bindings Schrempf Frieder 2016-10-07 9:08 ` Schrempf Frieder 2016-10-10 15:20 ` Rob Herring 2016-10-10 15:20 ` Rob Herring 2016-10-11 8:17 ` Schrempf Frieder [this message] 2016-10-11 8:17 ` Schrempf Frieder 2016-10-11 13:39 ` Rob Herring 2017-01-19 14:40 ` Frieder Schrempf 2017-01-19 15:24 ` [PATCH v3 0/3] input: pwm-beeper: add feature to set volume level Frieder Schrempf 2017-01-19 15:24 ` Frieder Schrempf 2017-01-19 15:24 ` [PATCH v3 1/3] input: pwm-beeper: add feature to set volume via sysfs Frieder Schrempf 2017-01-19 15:24 ` Frieder Schrempf 2017-01-19 21:29 ` Dmitry Torokhov 2017-01-19 21:29 ` Dmitry Torokhov 2017-02-16 20:37 ` Frieder Schrempf 2017-02-16 20:37 ` Frieder Schrempf 2017-01-19 15:24 ` [PATCH v3 2/3] input: pwm-beeper: add documentation for volume devicetree bindings Frieder Schrempf 2017-01-19 15:24 ` Frieder Schrempf 2017-01-23 14:40 ` Rob Herring 2017-01-23 14:40 ` Rob Herring 2017-01-19 15:24 ` [PATCH v3 3/3] input: pwm-beeper: add devicetree bindings to set volume levels Frieder Schrempf 2017-01-19 15:24 ` Frieder Schrempf 2017-01-19 21:30 ` Dmitry Torokhov 2017-02-16 20:40 ` Frieder Schrempf 2017-02-16 20:40 ` Frieder Schrempf 2017-01-19 21:37 ` [PATCH v3 0/3] input: pwm-beeper: add feature to set volume level Dmitry Torokhov 2017-01-20 19:11 ` David Lechner 2017-02-16 21:15 ` Frieder Schrempf 2017-02-16 21:15 ` Frieder Schrempf 2017-02-16 21:44 ` David Lechner 2017-02-16 21:44 ` David Lechner 2017-02-17 10:01 ` Frieder Schrempf 2017-02-17 10:01 ` Frieder Schrempf 2017-02-16 21:08 ` [PATCH v4 " Frieder Schrempf 2017-02-16 21:08 ` Frieder Schrempf 2017-02-16 21:08 ` [PATCH v4 1/3] input: pwm-beeper: add feature to set volume via sysfs Frieder Schrempf 2017-02-16 21:08 ` Frieder Schrempf 2017-02-16 21:08 ` [PATCH v4 2/3] input: pwm-beeper: add documentation for volume devicetree bindings Frieder Schrempf 2017-02-16 21:08 ` Frieder Schrempf 2017-02-16 21:08 ` [PATCH v4 3/3] input: pwm-beeper: add devicetree bindings to set volume levels Frieder Schrempf 2017-02-16 21:08 ` Frieder Schrempf 2017-02-16 23:07 ` kbuild test robot 2017-02-16 23:07 ` kbuild test robot 2017-02-17 0:14 ` kbuild test robot 2017-02-17 0:14 ` kbuild test robot 2017-02-17 9:54 ` [PATCH v5 0/3] input: pwm-beeper: add feature to set volume level Frieder Schrempf 2017-02-17 9:54 ` Frieder Schrempf 2017-02-17 9:54 ` [PATCH v5 1/3] input: pwm-beeper: add feature to set volume via sysfs Frieder Schrempf 2017-02-17 9:54 ` Frieder Schrempf 2017-02-17 9:54 ` [PATCH v5 2/3] input: pwm-beeper: add documentation for volume devicetree bindings Frieder Schrempf 2017-02-17 9:54 ` Frieder Schrempf 2017-02-17 9:54 ` [PATCH v5 3/3] input: pwm-beeper: add devicetree bindings to set volume levels Frieder Schrempf 2017-02-17 9:54 ` Frieder Schrempf 2016-10-07 9:08 ` [PATCH v2 " Schrempf Frieder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=24e35d49-7c3d-b094-f0b7-96367389f249@exceet.de \ --to=frieder.schrempf@exceet.de \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luis@debethencourt.com \ --cc=pawel.moll@arm.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.