* [PATCH 1/2] vicodec: Drop unneeded symbol dependency
@ 2018-09-10 15:21 Ezequiel Garcia
2018-09-10 15:21 ` [PATCH 2/2] vicodec: Drop unused job_abort() Ezequiel Garcia
2018-09-10 15:23 ` [PATCH 1/2] vicodec: Drop unneeded symbol dependency Hans Verkuil
0 siblings, 2 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2018-09-10 15:21 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil, Ezequiel Garcia
The vicodec doesn't use the Subdev API, so drop the dependency.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
drivers/media/platform/vicodec/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig
index 2503bcb1529f..ad13329e3461 100644
--- a/drivers/media/platform/vicodec/Kconfig
+++ b/drivers/media/platform/vicodec/Kconfig
@@ -1,6 +1,6 @@
config VIDEO_VICODEC
tristate "Virtual Codec Driver"
- depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
+ depends on VIDEO_DEV && VIDEO_V4L2
select VIDEOBUF2_VMALLOC
select V4L2_MEM2MEM_DEV
default n
--
2.19.0.rc2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] vicodec: Drop unused job_abort()
2018-09-10 15:21 [PATCH 1/2] vicodec: Drop unneeded symbol dependency Ezequiel Garcia
@ 2018-09-10 15:21 ` Ezequiel Garcia
2018-09-10 15:23 ` [PATCH 1/2] vicodec: Drop unneeded symbol dependency Hans Verkuil
1 sibling, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2018-09-10 15:21 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil, Ezequiel Garcia
The vicodec does not use the aborting field. In fact, this driver
can't really cancel any work, since it performs all the work
in device_run().
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
drivers/media/platform/vicodec/vicodec-core.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
index bbc48fcaa563..8d455c42163e 100644
--- a/drivers/media/platform/vicodec/vicodec-core.c
+++ b/drivers/media/platform/vicodec/vicodec-core.c
@@ -112,8 +112,6 @@ struct vicodec_ctx {
struct v4l2_ctrl_handler hdl;
- /* Abort requested by m2m */
- int aborting;
struct vb2_v4l2_buffer *last_src_buf;
struct vb2_v4l2_buffer *last_dst_buf;
@@ -376,14 +374,6 @@ static int job_ready(void *priv)
return 1;
}
-static void job_abort(void *priv)
-{
- struct vicodec_ctx *ctx = priv;
-
- /* Will cancel the transaction in the next interrupt handler */
- ctx->aborting = 1;
-}
-
/*
* video ioctls
*/
@@ -1268,7 +1258,6 @@ static const struct video_device vicodec_videodev = {
static const struct v4l2_m2m_ops m2m_ops = {
.device_run = device_run,
- .job_abort = job_abort,
.job_ready = job_ready,
};
--
2.19.0.rc2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency
2018-09-10 15:21 [PATCH 1/2] vicodec: Drop unneeded symbol dependency Ezequiel Garcia
2018-09-10 15:21 ` [PATCH 2/2] vicodec: Drop unused job_abort() Ezequiel Garcia
@ 2018-09-10 15:23 ` Hans Verkuil
2018-09-10 15:44 ` Ezequiel Garcia
1 sibling, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2018-09-10 15:23 UTC (permalink / raw)
To: Ezequiel Garcia, linux-media
On 09/10/2018 05:21 PM, Ezequiel Garcia wrote:
> The vicodec doesn't use the Subdev API, so drop the dependency.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/media/platform/vicodec/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig
> index 2503bcb1529f..ad13329e3461 100644
> --- a/drivers/media/platform/vicodec/Kconfig
> +++ b/drivers/media/platform/vicodec/Kconfig
> @@ -1,6 +1,6 @@
> config VIDEO_VICODEC
> tristate "Virtual Codec Driver"
> - depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
But it definitely needs the MEDIA_CONTROLLER. That's what it should depend on.
Regards,
Hans
> + depends on VIDEO_DEV && VIDEO_V4L2
> select VIDEOBUF2_VMALLOC
> select V4L2_MEM2MEM_DEV
> default n
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency
2018-09-10 15:23 ` [PATCH 1/2] vicodec: Drop unneeded symbol dependency Hans Verkuil
@ 2018-09-10 15:44 ` Ezequiel Garcia
2018-09-10 15:51 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Ezequiel Garcia @ 2018-09-10 15:44 UTC (permalink / raw)
To: Hans Verkuil, linux-media
On Mon, 2018-09-10 at 17:23 +0200, Hans Verkuil wrote:
> On 09/10/2018 05:21 PM, Ezequiel Garcia wrote:
> > The vicodec doesn't use the Subdev API, so drop the dependency.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > drivers/media/platform/vicodec/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig
> > index 2503bcb1529f..ad13329e3461 100644
> > --- a/drivers/media/platform/vicodec/Kconfig
> > +++ b/drivers/media/platform/vicodec/Kconfig
> > @@ -1,6 +1,6 @@
> > config VIDEO_VICODEC
> > tristate "Virtual Codec Driver"
> > - depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
>
> But it definitely needs the MEDIA_CONTROLLER. That's what it should depend on.
>
Does it really? The code have proper ifdefs.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency
2018-09-10 15:44 ` Ezequiel Garcia
@ 2018-09-10 15:51 ` Hans Verkuil
0 siblings, 0 replies; 5+ messages in thread
From: Hans Verkuil @ 2018-09-10 15:51 UTC (permalink / raw)
To: Ezequiel Garcia, linux-media
On 09/10/2018 05:44 PM, Ezequiel Garcia wrote:
> On Mon, 2018-09-10 at 17:23 +0200, Hans Verkuil wrote:
>> On 09/10/2018 05:21 PM, Ezequiel Garcia wrote:
>>> The vicodec doesn't use the Subdev API, so drop the dependency.
>>>
>>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>>> ---
>>> drivers/media/platform/vicodec/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig
>>> index 2503bcb1529f..ad13329e3461 100644
>>> --- a/drivers/media/platform/vicodec/Kconfig
>>> +++ b/drivers/media/platform/vicodec/Kconfig
>>> @@ -1,6 +1,6 @@
>>> config VIDEO_VICODEC
>>> tristate "Virtual Codec Driver"
>>> - depends on VIDEO_DEV && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
>>
>> But it definitely needs the MEDIA_CONTROLLER. That's what it should depend on.
>>
>
> Does it really? The code have proper ifdefs.
>
You are right, it is not needed now, but will be when stateless codec support
is added to vicodec in the future.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-10 20:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 15:21 [PATCH 1/2] vicodec: Drop unneeded symbol dependency Ezequiel Garcia
2018-09-10 15:21 ` [PATCH 2/2] vicodec: Drop unused job_abort() Ezequiel Garcia
2018-09-10 15:23 ` [PATCH 1/2] vicodec: Drop unneeded symbol dependency Hans Verkuil
2018-09-10 15:44 ` Ezequiel Garcia
2018-09-10 15:51 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.