* [PATCH] xen/x86: obtain full video frame buffer address for Dom0 also under EFI
@ 2022-02-07 7:41 Jan Beulich
2022-02-07 8:53 ` Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-02-07 7:41 UTC (permalink / raw)
To: Juergen Gross, Boris Ostrovsky; +Cc: xen-devel, lkml
The initial change would not work when Xen was booted from EFI: There is
an early exit from the case block in that case. Move the necessary code
ahead of that.
Fixes: 335e4dd67b48 ("xen/x86: obtain upper 32 bits of video frame buffer address for Dom0")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/arch/x86/xen/vga.c
+++ b/arch/x86/xen/vga.c
@@ -57,6 +57,14 @@ void __init xen_init_vga(const struct do
screen_info->rsvd_size = info->u.vesa_lfb.rsvd_size;
screen_info->rsvd_pos = info->u.vesa_lfb.rsvd_pos;
+ if (size >= offsetof(struct dom0_vga_console_info,
+ u.vesa_lfb.ext_lfb_base)
+ + sizeof(info->u.vesa_lfb.ext_lfb_base)
+ && info->u.vesa_lfb.ext_lfb_base) {
+ screen_info->ext_lfb_base = info->u.vesa_lfb.ext_lfb_base;
+ screen_info->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
+ }
+
if (info->video_type == XEN_VGATYPE_EFI_LFB) {
screen_info->orig_video_isVGA = VIDEO_TYPE_EFI;
break;
@@ -66,14 +74,6 @@ void __init xen_init_vga(const struct do
u.vesa_lfb.mode_attrs)
+ sizeof(info->u.vesa_lfb.mode_attrs))
screen_info->vesa_attributes = info->u.vesa_lfb.mode_attrs;
-
- if (size >= offsetof(struct dom0_vga_console_info,
- u.vesa_lfb.ext_lfb_base)
- + sizeof(info->u.vesa_lfb.ext_lfb_base)
- && info->u.vesa_lfb.ext_lfb_base) {
- screen_info->ext_lfb_base = info->u.vesa_lfb.ext_lfb_base;
- screen_info->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
- }
break;
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/x86: obtain full video frame buffer address for Dom0 also under EFI
2022-02-07 7:41 [PATCH] xen/x86: obtain full video frame buffer address for Dom0 also under EFI Jan Beulich
@ 2022-02-07 8:53 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2022-02-07 8:53 UTC (permalink / raw)
To: Jan Beulich, Boris Ostrovsky; +Cc: xen-devel, lkml
[-- Attachment #1.1.1: Type: text/plain, Size: 422 bytes --]
On 07.02.22 08:41, Jan Beulich wrote:
> The initial change would not work when Xen was booted from EFI: There
> is an early exit from the case block in that case. Move the necessary
> code ahead of that.
>
> Fixes: 335e4dd67b48 ("xen/x86: obtain upper 32 bits of video frame
> buffer address for Dom0") Signed-off-by: Jan Beulich
> <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-07 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 7:41 [PATCH] xen/x86: obtain full video frame buffer address for Dom0 also under EFI Jan Beulich
2022-02-07 8:53 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.