All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports.
Date: Wed, 08 Feb 2017 11:25:47 +0100	[thread overview]
Message-ID: <25198769.WjcufK8OeX@amdc3058> (raw)
In-Reply-To: <c0063f69-e6f8-ce91-8069-308fe4ddb86a@gmail.com>


Hi,

On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote:
> Hi,
> 
> In dss_init_ports, There is no need to add dss_uninit_ports before 
> returning.
> Because it's already take care in dss_bind. dss_bind  is handling
> dss_uninit_ports in error path.

It doesn't handle cleanup of partially initialized ports,
please look at the code:

...
	r = dss_init_ports(pdev);
	if (r)
		goto err_init_ports;
...
err_runtime_get:
	pm_runtime_disable(&pdev->dev);
	dss_uninit_ports(pdev);
err_init_ports:
	if (dss.video1_pll)
		dss_video_pll_uninit(dss.video1_pll);
...

dss_uninit_ports() is not called on partially initialized
ports (when dss_init_ports() returns an error we go straight
into err_init_ports label and skip dss_uninit_ports())

> -Arvind
> 
> 
> On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote:
> > dpi_uninit_port() & sdi_uninit_port() skip not fully
> > initialized port

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports.
Date: Wed, 08 Feb 2017 10:25:47 +0000	[thread overview]
Message-ID: <25198769.WjcufK8OeX@amdc3058> (raw)
In-Reply-To: <c0063f69-e6f8-ce91-8069-308fe4ddb86a@gmail.com>


Hi,

On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote:
> Hi,
> 
> In dss_init_ports, There is no need to add dss_uninit_ports before 
> returning.
> Because it's already take care in dss_bind. dss_bind  is handling
> dss_uninit_ports in error path.

It doesn't handle cleanup of partially initialized ports,
please look at the code:

...
	r = dss_init_ports(pdev);
	if (r)
		goto err_init_ports;
...
err_runtime_get:
	pm_runtime_disable(&pdev->dev);
	dss_uninit_ports(pdev);
err_init_ports:
	if (dss.video1_pll)
		dss_video_pll_uninit(dss.video1_pll);
...

dss_uninit_ports() is not called on partially initialized
ports (when dss_init_ports() returns an error we go straight
into err_init_ports label and skip dss_uninit_ports())

> -Arvind
> 
> 
> On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote:
> > dpi_uninit_port() & sdi_uninit_port() skip not fully
> > initialized port

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


  reply	other threads:[~2017-02-08 10:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170203122444epcas2p3e0d5ed32cac85fd86d900a62dbeb03a4@epcas2p3.samsung.com>
2017-02-03 12:23 ` [PATCH] omapfb: dss: Handle return error in dss_init_ports Arvind Yadav
2017-02-03 12:35   ` Arvind Yadav
2017-02-06 15:28   ` Bartlomiej Zolnierkiewicz
2017-02-06 15:28     ` Bartlomiej Zolnierkiewicz
2017-02-07 12:11     ` Arvind Yadav
2017-02-07 12:23       ` Arvind Yadav
2017-02-08 10:25       ` Bartlomiej Zolnierkiewicz [this message]
2017-02-08 10:25         ` Bartlomiej Zolnierkiewicz
2017-02-08 14:21         ` Bartlomiej Zolnierkiewicz
2017-02-08 14:21           ` Bartlomiej Zolnierkiewicz
2017-02-09 10:02           ` Arvind Yadav
2017-02-09 10:14             ` Arvind Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25198769.WjcufK8OeX@amdc3058 \
    --to=b.zolnierkie@samsung.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.