All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: taos-evm: constify serio_device_id
@ 2017-08-17 12:05 Arvind Yadav
  2017-08-17 15:37 ` Wolfram Sang
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-17 12:05 UTC (permalink / raw)
  To: jdelvare, wsa; +Cc: linux-kernel, linux-i2c

serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by <linux/serio.h> work with
const serio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/i2c/busses/i2c-taos-evm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
index 210ca82..addd90a 100644
--- a/drivers/i2c/busses/i2c-taos-evm.c
+++ b/drivers/i2c/busses/i2c-taos-evm.c
@@ -291,7 +291,7 @@ static void taos_disconnect(struct serio *serio)
 	dev_info(&serio->dev, "Disconnected from TAOS EVM\n");
 }
 
-static struct serio_device_id taos_serio_ids[] = {
+static const struct serio_device_id taos_serio_ids[] = {
 	{
 		.type	= SERIO_RS232,
 		.proto	= SERIO_TAOSEVM,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] i2c: taos-evm: constify serio_device_id
  2017-08-17 12:05 [PATCH] i2c: taos-evm: constify serio_device_id Arvind Yadav
@ 2017-08-17 15:37 ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2017-08-17 15:37 UTC (permalink / raw)
  To: Arvind Yadav; +Cc: jdelvare, linux-kernel, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

On Thu, Aug 17, 2017 at 05:35:52PM +0530, Arvind Yadav wrote:
> serio_device_id are not supposed to change at runtime. All functions
> working with serio_device_id provided by <linux/serio.h> work with
> const serio_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-17 15:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-17 12:05 [PATCH] i2c: taos-evm: constify serio_device_id Arvind Yadav
2017-08-17 15:37 ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.