All of lore.kernel.org
 help / color / mirror / Atom feed
* [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
@ 2023-11-08 16:04 Praneeth Bajjuri
  2023-11-08 16:12 ` Jai Luthra
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Praneeth Bajjuri @ 2023-11-08 16:04 UTC (permalink / raw)
  To: meta-ti; +Cc: Judith Mendez, Ryan Eatmon, Jai Luthra

commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
picks common HDMI and CSI overlays for am62 platform variants.

Adding capability to extend the same prefix for common overlays for applicable
am62 platforms in more generic way to include new mcan overlays added [1]

[1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f

given the differences in SK-AM62-LP containing  B2B HDMI Samtec connector,
just added the kernel prefix to pick common mcan overlay.

for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
hence keeping this prefix seperate for am62pxx to pick right overlay.

Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
v2: updated am62xxsip conf and updated for am62pxx to pick different
mcan overlay

 meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
 meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
 meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
 meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf b/meta-ti-bsp/conf/machine/am62axx-evm.conf
index ef60e9d1..22f61401 100644
--- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
+++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
@@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
 
 KERNEL_DEVICETREE_PREFIX = " \
     ti/k3-am62a7 \
-    ti/k3-am62x-sk-csi2 \
-    ti/k3-am62x-sk-hdmi \
+    ti/k3-am62x-sk \
     ti/k3-fpdlink \
 "
 
diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf b/meta-ti-bsp/conf/machine/am62xx-evm.conf
index b60ba156..fadbc6f4 100644
--- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
+++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
@@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
 
 KERNEL_DEVICETREE_PREFIX = " \
     ti/k3-am625 \
-    ti/k3-am62x-sk-csi2 \
-    ti/k3-am62x-sk-hdmi \
+    ti/k3-am62x-sk \
 "
 
 KERNEL_DEVICETREE = " \
diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
index 0d2f89ca..afa5e061 100644
--- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
+++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
@@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
     ti/k3-am62-lp \
     ti/k3-am625-sk \
     ti/k3-am62x-sk-hdmi \
+    ti/k3-am62x-sk-mcan \
 "
 
 KERNEL_DEVICETREE = " \
diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
index b3bda44a..cae58afe 100644
--- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
+++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
@@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
 
 KERNEL_DEVICETREE_PREFIX = " \
     ti/k3-am625 \
-    ti/k3-am62x-sk-csi2 \
-    ti/k3-am62x-sk-hdmi \
+    ti/k3-am62x-sk \
+
 "
 
 KERNEL_DEVICETREE = " \
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
  2023-11-08 16:04 [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix Praneeth Bajjuri
@ 2023-11-08 16:12 ` Jai Luthra
  2023-11-08 16:43 ` Judith Mendez
  2023-11-08 17:03 ` Judith Mendez
  2 siblings, 0 replies; 6+ messages in thread
From: Jai Luthra @ 2023-11-08 16:12 UTC (permalink / raw)
  To: Praneeth Bajjuri; +Cc: meta-ti, Judith Mendez, Ryan Eatmon

[-- Attachment #1: Type: text/plain, Size: 3260 bytes --]

Hi,

On Nov 08, 2023 at 10:04:37 -0600, Praneeth Bajjuri wrote:
> commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
> picks common HDMI and CSI overlays for am62 platform variants.
> 
> Adding capability to extend the same prefix for common overlays for applicable
> am62 platforms in more generic way to include new mcan overlays added [1]
> 
> [1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f
> 
> given the differences in SK-AM62-LP containing  B2B HDMI Samtec connector,
> just added the kernel prefix to pick common mcan overlay.
> 
> for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
> hence keeping this prefix seperate for am62pxx to pick right overlay.
> 

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> v2: updated am62xxsip conf and updated for am62pxx to pick different
> mcan overlay
> 
>  meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
>  meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
>  meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
>  meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
>  4 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> index ef60e9d1..22f61401 100644
> --- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> @@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
>  
>  KERNEL_DEVICETREE_PREFIX = " \
>      ti/k3-am62a7 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>      ti/k3-fpdlink \
>  "
>  
> diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> index b60ba156..fadbc6f4 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> @@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
>  
>  KERNEL_DEVICETREE_PREFIX = " \
>      ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>  "
>  
>  KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> index 0d2f89ca..afa5e061 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> @@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
>      ti/k3-am62-lp \
>      ti/k3-am625-sk \
>      ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk-mcan \
>  "
>  
>  KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> index b3bda44a..cae58afe 100644
> --- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> @@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
>  
>  KERNEL_DEVICETREE_PREFIX = " \
>      ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
> +
>  "
>  
>  KERNEL_DEVICETREE = " \
> -- 
> 2.17.1
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
  2023-11-08 16:04 [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix Praneeth Bajjuri
  2023-11-08 16:12 ` Jai Luthra
@ 2023-11-08 16:43 ` Judith Mendez
  2023-11-08 16:59   ` Ryan Eatmon
  2023-11-08 17:03 ` Judith Mendez
  2 siblings, 1 reply; 6+ messages in thread
From: Judith Mendez @ 2023-11-08 16:43 UTC (permalink / raw)
  To: Praneeth Bajjuri, meta-ti; +Cc: Ryan Eatmon, Jai Luthra

Hi Praneeth,

On 11/8/23 10:04 AM, Praneeth Bajjuri wrote:
> commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
> picks common HDMI and CSI overlays for am62 platform variants.
> 
> Adding capability to extend the same prefix for common overlays for applicable
> am62 platforms in more generic way to include new mcan overlays added [1]
> 
> [1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f
> 
> given the differences in SK-AM62-LP containing  B2B HDMI Samtec connector,
> just added the kernel prefix to pick common mcan overlay.
> 
> for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
> hence keeping this prefix seperate for am62pxx to pick right overlay.
> 
> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> v2: updated am62xxsip conf and updated for am62pxx to pick different
> mcan overlay
> 
>   meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
>   meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
>   meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
>   meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
>   4 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> index ef60e9d1..22f61401 100644
> --- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> @@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am62a7 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>       ti/k3-fpdlink \
>   "
>   
> diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> index b60ba156..fadbc6f4 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> @@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>   "
>   
>   KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> index 0d2f89ca..afa5e061 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> @@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am62-lp \
>       ti/k3-am625-sk \
>       ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk-mcan \
>   "

This change is not required for 62 LP. MCAN overlay is
already included here:

        ti/k3-am625-sk \

>   
>   KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> index b3bda44a..cae58afe 100644
> --- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> @@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
> +
>   "
>   
>   KERNEL_DEVICETREE = " \

~ Judith


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
  2023-11-08 16:43 ` Judith Mendez
@ 2023-11-08 16:59   ` Ryan Eatmon
  2023-11-08 17:01     ` Judith Mendez
  0 siblings, 1 reply; 6+ messages in thread
From: Ryan Eatmon @ 2023-11-08 16:59 UTC (permalink / raw)
  To: Judith Mendez, Praneeth Bajjuri, meta-ti; +Cc: Jai Luthra



On 11/8/2023 10:43 AM, Judith Mendez wrote:
> Hi Praneeth,
> 
> On 11/8/23 10:04 AM, Praneeth Bajjuri wrote:
>> commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
>> picks common HDMI and CSI overlays for am62 platform variants.
>>
>> Adding capability to extend the same prefix for common overlays for 
>> applicable
>> am62 platforms in more generic way to include new mcan overlays added [1]
>>
>> [1]: 
>> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f
>>
>> given the differences in SK-AM62-LP containing  B2B HDMI Samtec 
>> connector,
>> just added the kernel prefix to pick common mcan overlay.
>>
>> for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
>> hence keeping this prefix seperate for am62pxx to pick right overlay.
>>
>> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
>> ---
>> v2: updated am62xxsip conf and updated for am62pxx to pick different
>> mcan overlay
>>
>>   meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
>>   meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
>>   meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
>>   meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
>>   4 files changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf 
>> b/meta-ti-bsp/conf/machine/am62axx-evm.conf
>> index ef60e9d1..22f61401 100644
>> --- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
>> +++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
>> @@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
>>   KERNEL_DEVICETREE_PREFIX = " \
>>       ti/k3-am62a7 \
>> -    ti/k3-am62x-sk-csi2 \
>> -    ti/k3-am62x-sk-hdmi \
>> +    ti/k3-am62x-sk \
>>       ti/k3-fpdlink \
>>   "
>> diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf 
>> b/meta-ti-bsp/conf/machine/am62xx-evm.conf
>> index b60ba156..fadbc6f4 100644
>> --- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
>> +++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
>> @@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
>>   KERNEL_DEVICETREE_PREFIX = " \
>>       ti/k3-am625 \
>> -    ti/k3-am62x-sk-csi2 \
>> -    ti/k3-am62x-sk-hdmi \
>> +    ti/k3-am62x-sk \
>>   "
>>   KERNEL_DEVICETREE = " \
>> diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf 
>> b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
>> index 0d2f89ca..afa5e061 100644
>> --- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
>> +++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
>> @@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
>>       ti/k3-am62-lp \
>>       ti/k3-am625-sk \
>>       ti/k3-am62x-sk-hdmi \
>> +    ti/k3-am62x-sk-mcan \
>>   "
> 
> This change is not required for 62 LP. MCAN overlay is
> already included here:
> 
>         ti/k3-am625-sk \

Are you sure?

ti/k3-am625-sk != ti/k3-am62x-sk

5 versus x



>>   KERNEL_DEVICETREE = " \
>> diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf 
>> b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
>> index b3bda44a..cae58afe 100644
>> --- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
>> +++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
>> @@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
>>   KERNEL_DEVICETREE_PREFIX = " \
>>       ti/k3-am625 \
>> -    ti/k3-am62x-sk-csi2 \
>> -    ti/k3-am62x-sk-hdmi \
>> +    ti/k3-am62x-sk \
>> +
>>   "
>>   KERNEL_DEVICETREE = " \
> 
> ~ Judith

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
  2023-11-08 16:59   ` Ryan Eatmon
@ 2023-11-08 17:01     ` Judith Mendez
  0 siblings, 0 replies; 6+ messages in thread
From: Judith Mendez @ 2023-11-08 17:01 UTC (permalink / raw)
  To: Ryan Eatmon, Praneeth Bajjuri, meta-ti; +Cc: Jai Luthra

On 11/8/23 10:59 AM, Ryan Eatmon wrote:
> 
> 
> On 11/8/2023 10:43 AM, Judith Mendez wrote:
>> Hi Praneeth,
>>
>> On 11/8/23 10:04 AM, Praneeth Bajjuri wrote:
>>> commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
>>> picks common HDMI and CSI overlays for am62 platform variants.
>>>
>>> Adding capability to extend the same prefix for common overlays for 
>>> applicable
>>> am62 platforms in more generic way to include new mcan overlays added 
>>> [1]
>>>
>>> [1]: 
>>> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f
>>>
>>> given the differences in SK-AM62-LP containing  B2B HDMI Samtec 
>>> connector,
>>> just added the kernel prefix to pick common mcan overlay.
>>>
>>> for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
>>> hence keeping this prefix seperate for am62pxx to pick right overlay.
>>>
>>> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
>>> ---
>>> v2: updated am62xxsip conf and updated for am62pxx to pick different
>>> mcan overlay
>>>
>>>   meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
>>>   meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
>>>   meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
>>>   meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
>>>   4 files changed, 5 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf 
>>> b/meta-ti-bsp/conf/machine/am62axx-evm.conf
>>> index ef60e9d1..22f61401 100644
>>> --- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
>>> +++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
>>> @@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
>>>   KERNEL_DEVICETREE_PREFIX = " \
>>>       ti/k3-am62a7 \
>>> -    ti/k3-am62x-sk-csi2 \
>>> -    ti/k3-am62x-sk-hdmi \
>>> +    ti/k3-am62x-sk \
>>>       ti/k3-fpdlink \
>>>   "
>>> diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf 
>>> b/meta-ti-bsp/conf/machine/am62xx-evm.conf
>>> index b60ba156..fadbc6f4 100644
>>> --- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
>>> +++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
>>> @@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
>>>   KERNEL_DEVICETREE_PREFIX = " \
>>>       ti/k3-am625 \
>>> -    ti/k3-am62x-sk-csi2 \
>>> -    ti/k3-am62x-sk-hdmi \
>>> +    ti/k3-am62x-sk \
>>>   "
>>>   KERNEL_DEVICETREE = " \
>>> diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf 
>>> b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
>>> index 0d2f89ca..afa5e061 100644
>>> --- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
>>> +++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
>>> @@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
>>>       ti/k3-am62-lp \
>>>       ti/k3-am625-sk \
>>>       ti/k3-am62x-sk-hdmi \
>>> +    ti/k3-am62x-sk-mcan \
>>>   "
>>
>> This change is not required for 62 LP. MCAN overlay is
>> already included here:
>>
>>         ti/k3-am625-sk \
> 
> Are you sure?
> 
> ti/k3-am625-sk != ti/k3-am62x-sk
> 
> 5 versus x
> 
My apologies, I saw an x instead of 5. The change is correct

> 
> 
>>>   KERNEL_DEVICETREE = " \
>>> diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf 
>>> b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
>>> index b3bda44a..cae58afe 100644
>>> --- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
>>> +++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
>>> @@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
>>>   KERNEL_DEVICETREE_PREFIX = " \
>>>       ti/k3-am625 \
>>> -    ti/k3-am62x-sk-csi2 \
>>> -    ti/k3-am62x-sk-hdmi \
>>> +    ti/k3-am62x-sk \
>>> +
>>>   "
>>>   KERNEL_DEVICETREE = " \
>>
>> ~ Judith
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
  2023-11-08 16:04 [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix Praneeth Bajjuri
  2023-11-08 16:12 ` Jai Luthra
  2023-11-08 16:43 ` Judith Mendez
@ 2023-11-08 17:03 ` Judith Mendez
  2 siblings, 0 replies; 6+ messages in thread
From: Judith Mendez @ 2023-11-08 17:03 UTC (permalink / raw)
  To: Praneeth Bajjuri, meta-ti; +Cc: Ryan Eatmon, Jai Luthra

Hi all,

On 11/8/23 10:04 AM, Praneeth Bajjuri wrote:
> commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
> picks common HDMI and CSI overlays for am62 platform variants.
> 
> Adding capability to extend the same prefix for common overlays for applicable
> am62 platforms in more generic way to include new mcan overlays added [1]
> 
> [1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f
> 
> given the differences in SK-AM62-LP containing  B2B HDMI Samtec connector,
> just added the kernel prefix to pick common mcan overlay.
> 
> for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
> hence keeping this prefix seperate for am62pxx to pick right overlay.
> 

Looks good to me.

Reviewed-by: Judith Mendez <jm@ti.com>

> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> v2: updated am62xxsip conf and updated for am62pxx to pick different
> mcan overlay
> 
>   meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
>   meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
>   meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
>   meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
>   4 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> index ef60e9d1..22f61401 100644
> --- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> @@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am62a7 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>       ti/k3-fpdlink \
>   "
>   
> diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> index b60ba156..fadbc6f4 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> @@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>   "
>   
>   KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> index 0d2f89ca..afa5e061 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> @@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am62-lp \
>       ti/k3-am625-sk \
>       ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk-mcan \
>   "
>   
>   KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> index b3bda44a..cae58afe 100644
> --- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> @@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
> +
>   "
>   
>   KERNEL_DEVICETREE = " \



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-11-08 17:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08 16:04 [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix Praneeth Bajjuri
2023-11-08 16:12 ` Jai Luthra
2023-11-08 16:43 ` Judith Mendez
2023-11-08 16:59   ` Ryan Eatmon
2023-11-08 17:01     ` Judith Mendez
2023-11-08 17:03 ` Judith Mendez

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.