All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brandeburg, Jesse <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S97 1/7] i40e: Fix for xdp frame struct usage
Date: Fri, 5 Oct 2018 01:09:47 +0000	[thread overview]
Message-ID: <253CF818969A9240AB2054BF91F2C2BC8B2F4343@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20181004221830.16212-1-alice.michael@intel.com>

I don't think this change matches the description, as the code before/after is functionally the same in this patch.
Maybe just change the description to say clean up code by using a local variable.

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Thursday, October 4, 2018 3:18 PM
To: Michael, Alice <alice.michael@intel.com>; intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S97 1/7] i40e: Fix for xdp frame struct usage

From: Jan Sokolowski <jan.sokolowski@intel.com>

Current ifdefs used for xdp frame structs and methods
are not properly used, thus failing to build.

Use proper definitions for sections of code using xdp_frame.

Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 740ea58..c9d209a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -3527,6 +3527,7 @@ static int i40e_xmit_xdp_ring(struct xdp_frame *xdpf,
 	u16 i = xdp_ring->next_to_use;
 	struct i40e_tx_buffer *tx_bi;
 	struct i40e_tx_desc *tx_desc;
+	void *data = xdpf->data;
 	u32 size = xdpf->len;
 	dma_addr_t dma;
 
@@ -3534,8 +3535,7 @@ static int i40e_xmit_xdp_ring(struct xdp_frame *xdpf,
 		xdp_ring->tx_stats.tx_busy++;
 		return I40E_XDP_CONSUMED;
 	}
-
-	dma = dma_map_single(xdp_ring->dev, xdpf->data, size, DMA_TO_DEVICE);
+	dma = dma_map_single(xdp_ring->dev, data, size, DMA_TO_DEVICE);
 	if (dma_mapping_error(xdp_ring->dev, dma))
 		return I40E_XDP_CONSUMED;
 
-- 
2.9.5

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  parent reply	other threads:[~2018-10-05  1:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 22:18 [Intel-wired-lan] [next PATCH S97 1/7] i40e: Fix for xdp frame struct usage Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 2/7] i40e: Add capability flag for stopping FW LLDP Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 3/7] i40e: Replace strncpy with strlcpy to ensure null termination Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 4/7] i40e: Protect access to vf control methods Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 5/7] i40e: Remove negated logic in if statement and fix comment Alice Michael
2018-10-05  1:11   ` Brandeburg, Jesse
2018-10-05 18:42   ` Shannon Nelson
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 6/7] i40e: update driver version Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 7/7] i40e: Allow disabling FW LLDP on X722 devices Alice Michael
2018-10-05  1:07   ` Brandeburg, Jesse
2018-10-05  1:09 ` Brandeburg, Jesse [this message]
2018-10-05 18:42 ` [Intel-wired-lan] [next PATCH S97 1/7] i40e: Fix for xdp frame struct usage Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=253CF818969A9240AB2054BF91F2C2BC8B2F4343@ORSMSX114.amr.corp.intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.