From: Shannon Nelson <shannon.nelson@oracle.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S97 5/7] i40e: Remove negated logic in if statement and fix comment
Date: Fri, 5 Oct 2018 11:42:30 -0700 [thread overview]
Message-ID: <ddd6ffd0-2877-68a8-36ef-5506e809552d@oracle.com> (raw)
In-Reply-To: <20181004221830.16212-5-alice.michael@intel.com>
On 10/4/2018 3:18 PM, Alice Michael wrote:
> From: Patryk Ma?ek <patryk.malek@intel.com>
>
> Found by upstream review. It also fixes a minor comment formatting
> to adhere to networking comment formatting.
As far as I can tell, this doesn't apply to what I can see in Jeff's
tree. Also, I don't see anything about comment formatting in this patch.
sln
>
> Signed-off-by: Patryk Ma?ek <patryk.malek@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index f35a26c..2bb116f 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -4958,8 +4958,8 @@ void i40e_set_ethtool_ops(struct net_device *netdev)
> struct i40e_netdev_priv *np = netdev_priv(netdev);
> struct i40e_pf *pf = np->vsi->back;
>
> - if (!test_bit(__I40E_RECOVERY_MODE, pf->state))
> - netdev->ethtool_ops = &i40e_ethtool_ops;
> - else
> + if (test_bit(__I40E_RECOVERY_MODE, pf->state))
> netdev->ethtool_ops = &i40e_ethtool_recovery_mode_ops;
> + else
> + netdev->ethtool_ops = &i40e_ethtool_ops;
> }
>
next prev parent reply other threads:[~2018-10-05 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 22:18 [Intel-wired-lan] [next PATCH S97 1/7] i40e: Fix for xdp frame struct usage Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 2/7] i40e: Add capability flag for stopping FW LLDP Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 3/7] i40e: Replace strncpy with strlcpy to ensure null termination Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 4/7] i40e: Protect access to vf control methods Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 5/7] i40e: Remove negated logic in if statement and fix comment Alice Michael
2018-10-05 1:11 ` Brandeburg, Jesse
2018-10-05 18:42 ` Shannon Nelson [this message]
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 6/7] i40e: update driver version Alice Michael
2018-10-04 22:18 ` [Intel-wired-lan] [next PATCH S97 7/7] i40e: Allow disabling FW LLDP on X722 devices Alice Michael
2018-10-05 1:07 ` Brandeburg, Jesse
2018-10-05 1:09 ` [Intel-wired-lan] [next PATCH S97 1/7] i40e: Fix for xdp frame struct usage Brandeburg, Jesse
2018-10-05 18:42 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddd6ffd0-2877-68a8-36ef-5506e809552d@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.