* [PATCH] gpio: rcar: Propagate errors from devm_request_irq()
@ 2022-01-04 15:36 Lad Prabhakar
2022-01-04 15:52 ` Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lad Prabhakar @ 2022-01-04 15:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Bartosz Golaszewski
Cc: Andy Shevchenko, Prabhakar, linux-renesas-soc, Lad Prabhakar,
linux-gpio, linux-kernel
The driver overrides the error code returned by devm_request_irq() to
-ENOENT. Switch to propagating the error code upstream.
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
This patch depends on [1].
[1] https://lkml.org/lkml/2021/12/22/633
---
drivers/gpio/gpio-rcar.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 437baecc434e..bd2e16d6e21c 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
goto err0;
}
- if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
- IRQF_SHARED, name, p)) {
+ ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
+ IRQF_SHARED, name, p);
+ if (ret) {
dev_err(dev, "failed to request IRQ\n");
- ret = -ENOENT;
goto err1;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()
2022-01-04 15:36 [PATCH] gpio: rcar: Propagate errors from devm_request_irq() Lad Prabhakar
@ 2022-01-04 15:52 ` Andy Shevchenko
2022-01-04 20:00 ` Sergei Shtylyov
2022-01-05 9:24 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-01-04 15:52 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Geert Uytterhoeven, Linus Walleij, Bartosz Golaszewski,
Prabhakar, Linux-Renesas, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Tue, Jan 4, 2022 at 5:36 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.
Thanks, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> This patch depends on [1].
>
> [1] https://lkml.org/lkml/2021/12/22/633
> ---
> drivers/gpio/gpio-rcar.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 437baecc434e..bd2e16d6e21c 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
> goto err0;
> }
>
> - if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> - IRQF_SHARED, name, p)) {
> + ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> + IRQF_SHARED, name, p);
> + if (ret) {
> dev_err(dev, "failed to request IRQ\n");
> - ret = -ENOENT;
> goto err1;
> }
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()
2022-01-04 15:36 [PATCH] gpio: rcar: Propagate errors from devm_request_irq() Lad Prabhakar
2022-01-04 15:52 ` Andy Shevchenko
@ 2022-01-04 20:00 ` Sergei Shtylyov
2022-01-05 9:24 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2022-01-04 20:00 UTC (permalink / raw)
To: Lad Prabhakar, Geert Uytterhoeven, Linus Walleij, Bartosz Golaszewski
Cc: Andy Shevchenko, Prabhakar, linux-renesas-soc, linux-gpio, linux-kernel
Hello!
On 1/4/22 6:36 PM, Lad Prabhakar wrote:
> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
[...]
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()
2022-01-04 15:36 [PATCH] gpio: rcar: Propagate errors from devm_request_irq() Lad Prabhakar
2022-01-04 15:52 ` Andy Shevchenko
2022-01-04 20:00 ` Sergei Shtylyov
@ 2022-01-05 9:24 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2022-01-05 9:24 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Geert Uytterhoeven, Linus Walleij, Andy Shevchenko, Prabhakar,
Linux-Renesas, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Tue, Jan 4, 2022 at 4:36 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-05 9:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 15:36 [PATCH] gpio: rcar: Propagate errors from devm_request_irq() Lad Prabhakar
2022-01-04 15:52 ` Andy Shevchenko
2022-01-04 20:00 ` Sergei Shtylyov
2022-01-05 9:24 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.