All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SPI/Pl022: Include types.h to remove compilation warnings
@ 2012-03-23  7:35 Viresh Kumar
       [not found] ` <2561efbfb6e8cf1c127dec7eca01bc69948bb94d.1332487932.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2012-03-23  7:35 UTC (permalink / raw)
  To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
	linus.walleij-QSEj5FYQhm4dnm+yROfE0A
  Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Viresh Kumar,
	spear-devel-nkJGhpqTU55BDgjK7y7TUQ

linux/pl022.h uses definitions like, u8, u16, etc, which have dependency of
types.h file, which isn't included in it. So, we get compilation warnings.

This patch includes types.h there to fix these warnings.

Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
---
 include/linux/amba/pl022.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/amba/pl022.h b/include/linux/amba/pl022.h
index b8c5112..76dd1b1 100644
--- a/include/linux/amba/pl022.h
+++ b/include/linux/amba/pl022.h
@@ -25,6 +25,8 @@
 #ifndef _SSP_PL022_H
 #define _SSP_PL022_H
 
+#include <linux/types.h>
+
 /**
  * whether SSP is in loopback mode or not
  */
-- 
1.7.8.110.g4cb5d


------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] SPI/Pl022: Include types.h to remove compilation warnings
       [not found] ` <2561efbfb6e8cf1c127dec7eca01bc69948bb94d.1332487932.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
@ 2012-03-23  9:48   ` Linus Walleij
       [not found]     ` <CACRpkdZV=NEbokQ4YGB=ueN0HkuqXZxqykodGC2MQ_KvBaaGKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2012-03-23  9:48 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	spear-devel-nkJGhpqTU55BDgjK7y7TUQ

On Fri, Mar 23, 2012 at 8:35 AM, Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org> wrote:

> linux/pl022.h uses definitions like, u8, u16, etc, which have dependency of
> types.h file, which isn't included in it. So, we get compilation warnings.
>
> This patch includes types.h there to fix these warnings.
>
> Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>

Looks reasonable!
Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Yours,
Linus Walleij

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] SPI/Pl022: Include types.h to remove compilation warnings
       [not found]     ` <CACRpkdZV=NEbokQ4YGB=ueN0HkuqXZxqykodGC2MQ_KvBaaGKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2012-03-24 16:55       ` Grant Likely
  0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-03-24 16:55 UTC (permalink / raw)
  To: Linus Walleij, Viresh Kumar
  Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	spear-devel-nkJGhpqTU55BDgjK7y7TUQ

On Fri, 23 Mar 2012 10:48:57 +0100, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Fri, Mar 23, 2012 at 8:35 AM, Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org> wrote:
> 
> > linux/pl022.h uses definitions like, u8, u16, etc, which have dependency of
> > types.h file, which isn't included in it. So, we get compilation warnings.
> >
> > This patch includes types.h there to fix these warnings.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
> 
> Looks reasonable!
> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Applied, thanks.

g.


------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-24 16:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-23  7:35 [PATCH] SPI/Pl022: Include types.h to remove compilation warnings Viresh Kumar
     [not found] ` <2561efbfb6e8cf1c127dec7eca01bc69948bb94d.1332487932.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-03-23  9:48   ` Linus Walleij
     [not found]     ` <CACRpkdZV=NEbokQ4YGB=ueN0HkuqXZxqykodGC2MQ_KvBaaGKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-24 16:55       ` Grant Likely

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.