* [PATCH] sh_eth: Use dev_err_probe() helper
@ 2021-12-08 10:32 Geert Uytterhoeven
2021-12-08 12:20 ` Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-12-08 10:32 UTC (permalink / raw)
To: Sergey Shtylyov, David S . Miller, Jakub Kicinski
Cc: netdev, linux-renesas-soc, Geert Uytterhoeven
Use the dev_err_probe() helper, instead of open-coding the same
operation.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/renesas/sh_eth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 223626290ce0e278..d947a628e1663009 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3368,8 +3368,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
/* MDIO bus init */
ret = sh_mdio_init(mdp, pd);
if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "MDIO init failed: %d\n", ret);
+ dev_err_probe(&pdev->dev, ret, "MDIO init failed\n");
goto out_release;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sh_eth: Use dev_err_probe() helper
2021-12-08 10:32 [PATCH] sh_eth: Use dev_err_probe() helper Geert Uytterhoeven
@ 2021-12-08 12:20 ` Niklas Söderlund
2021-12-08 16:56 ` Sergey Shtylyov
2021-12-10 3:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2021-12-08 12:20 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sergey Shtylyov, David S . Miller, Jakub Kicinski, netdev,
linux-renesas-soc
Hi Geert,
Thanks for your work, I learnt something new.
On 2021-12-08 11:32:07 +0100, Geert Uytterhoeven wrote:
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Use the dev_err_probe() helper, instead of open-coding the same
> operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 223626290ce0e278..d947a628e1663009 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -3368,8 +3368,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
> /* MDIO bus init */
> ret = sh_mdio_init(mdp, pd);
> if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "MDIO init failed: %d\n", ret);
> + dev_err_probe(&pdev->dev, ret, "MDIO init failed\n");
> goto out_release;
> }
>
> --
> 2.25.1
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh_eth: Use dev_err_probe() helper
2021-12-08 10:32 [PATCH] sh_eth: Use dev_err_probe() helper Geert Uytterhoeven
2021-12-08 12:20 ` Niklas Söderlund
@ 2021-12-08 16:56 ` Sergey Shtylyov
2021-12-10 3:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2021-12-08 16:56 UTC (permalink / raw)
To: Geert Uytterhoeven, David S . Miller, Jakub Kicinski
Cc: netdev, linux-renesas-soc
Hello!
On 12/8/21 1:32 PM, Geert Uytterhoeven wrote:
> Use the dev_err_probe() helper, instead of open-coding the same
> operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh_eth: Use dev_err_probe() helper
2021-12-08 10:32 [PATCH] sh_eth: Use dev_err_probe() helper Geert Uytterhoeven
2021-12-08 12:20 ` Niklas Söderlund
2021-12-08 16:56 ` Sergey Shtylyov
@ 2021-12-10 3:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-10 3:20 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: s.shtylyov, davem, kuba, netdev, linux-renesas-soc
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 8 Dec 2021 11:32:07 +0100 you wrote:
> Use the dev_err_probe() helper, instead of open-coding the same
> operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- sh_eth: Use dev_err_probe() helper
https://git.kernel.org/netdev/net-next/c/e5d75fc20b92
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-10 3:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 10:32 [PATCH] sh_eth: Use dev_err_probe() helper Geert Uytterhoeven
2021-12-08 12:20 ` Niklas Söderlund
2021-12-08 16:56 ` Sergey Shtylyov
2021-12-10 3:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.