All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<yukuai3@huawei.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] mtd: mtd_blkdevs: Initialize rq.limits.discard_granularity
Date: Fri, 18 Jun 2021 16:55:01 +0800	[thread overview]
Message-ID: <258a2366-0042-dc2b-0589-fe3a99851ded@huawei.com> (raw)
In-Reply-To: <20210618095207.0bec4fde@xps13>

在 2021/6/18 15:52, Miquel Raynal 写道:
> Hi Zhihao,
> 
> Zhihao Cheng <chengzhihao1@huawei.com> wrote on Tue, 15 Jun 2021
> 17:39:05 +0800:
> 
>> Since commit b35fd7422c2f8("block: check queue's limits.discard_granularity
>> in __blkdev_issue_discard()") checks rq.limits.discard_granularity in
>> __blkdev_issue_discard(), we may get following warnings on formatted ftl:
>>
>>    WARNING: CPU: 2 PID: 7313 at block/blk-lib.c:51
>>    __blkdev_issue_discard+0x2a7/0x390
>>
>> Reproducer:
>>    1. ftl_format /dev/mtd0
>>    2. modprobe ftl
>>    3. mkfs.vfat /dev/ftla
>>    4. mount -odiscard /dev/ftla temp
>>    5. dd if=/dev/zero of=temp/tst bs=1M count=10 oflag=direct
>>    6. dd if=/dev/zero of=temp/tst bs=1M count=10 oflag=direct
>>
>> Fix it by initializing rq.limits.discard_granularity if device supports
>> discard operation.
> 
> Can you please verify that this is still needed after Christoph's
> additional fix:
> https://patchwork.kernel.org/project/xen-devel/patch/20210602065345.355274-10-hch@lst.de/
> 
Hi, Miquel,
I can still reproduce the problem after [1] applied.
I look through this series patches and I didn't find out 
'rq.limits.discard_granularity' has been initialized somewhere. The 
patchset is aming at reconstructing to avoid boilerplate code in drivers?
So 'rq.limits.discard_granularity' still need to be initialized in 
mtdblock driver.

[1] 
https://patchwork.kernel.org/project/xen-devel/patch/20210602065345.355274-10-hch@lst.de/

> 


WARNING: multiple messages have this Message-ID (diff)
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<yukuai3@huawei.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] mtd: mtd_blkdevs: Initialize rq.limits.discard_granularity
Date: Fri, 18 Jun 2021 16:55:01 +0800	[thread overview]
Message-ID: <258a2366-0042-dc2b-0589-fe3a99851ded@huawei.com> (raw)
In-Reply-To: <20210618095207.0bec4fde@xps13>

在 2021/6/18 15:52, Miquel Raynal 写道:
> Hi Zhihao,
> 
> Zhihao Cheng <chengzhihao1@huawei.com> wrote on Tue, 15 Jun 2021
> 17:39:05 +0800:
> 
>> Since commit b35fd7422c2f8("block: check queue's limits.discard_granularity
>> in __blkdev_issue_discard()") checks rq.limits.discard_granularity in
>> __blkdev_issue_discard(), we may get following warnings on formatted ftl:
>>
>>    WARNING: CPU: 2 PID: 7313 at block/blk-lib.c:51
>>    __blkdev_issue_discard+0x2a7/0x390
>>
>> Reproducer:
>>    1. ftl_format /dev/mtd0
>>    2. modprobe ftl
>>    3. mkfs.vfat /dev/ftla
>>    4. mount -odiscard /dev/ftla temp
>>    5. dd if=/dev/zero of=temp/tst bs=1M count=10 oflag=direct
>>    6. dd if=/dev/zero of=temp/tst bs=1M count=10 oflag=direct
>>
>> Fix it by initializing rq.limits.discard_granularity if device supports
>> discard operation.
> 
> Can you please verify that this is still needed after Christoph's
> additional fix:
> https://patchwork.kernel.org/project/xen-devel/patch/20210602065345.355274-10-hch@lst.de/
> 
Hi, Miquel,
I can still reproduce the problem after [1] applied.
I look through this series patches and I didn't find out 
'rq.limits.discard_granularity' has been initialized somewhere. The 
patchset is aming at reconstructing to avoid boilerplate code in drivers?
So 'rq.limits.discard_granularity' still need to be initialized in 
mtdblock driver.

[1] 
https://patchwork.kernel.org/project/xen-devel/patch/20210602065345.355274-10-hch@lst.de/

> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-06-18  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15  9:39 [PATCH v2] mtd: mtd_blkdevs: Initialize rq.limits.discard_granularity Zhihao Cheng
2021-06-15  9:39 ` Zhihao Cheng
2021-06-18  7:52 ` Miquel Raynal
2021-06-18  7:52   ` Miquel Raynal
2021-06-18  8:55   ` Zhihao Cheng [this message]
2021-06-18  8:55     ` Zhihao Cheng
2021-07-12 13:39     ` Zhihao Cheng
2021-07-15 22:50 ` Miquel Raynal
2021-07-15 22:50   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=258a2366-0042-dc2b-0589-fe3a99851ded@huawei.com \
    --to=chengzhihao1@huawei.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.