[PATCH] block, bfq: remove unused variable for bfq_queue

[PATCH] block, bfq: remove unused variable for bfq_queue

[Yuwei Guan]

it defined in d0edc24, but there's nowhere to use it,
so remove it.

Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
---
 block/bfq-iosched.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 64ee618064ba..0a7b3506697c 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -372,9 +372,6 @@ struct bfq_queue {

        unsigned long creation_time; /* when this queue is created */

-       /* max service rate measured so far */
-       u32 max_service_rate;
-
        /*
         * Pointer to the waker queue for this queue, i.e., to the
         * queue Q such that this queue happens to get new I/O right
--
2.34.1

免责声明：本邮件所包含信息发给指定个人或机构，邮件可能包含保密或专属信息。未经接收者许可，不得阅读、转发或传播邮件内容，或根据邮件内容采取任何相关行动。如果错误地收到了此邮件，请与收件人联系并自行删除邮件内容。

Disclaimer：The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error , please contact the sender and delete the material from any computer .

Re: [PATCH] block, bfq: remove unused variable for bfq_queue

[Paolo VALENTE]

> Il giorno 10 ott 2022, alle ore 15:29, Yuwei Guan <Yuwei.Guan@zeekrlife.com> ha scritto:
> 
> it defined in d0edc24, but there's nowhere to use it,
> so remove it.
> 
> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>

Thank you very much for spotting this!

Acked-by: Paolo Valente <paolo.valente@linaro.org>

> ---
> block/bfq-iosched.h | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..0a7b3506697c 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -372,9 +372,6 @@ struct bfq_queue {
> 
>        unsigned long creation_time; /* when this queue is created */
> 
> -       /* max service rate measured so far */
> -       u32 max_service_rate;
> -
>        /*
>         * Pointer to the waker queue for this queue, i.e., to the
>         * queue Q such that this queue happens to get new I/O right
> --
> 2.34.1
> 
> 免责声明：本邮件所包含信息发给指定个人或机构，邮件可能包含保密或专属信息。未经接收者许可，不得阅读、转发或传播邮件内容，或根据邮件内容采取任何相关行动。如果错误地收到了此邮件，请与收件人联系并自行删除邮件内容。
> 
> Disclaimer：The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error , please contact the sender and delete the material from any computer .

Re: [PATCH] block, bfq: remove unused variable for bfq_queue

[Jens Axboe]

On 10/10/22 7:29 AM, Yuwei Guan wrote:
> it defined in d0edc24, but there's nowhere to use it,
> so remove it.

A few things wrong with this patch:

1) It's whitespace damaged, and hence will not apply directly.
2) It should have a fixes tag, and the sha used should be 12
    chars. 8 is too short.

Can you resend it?

> Disclaimer?The information transmitted is intended only for the person
> or entity to which it is addressed and may contain confidential and/or
> privileged material. Any review, retransmission, dissemination or
> other use of, or taking of any action in reliance upon, this
> information by persons or entities other than the intended recipient
> is prohibited. If you received this in error , please contact the
> sender and delete the material from any computer .

And please get rid of this, it's just spam and doesn't apply on a public
mailing list.

-- 
Jens Axboe

Re: [PATCH] block, bfq: remove unused variable for bfq_queue

[Yuwei Guan]

On 2022/10/12 0:26, Jens Axboe wrote:
> On 10/10/22 7:29 AM, Yuwei Guan wrote:
>> it defined in d0edc24, but there's nowhere to use it,
>> so remove it.
> A few things wrong with this patch:
>
> 1) It's whitespace damaged, and hence will not apply directly.
> 2) It should have a fixes tag, and the sha used should be 12
>      chars. 8 is too short.
>
> Can you resend it?
Thanks for reviewing, sure, I will resend it.
>> Disclaimer?The information transmitted is intended only for the person
>> or entity to which it is addressed and may contain confidential and/or
>> privileged material. Any review, retransmission, dissemination or
>> other use of, or taking of any action in reliance upon, this
>> information by persons or entities other than the intended recipient
>> is prohibited. If you received this in error , please contact the
>> sender and delete the material from any computer .
> And please get rid of this, it's just spam and doesn't apply on a public
> mailing list.
Ok, I will send with gmail.