* [PATCH] drm: Add FEC registers for LT-tunable repeaters
@ 2019-12-05 13:58 ` Rodrigo Siqueira
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2019-12-05 13:58 UTC (permalink / raw)
To: =dri-devel, linux-kernel, amd-gfx
Cc: Leo Li, Abdoulaye Berthe, Jani Nikula, Nikola Cornij,
Manasi Navare, Harry Wentland, Ville Syrjälä
FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
1.4a. This commit adds the address registers for
FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.
Cc: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
---
include/drm/drm_dp_helper.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 51ecb5112ef8..b2057009aabc 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1042,6 +1042,8 @@
#define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1 0xf0039 /* 1.3 */
#define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
#define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
+#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /* 1.4 */
+#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a */
/* Repeater modes */
#define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
--
2.24.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] drm: Add FEC registers for LT-tunable repeaters
2019-12-05 13:58 ` Rodrigo Siqueira
@ 2019-12-05 15:12 ` Liu, Zhan
-1 siblings, 0 replies; 6+ messages in thread
From: Liu, Zhan @ 2019-12-05 15:12 UTC (permalink / raw)
To: Siqueira, Rodrigo, =dri-devel, linux-kernel, amd-gfx
Cc: Li, Sun peng (Leo),
Berthe, Abdoulaye, Jani Nikula, Cornij, Nikola, Manasi Navare,
Wentland, Harry, Ville Syrjälä
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Rodrigo Siqueira
> Sent: 2019/December/05, Thursday 8:59 AM
> To: =dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; amd-
> gfx@lists.freedesktop.org
> Cc: Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Berthe, Abdoulaye
> <Abdoulaye.Berthe@amd.com>; Jani Nikula <jani.nikula@linux.intel.com>;
> Cornij, Nikola <Nikola.Cornij@amd.com>; Manasi Navare
> <manasi.d.navare@intel.com>; Wentland, Harry
> <Harry.Wentland@amd.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>
> Subject: [PATCH] drm: Add FEC registers for LT-tunable repeaters
>
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP 1.4a.
> This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and
> FEC_CAPABILITY_PHY_REPEATER1.
>
> Cc: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Looks good to me.
Reviewed-by: Zhan Liu <zhan.liu@amd.com>
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1
> 0xf0039 /* 1.3 */
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1
> 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /*
> 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /*
> 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a
> */
>
> /* Repeater modes */
> #define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /*
> 1.3 */
> --
> 2.24.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=02%7C01%7Czhan.liu%40amd.com%7Cfdbf92dcf79449d434e
> 208d7798b586d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> 37111511793172919&sdata=SXDkgEpIQmTkmfFL0bXSBFwVxd9sSMWke
> V358fkkQZY%3D&reserved=0
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm: Add FEC registers for LT-tunable repeaters
@ 2019-12-05 15:12 ` Liu, Zhan
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Zhan @ 2019-12-05 15:12 UTC (permalink / raw)
To: Siqueira, Rodrigo, =dri-devel, linux-kernel, amd-gfx
Cc: Li, Sun peng (Leo),
Berthe, Abdoulaye, Jani Nikula, Cornij, Nikola, Manasi Navare,
Wentland, Harry, Ville Syrjälä
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Rodrigo Siqueira
> Sent: 2019/December/05, Thursday 8:59 AM
> To: =dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; amd-
> gfx@lists.freedesktop.org
> Cc: Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Berthe, Abdoulaye
> <Abdoulaye.Berthe@amd.com>; Jani Nikula <jani.nikula@linux.intel.com>;
> Cornij, Nikola <Nikola.Cornij@amd.com>; Manasi Navare
> <manasi.d.navare@intel.com>; Wentland, Harry
> <Harry.Wentland@amd.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>
> Subject: [PATCH] drm: Add FEC registers for LT-tunable repeaters
>
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP 1.4a.
> This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and
> FEC_CAPABILITY_PHY_REPEATER1.
>
> Cc: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Looks good to me.
Reviewed-by: Zhan Liu <zhan.liu@amd.com>
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1
> 0xf0039 /* 1.3 */
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1
> 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /*
> 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /*
> 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a
> */
>
> /* Repeater modes */
> #define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /*
> 1.3 */
> --
> 2.24.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=02%7C01%7Czhan.liu%40amd.com%7Cfdbf92dcf79449d434e
> 208d7798b586d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> 37111511793172919&sdata=SXDkgEpIQmTkmfFL0bXSBFwVxd9sSMWke
> V358fkkQZY%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Add FEC registers for LT-tunable repeaters
2019-12-05 13:58 ` Rodrigo Siqueira
@ 2019-12-06 16:38 ` Harry Wentland
-1 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2019-12-06 16:38 UTC (permalink / raw)
To: Rodrigo Siqueira, =dri-devel, linux-kernel, amd-gfx
Cc: Abdoulaye Berthe, Harry Wentland, Leo Li, Jani Nikula,
Manasi Navare, Ville Syrjälä,
Nikola Cornij
On 2019-12-05 8:58 a.m., Rodrigo Siqueira wrote:
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
> 1.4a. This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.
>
> Cc: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1 0xf0039 /* 1.3 */
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /* 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a */
>
> /* Repeater modes */
> #define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Add FEC registers for LT-tunable repeaters
@ 2019-12-06 16:38 ` Harry Wentland
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2019-12-06 16:38 UTC (permalink / raw)
To: Rodrigo Siqueira, =dri-devel, linux-kernel, amd-gfx
Cc: Leo Li, Abdoulaye Berthe, Jani Nikula, Nikola Cornij,
Manasi Navare, Harry Wentland, Ville Syrjälä
On 2019-12-05 8:58 a.m., Rodrigo Siqueira wrote:
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
> 1.4a. This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.
>
> Cc: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1 0xf0039 /* 1.3 */
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /* 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a */
>
> /* Repeater modes */
> #define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread