[PATCH] Staging: Remove line to fix checkpatch error

[PATCH] Staging: Remove line to fix checkpatch error

[tawahpeggy]

remove one empty line.CHECK: Please don't use multiple blank lines

Signed-off-by: tawahpeggy <tawahpeggy98@gmail.com>

---
 drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
 1 file changed, 0 insertion(+), 1 deletion(-)
 create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c

diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c b/drivers/staging/comedi/comedi_pcmcia.mod.c
index 0904b8765afs96..3984db1a39c8
--- /dev/null
+++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
@@ -0,0 +1,31 @@
#include <linux/module.h>
#define INCLUDE_VERMAGIC
#include <linux/build-salt.h>
#include <linux/vermagic.h>
#include <linux/compiler.h>

BUILD_SALT;

MODULE_INFO(vermagic, VERMAGIC_STRING);
MODULE_INFO(name, KBUILD_MODNAME);

__visible struct module __this_module
__section(".gnu.linkonce.this_module") = {
	.name = KBUILD_MODNAME,
	.init = init_module,
#ifdef CONFIG_MODULE_UNLOAD
	.exit = cleanup_module,
#endif
	.arch = MODULE_ARCH_INIT,
};

#ifdef CONFIG_RETPOLINE
MODULE_INFO(retpoline, "Y");
#endif

MODULE_INFO(staging, "Y");

MODULE_INFO(depends, "pcmcia,comedi");

-  
MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
-- 
2.17.1
h-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH] Staging: Remove line to fix checkpatch error

[Greg Kroah-Hartman]

On Sun, Apr 11, 2021 at 04:49:38PM -0400, tawahpeggy wrote:
> remove one empty line.CHECK: Please don't use multiple blank lines
> 
> Signed-off-by: tawahpeggy <tawahpeggy98@gmail.com>
> 
> ---
>  drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>  1 file changed, 0 insertion(+), 1 deletion(-)
>  create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
> 
> diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c b/drivers/staging/comedi/comedi_pcmcia.mod.c
> index 0904b8765afs96..3984db1a39c8
> --- /dev/null
> +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
> @@ -0,0 +1,31 @@
> #include <linux/module.h>
> #define INCLUDE_VERMAGIC
> #include <linux/build-salt.h>
> #include <linux/vermagic.h>
> #include <linux/compiler.h>
> 
> BUILD_SALT;
> 
> MODULE_INFO(vermagic, VERMAGIC_STRING);
> MODULE_INFO(name, KBUILD_MODNAME);
> 
> __visible struct module __this_module
> __section(".gnu.linkonce.this_module") = {
> 	.name = KBUILD_MODNAME,
> 	.init = init_module,
> #ifdef CONFIG_MODULE_UNLOAD
> 	.exit = cleanup_module,
> #endif
> 	.arch = MODULE_ARCH_INIT,
> };
> 
> #ifdef CONFIG_RETPOLINE
> MODULE_INFO(retpoline, "Y");
> #endif
> 
> MODULE_INFO(staging, "Y");
> 
> MODULE_INFO(depends, "pcmcia,comedi");
> 
> -  
> MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
> -- 
> 2.17.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

- Your patch does not match the description at all.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] Staging: Remove line to fix checkpatch error

[Ian Abbott]

On 11/04/2021 21:49, tawahpeggy wrote:
> remove one empty line.CHECK: Please don't use multiple blank lines
> 
> Signed-off-by: tawahpeggy <tawahpeggy98@gmail.com>
> 
> ---
>   drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>   1 file changed, 0 insertion(+), 1 deletion(-)
>   create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
> 
> diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c b/drivers/staging/comedi/comedi_pcmcia.mod.c
> index 0904b8765afs96..3984db1a39c8
> --- /dev/null
> +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c

The .mod.c files are not really part of the Linux kernel source code. 
They are generated during the kernel build process.  There is no point 
checking them with checkpatch.pl.  If you are adding them to your git 
repository, then you are doing something wrong.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

[Julia Lawall]

On Sun, 11 Apr 2021, tawahpeggy wrote:

> remove one empty line.CHECK: Please don't use multiple blank lines

Did something go wrong with the patch generation?  You say that you are
removing one line, but the diff information looks like you are adding a
file.  Normally a patch has only the changed lines and a few lines before
and after.

> Signed-off-by: tawahpeggy <tawahpeggy98@gmail.com>

You need to put your real name when contributing to the Linux kernel.

For example, I would put:

Julia Lawall <julia.lawall@inria.fr>

julia

>
> ---
>  drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>  1 file changed, 0 insertion(+), 1 deletion(-)
>  create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c b/drivers/staging/comedi/comedi_pcmcia.mod.c
> index 0904b8765afs96..3984db1a39c8
> --- /dev/null
> +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
> @@ -0,0 +1,31 @@
> #include <linux/module.h>
> #define INCLUDE_VERMAGIC
> #include <linux/build-salt.h>
> #include <linux/vermagic.h>
> #include <linux/compiler.h>
>
> BUILD_SALT;
>
> MODULE_INFO(vermagic, VERMAGIC_STRING);
> MODULE_INFO(name, KBUILD_MODNAME);
>
> __visible struct module __this_module
> __section(".gnu.linkonce.this_module") = {
> 	.name = KBUILD_MODNAME,
> 	.init = init_module,
> #ifdef CONFIG_MODULE_UNLOAD
> 	.exit = cleanup_module,
> #endif
> 	.arch = MODULE_ARCH_INIT,
> };
>
> #ifdef CONFIG_RETPOLINE
> MODULE_INFO(retpoline, "Y");
> #endif
>
> MODULE_INFO(staging, "Y");
>
> MODULE_INFO(depends, "pcmcia,comedi");
>
> -
> MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
> --
> 2.17.1
> h-Hartman <gregkh@linuxfoundation.org>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA3524%40peggy-Lenovo-V130-15IKB.
>

Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

[Julia Lawall]

On Sun, 11 Apr 2021, tawahpeggy wrote:

> remove one empty line.CHECK: Please don't use multiple blank lines

Did something go wrong with the patch generation?  You say that you are
removing one line, but the diff information looks like you are adding a
file.  Normally a patch has only the changed lines and a few lines before
and after.

> Signed-off-by: tawahpeggy <tawahpeggy98@gmail.com>

You need to put your real name when contributing to the Linux kernel.

For example, I would put:

Julia Lawall <julia.lawall@inria.fr>

julia

>
> ---
>  drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>  1 file changed, 0 insertion(+), 1 deletion(-)
>  create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c b/drivers/staging/comedi/comedi_pcmcia.mod.c
> index 0904b8765afs96..3984db1a39c8
> --- /dev/null
> +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
> @@ -0,0 +1,31 @@
> #include <linux/module.h>
> #define INCLUDE_VERMAGIC
> #include <linux/build-salt.h>
> #include <linux/vermagic.h>
> #include <linux/compiler.h>
>
> BUILD_SALT;
>
> MODULE_INFO(vermagic, VERMAGIC_STRING);
> MODULE_INFO(name, KBUILD_MODNAME);
>
> __visible struct module __this_module
> __section(".gnu.linkonce.this_module") = {
> 	.name = KBUILD_MODNAME,
> 	.init = init_module,
> #ifdef CONFIG_MODULE_UNLOAD
> 	.exit = cleanup_module,
> #endif
> 	.arch = MODULE_ARCH_INIT,
> };
>
> #ifdef CONFIG_RETPOLINE
> MODULE_INFO(retpoline, "Y");
> #endif
>
> MODULE_INFO(staging, "Y");
>
> MODULE_INFO(depends, "pcmcia,comedi");
>
> -
> MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
> --
> 2.17.1
> h-Hartman <gregkh@linuxfoundation.org>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA3524%40peggy-Lenovo-V130-15IKB.
>

Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

[PEGGY TAWAH]

[-- Attachment #1.1: Type: text/plain, Size: 2503 bytes --]

Thank you Julia for your timely feedback and intervention. i think the 
patch got mixed up after i did git add <name of file modified> now i 
understand it was a wrong move.  will fix that right away and submit.
Thanks again.
Tawah Peggy

On Monday, April 12, 2021 at 6:10:56 AM UTC-4 Julia....@inria.fr wrote:

>
>
> On Sun, 11 Apr 2021, tawahpeggy wrote:
>
> > remove one empty line.CHECK: Please don't use multiple blank lines
>
> Did something go wrong with the patch generation? You say that you are
> removing one line, but the diff information looks like you are adding a
> file. Normally a patch has only the changed lines and a few lines before
> and after.
>
> > Signed-off-by: tawahpeggy <tawahp...@gmail.com>
>
> You need to put your real name when contributing to the Linux kernel.
>
> For example, I would put:
>
> Julia Lawall <julia....@inria.fr>
>
> julia
>
> >
> > ---
> > drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
> > 1 file changed, 0 insertion(+), 1 deletion(-)
> > create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
> >
> > diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c 
> b/drivers/staging/comedi/comedi_pcmcia.mod.c
> > index 0904b8765afs96..3984db1a39c8
> > --- /dev/null
> > +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
> > @@ -0,0 +1,31 @@
> > #include <linux/module.h>
> > #define INCLUDE_VERMAGIC
> > #include <linux/build-salt.h>
> > #include <linux/vermagic.h>
> > #include <linux/compiler.h>
> >
> > BUILD_SALT;
> >
> > MODULE_INFO(vermagic, VERMAGIC_STRING);
> > MODULE_INFO(name, KBUILD_MODNAME);
> >
> > __visible struct module __this_module
> > __section(".gnu.linkonce.this_module") = {
> > .name = KBUILD_MODNAME,
> > .init = init_module,
> > #ifdef CONFIG_MODULE_UNLOAD
> > .exit = cleanup_module,
> > #endif
> > .arch = MODULE_ARCH_INIT,
> > };
> >
> > #ifdef CONFIG_RETPOLINE
> > MODULE_INFO(retpoline, "Y");
> > #endif
> >
> > MODULE_INFO(staging, "Y");
> >
> > MODULE_INFO(depends, "pcmcia,comedi");
> >
> > -
> > MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
> > --
> > 2.17.1
> > h-Hartman <gre...@linuxfoundation.org>
> >
> > --
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com.
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA3524%40peggy-Lenovo-V130-15IKB
> .
> >
>

[-- Attachment #1.2: Type: text/html, Size: 3732 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 3496 bytes --]



On Mon, 12 Apr 2021, PEGGY TAWAH wrote:

> Thank you Julia for your timely feedback and intervention. i think the patch
> got mixed up after i did git add <name of file modified> now i understand it
> was a wrong move.  will fix that right away and submit.Thanks again.

Actually, someone else said that it is a generated file.  So you should
just move on to something else.

julia

> Tawah Peggy
>
> On Monday, April 12, 2021 at 6:10:56 AM UTC-4 Julia....@inria.fr wrote:
>
>
>       On Sun, 11 Apr 2021, tawahpeggy wrote:
>
>       > remove one empty line.CHECK: Please don't use multiple blank
>       lines
>
>       Did something go wrong with the patch generation? You say that
>       you are
>       removing one line, but the diff information looks like you are
>       adding a
>       file. Normally a patch has only the changed lines and a few
>       lines before
>       and after.
>
>       > Signed-off-by: tawahpeggy <tawahp...@gmail.com>
>
>       You need to put your real name when contributing to the Linux
>       kernel.
>
>       For example, I would put:
>
>       Julia Lawall <julia....@inria.fr>
>
>       julia
>
>       >
>       > ---
>       > drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>       > 1 file changed, 0 insertion(+), 1 deletion(-)
>       > create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
>       >
>       > diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c
>       b/drivers/staging/comedi/comedi_pcmcia.mod.c
>       > index 0904b8765afs96..3984db1a39c8
>       > --- /dev/null
>       > +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
>       > @@ -0,0 +1,31 @@
>       > #include <linux/module.h>
>       > #define INCLUDE_VERMAGIC
>       > #include <linux/build-salt.h>
>       > #include <linux/vermagic.h>
>       > #include <linux/compiler.h>
>       >
>       > BUILD_SALT;
>       >
>       > MODULE_INFO(vermagic, VERMAGIC_STRING);
>       > MODULE_INFO(name, KBUILD_MODNAME);
>       >
>       > __visible struct module __this_module
>       > __section(".gnu.linkonce.this_module") = {
>       > .name = KBUILD_MODNAME,
>       > .init = init_module,
>       > #ifdef CONFIG_MODULE_UNLOAD
>       > .exit = cleanup_module,
>       > #endif
>       > .arch = MODULE_ARCH_INIT,
>       > };
>       >
>       > #ifdef CONFIG_RETPOLINE
>       > MODULE_INFO(retpoline, "Y");
>       > #endif
>       >
>       > MODULE_INFO(staging, "Y");
>       >
>       > MODULE_INFO(depends, "pcmcia,comedi");
>       >
>       > -
>       > MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
>       > --
>       > 2.17.1
>       > h-Hartman <gre...@linuxfoundation.org>
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an email to outreachy-kern...@googlegroups.com.
>       > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA3524%40
>       peggy-Lenovo-V130-15IKB.
>       >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/3c032481-f359-45c7-947b-
> 54b39e989822n%40googlegroups.com.
>
>

Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

[PEGGY TAWAH]

[-- Attachment #1: Type: text/plain, Size: 3802 bytes --]

Ok, thanks!

On Mon, Apr 12, 2021, 1:01 PM Julia Lawall <julia.lawall@inria.fr> wrote:

>
>
> On Mon, 12 Apr 2021, PEGGY TAWAH wrote:
>
> > Thank you Julia for your timely feedback and intervention. i think the
> patch
> > got mixed up after i did git add <name of file modified> now i
> understand it
> > was a wrong move.  will fix that right away and submit.Thanks again.
>
> Actually, someone else said that it is a generated file.  So you should
> just move on to something else.
>
> julia
>
> > Tawah Peggy
> >
> > On Monday, April 12, 2021 at 6:10:56 AM UTC-4 Julia....@inria.fr wrote:
> >
> >
> >       On Sun, 11 Apr 2021, tawahpeggy wrote:
> >
> >       > remove one empty line.CHECK: Please don't use multiple blank
> >       lines
> >
> >       Did something go wrong with the patch generation? You say that
> >       you are
> >       removing one line, but the diff information looks like you are
> >       adding a
> >       file. Normally a patch has only the changed lines and a few
> >       lines before
> >       and after.
> >
> >       > Signed-off-by: tawahpeggy <tawahp...@gmail.com>
> >
> >       You need to put your real name when contributing to the Linux
> >       kernel.
> >
> >       For example, I would put:
> >
> >       Julia Lawall <julia....@inria.fr>
> >
> >       julia
> >
> >       >
> >       > ---
> >       > drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
> >       > 1 file changed, 0 insertion(+), 1 deletion(-)
> >       > create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
> >       >
> >       > diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c
> >       b/drivers/staging/comedi/comedi_pcmcia.mod.c
> >       > index 0904b8765afs96..3984db1a39c8
> >       > --- /dev/null
> >       > +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
> >       > @@ -0,0 +1,31 @@
> >       > #include <linux/module.h>
> >       > #define INCLUDE_VERMAGIC
> >       > #include <linux/build-salt.h>
> >       > #include <linux/vermagic.h>
> >       > #include <linux/compiler.h>
> >       >
> >       > BUILD_SALT;
> >       >
> >       > MODULE_INFO(vermagic, VERMAGIC_STRING);
> >       > MODULE_INFO(name, KBUILD_MODNAME);
> >       >
> >       > __visible struct module __this_module
> >       > __section(".gnu.linkonce.this_module") = {
> >       > .name = KBUILD_MODNAME,
> >       > .init = init_module,
> >       > #ifdef CONFIG_MODULE_UNLOAD
> >       > .exit = cleanup_module,
> >       > #endif
> >       > .arch = MODULE_ARCH_INIT,
> >       > };
> >       >
> >       > #ifdef CONFIG_RETPOLINE
> >       > MODULE_INFO(retpoline, "Y");
> >       > #endif
> >       >
> >       > MODULE_INFO(staging, "Y");
> >       >
> >       > MODULE_INFO(depends, "pcmcia,comedi");
> >       >
> >       > -
> >       > MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
> >       > --
> >       > 2.17.1
> >       > h-Hartman <gre...@linuxfoundation.org>
> >       >
> >       > --
> >       > You received this message because you are subscribed to the
> >       Google Groups "outreachy-kernel" group.
> >       > To unsubscribe from this group and stop receiving emails from
> >       it, send an email to outreachy-kern...@googlegroups.com.
> >       > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA3524%40
> >       peggy-Lenovo-V130-15IKB.
> >       >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/3c032481-f359-45c7-947b-
> > 54b39e989822n%40googlegroups.com.
> >
> >

[-- Attachment #2: Type: text/html, Size: 6078 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 4907 bytes --]



On Mon, 12 Apr 2021, PEGGY TAWAH wrote:

> Ok, thanks! 

Don't top post.

julia

>
> On Mon, Apr 12, 2021, 1:01 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>       On Mon, 12 Apr 2021, PEGGY TAWAH wrote:
>
>       > Thank you Julia for your timely feedback and intervention. i
>       think the patch
>       > got mixed up after i did git add <name of file modified> now i
>       understand it
>       > was a wrong move.  will fix that right away and submit.Thanks
>       again.
>
>       Actually, someone else said that it is a generated file.  So you
>       should
>       just move on to something else.
>
>       julia
>
>       > Tawah Peggy
>       >
>       > On Monday, April 12, 2021 at 6:10:56 AM UTC-4
>       Julia....@inria.fr wrote:
>       >
>       >
>       >       On Sun, 11 Apr 2021, tawahpeggy wrote:
>       >
>       >       > remove one empty line.CHECK: Please don't use multiple
>       blank
>       >       lines
>       >
>       >       Did something go wrong with the patch generation? You
>       say that
>       >       you are
>       >       removing one line, but the diff information looks like
>       you are
>       >       adding a
>       >       file. Normally a patch has only the changed lines and a
>       few
>       >       lines before
>       >       and after.
>       >
>       >       > Signed-off-by: tawahpeggy <tawahp...@gmail.com>
>       >
>       >       You need to put your real name when contributing to the
>       Linux
>       >       kernel.
>       >
>       >       For example, I would put:
>       >
>       >       Julia Lawall <julia....@inria.fr>
>       >
>       >       julia
>       >
>       >       >
>       >       > ---
>       >       > drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>       >       > 1 file changed, 0 insertion(+), 1 deletion(-)
>       >       > create mode 100644
>       drivers/staging/comedi/comedi_pcmcia.mod.c
>       >       >
>       >       > diff --git
>       a/drivers/staging/comedi/comedi_pcmcia.mod.c
>       >       b/drivers/staging/comedi/comedi_pcmcia.mod.c
>       >       > index 0904b8765afs96..3984db1a39c8
>       >       > --- /dev/null
>       >       > +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
>       >       > @@ -0,0 +1,31 @@
>       >       > #include <linux/module.h>
>       >       > #define INCLUDE_VERMAGIC
>       >       > #include <linux/build-salt.h>
>       >       > #include <linux/vermagic.h>
>       >       > #include <linux/compiler.h>
>       >       >
>       >       > BUILD_SALT;
>       >       >
>       >       > MODULE_INFO(vermagic, VERMAGIC_STRING);
>       >       > MODULE_INFO(name, KBUILD_MODNAME);
>       >       >
>       >       > __visible struct module __this_module
>       >       > __section(".gnu.linkonce.this_module") = {
>       >       > .name = KBUILD_MODNAME,
>       >       > .init = init_module,
>       >       > #ifdef CONFIG_MODULE_UNLOAD
>       >       > .exit = cleanup_module,
>       >       > #endif
>       >       > .arch = MODULE_ARCH_INIT,
>       >       > };
>       >       >
>       >       > #ifdef CONFIG_RETPOLINE
>       >       > MODULE_INFO(retpoline, "Y");
>       >       > #endif
>       >       >
>       >       > MODULE_INFO(staging, "Y");
>       >       >
>       >       > MODULE_INFO(depends, "pcmcia,comedi");
>       >       >
>       >       > -
>       >       > MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
>       >       > --
>       >       > 2.17.1
>       >       > h-Hartman <gre...@linuxfoundation.org>
>       >       >
>       >       > --
>       >       > You received this message because you are subscribed
>       to the
>       >       Google Groups "outreachy-kernel" group.
>       >       > To unsubscribe from this group and stop receiving
>       emails from
>       >       it, send an email to outreachy-kern...@googlegroups.com.
>       >       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA35
>       24%40
>       >       peggy-Lenovo-V130-15IKB.
>       >       >
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups
>       > "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an
>       > email to outreachy-kernel+unsubscribe@googlegroups.com.
>       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/3c032481-f359-45c7-
>       947b-
>       > 54b39e989822n%40googlegroups.com.
>       >
>       >
>
>
>